Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e7444263-0ce5-1575-8cca-1e51b1cfbe9a@synaptics.com>
Date:   Fri, 30 Jun 2023 17:51:47 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v3 04/11] media: videobuf2: Stop define VB2_MAX_FRAME as
 global
Content-Language: en-GB
To:     Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com,
        linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org,
        hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar,
        p.zabel@pengutronix.de, linux-rockchip@lists.infradead.org,
        mchehab@kernel.org, linux-staging@lists.linux.dev,
        ming.qian@nxp.com, kernel@collabora.com,
        gregkh@linuxfoundation.org, tfiga@chromium.org,
        nicolas.dufresne@collabora.com
References: <20230622131349.144160-1-benjamin.gaignard@collabora.com>
 <20230622131349.144160-5-benjamin.gaignard@collabora.com>
From:   Hsia-Jun Li <Randy.Li@synaptics.com>
In-Reply-To: <20230622131349.144160-5-benjamin.gaignard@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGlKY0U4cXg0T1M5YzJJNXVOODVHbURJZ3ZsNmRxckt0RlFMd0YvQXpmRFNZ?=
 =?utf-8?B?UzFXdExMSXc2ejkyRzNqeVBxcWRjNW9kTHVVYUNLMVloOEtCeTcrRnBtaU0y?=
 =?utf-8?B?UjJFSDBETjUxNzlpQmNKblpTcHdKSUZNSkh0N2x4SWJKRElqV0U5N2VLQTNz?=
 =?utf-8?B?UmpuZDdVbnZZSmhYYnZFV1BBUk5DWHBtTFVSYXNmMlVBcUVkcWlSV2NFTXQv?=
 =?utf-8?B?WmY5L1dDY2hRREhBMEVsNmUrSXRqZjlnSEt3VGt6SjJETEZ3TlEzWWlpbVR0?=
 =?utf-8?B?cFV1N1NvcGxUNUZya2hKdmhXOWNaZWJuZWVNampURWZrQ3lYU3BRMUNFZFRr?=
 =?utf-8?B?a3pMbHJjTEpiV2oyd2RwUjJtNUtmanEzQ1FFTnB2UWliWVdyOFh0eHBjV2hM?=
 =?utf-8?B?M2ZKZUZUQXJyR2VYV3ppbHJ3SXVUN3FNYjAxZUhDeFZhYlRYa1dtVlJpNXRk?=
 =?utf-8?B?SGFSUHZLaTNZNWZhQlc1cElTS1d3eEZraUV0b3Y3M01aWGwrbzZUeU90eENr?=
 =?utf-8?B?ZWVUY1B3dS9Db1p5aDl2OUJWSkkzazhhaUovMnVrbmpDcGtsUUJlVjJBOS9S?=
 =?utf-8?B?c1lTQWIrYXlrZmdiOHlSTGJVS0tHNWw5OXVCalhsR3hIQlkrYlhvL3RhT0hV?=
 =?utf-8?B?NmREUk1NTFlieE5HcVdualR0YnVQeCt0dnJpTGRjdUV4WWkvUFlzcCtFbEtB?=
 =?utf-8?B?TlNCaVd5bDR2ZGt0QXRqNDFJSHVxTlhDTWo1L1FtZlQ1UENXODBWSlBJZ1ow?=
 =?utf-8?B?WTVkOTVpc0FyaXcyL2JhY0RHMHJDc1FsR3NndXM0d2hreGdUaXc0czZQOHFp?=
 =?utf-8?B?T1c3T2U3Z05qWmpFaXZPcmVaNnMxSnQrVGhLRkUwNjF1OXRuNzJSaFV5QUJM?=
 =?utf-8?B?Ui9ydXZqRm5qK2s5Qnhqd1EzdEJERlFCV0VWWVlQTVZxSUFxUnJQblJaSUlB?=
 =?utf-8?B?UDNwYUxDWDgrRjc2YTc2dW50QmlMUEdHaEpodlI0VnNoSWE4OUd5NUg0M1Nl?=
 =?utf-8?B?MmsxVnFMeFlKNlhxVnRrQVRySVk5TmxQdTl3NU8xTjQvUUozdUtZbjlnS1Ju?=
 =?utf-8?B?Z0Y1VGF4YmNCalAyNXRLeUtKUnBjNXcrT05ZYmRCS2RKbWQ2eVRRVWhJMEdm?=
 =?utf-8?B?RHFadjZMcEk2UWNpRWxvcTdHd1pIcytmOHdDNDRZTmJXUXZnQWJSdmtYRU1J?=
 =?utf-8?B?YldQRCtrTVlUUmNKYnY3Mk5TS2tCSGNOVVc1L0dsaEtpSHJ3UWtNaTA5cW56?=
 =?utf-8?B?MElWMitTSmkxWmhLV0VMdFdHMERXb3JXcGh5ZVJRaXF2YjJzRzR0cExteTBR?=
 =?utf-8?B?QU9BRC9DN2xlbVp2K2FZK2NNUVZEcG8zTXdKYTVyanRGWEVVVERFUmRzQmxt?=
 =?utf-8?B?eGhVbHJxOU1VZTVhek1XdzBRWUtWdEdMY1NGWWc0NW82UExpa25FcCtSaHRX?=
 =?utf-8?B?TzdzMGdLQmtKcG1MS2c1UkFTb2FpQXdZTWtUcUdrOWxUbS84VG5JY2taVlVw?=
 =?utf-8?B?SnlTNTdyTGhvT2NQT05KVzE0ZmI5bURiVmhDY3NuQ1kyTWlEVTBaa0tybWU1?=
 =?utf-8?B?UTFKVlVqOFg4RlFIcTR3T1pMVzNKazh3QVJaKy9aYWhhY2poSkFDbVgxWENn?=
 =?utf-8?B?Y0lLelZkNW1rSHl0T0ZjekI3QkVRN1g4cE1pTzRJYlZMMTN2NVZnajdiU1dZ?=
 =?utf-8?B?ODdqQTlwQTJySmhxbUhEWDIxSjB0bGlFdkprN2sycVdLR1hQNHhHWXZ0ajRa?=
 =?utf-8?B?UEQvV2d6VHppNHVaNTRCRTJoZnp4OTJQYUlPcVRiT0xHS1pqRVIxVDBqaXND?=
 =?utf-8?B?RmpnM1dLNnhtTVFoNTNsSEhFMVVyS2hpTDhFUlhJbXZjNFUxOUJmcWFEWm9O?=
 =?utf-8?B?UW1kNnNvdXpIVUgzVjd4dDk1WWRlN0tOVWdZbXFJZFdIc0kzMDdQZTVvSVpW?=
 =?utf-8?B?SXFSZWNzVUpHRWN1OVJvU0hyRjJ2a3FBVFlqUjdFd0cyOG1LM1dmVWhZTEpt?=
 =?utf-8?B?ZkJ6YkVsVjgxckllRVVtVlMzZStDNDNHMnNNUHhudjJteE43Vk9DT0FIT05D?=
 =?utf-8?B?cUVIZGpHNkcreXZmYktCakdTU0M2L1ZWd0FxQy9ESGo0dUg5NjlGcmVVWmx4?=
 =?utf-8?Q?o4hyEU2pzt0GGOo0PYbVbFeer?=
X-OriginatorOrg: synaptics.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b48e132-8e81-4c81-9c4a-08db794fa3ea
X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5196.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 09:51:56.3519
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ULsmvgYV14IAdasUocgpYSLNM4ydMnyY4s/2LA4xKfb8qRSP+6YsylPo4FsHmHff6vqW01cJ1EN5M9biQb7YxA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5649
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/22/23 21:13, Benjamin Gaignard wrote:
> CAUTION: Email originated externally, do not click links or open attachments unless you recognize the sender and know the content is safe.
>
>
> After changing bufs arrays to a dynamic allocated array
> VB2_MAX_FRAME doesn't mean anything for videobuf2 core.

I think make it 64 which is the VB2_MAX_FRAME in Android GKI kernel is 
more reasonable.

It would be hard to iterate the whole array, it would go worse with a 
filter. Such iterate may need to go twice because you mix 
post-processing buffer and decoding buffer(with MV) in the same array.

> Remove it from the core definitions but keep it for drivers internal
> needs.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> ---
>   drivers/media/common/videobuf2/videobuf2-core.c               | 2 ++
>   drivers/media/platform/amphion/vdec.c                         | 1 +
>   .../media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c | 2 ++
>   drivers/media/platform/qcom/venus/hfi.h                       | 2 ++
>   drivers/media/platform/verisilicon/hantro_hw.h                | 2 ++
>   drivers/staging/media/ipu3/ipu3-v4l2.c                        | 2 ++
>   include/media/videobuf2-core.h                                | 1 -
>   include/media/videobuf2-v4l2.h                                | 4 ----
>   8 files changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> index 86e1e926fa45..899783f67580 100644
> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> @@ -31,6 +31,8 @@
>
>   #include <trace/events/vb2.h>
>
> +#define VB2_MAX_FRAME  32
> +
>   static int debug;
>   module_param(debug, int, 0644);
>
> diff --git a/drivers/media/platform/amphion/vdec.c b/drivers/media/platform/amphion/vdec.c
> index 3fa1a74a2e20..b3219f6d17fa 100644
> --- a/drivers/media/platform/amphion/vdec.c
> +++ b/drivers/media/platform/amphion/vdec.c
> @@ -28,6 +28,7 @@
>
>   #define VDEC_MIN_BUFFER_CAP            8
>   #define VDEC_MIN_BUFFER_OUT            8
> +#define VB2_MAX_FRAME                  32
>
>   struct vdec_fs_info {
>          char name[8];
> diff --git a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> index 6532a69f1fa8..a1e0f24bb91c 100644
> --- a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> @@ -16,6 +16,8 @@
>   #include "../vdec_drv_if.h"
>   #include "../vdec_vpu_if.h"
>
> +#define VB2_MAX_FRAME  32
> +
>   /* reset_frame_context defined in VP9 spec */
>   #define VP9_RESET_FRAME_CONTEXT_NONE0 0
>   #define VP9_RESET_FRAME_CONTEXT_NONE1 1
> diff --git a/drivers/media/platform/qcom/venus/hfi.h b/drivers/media/platform/qcom/venus/hfi.h
> index f25d412d6553..bd5ca5a8b945 100644
> --- a/drivers/media/platform/qcom/venus/hfi.h
> +++ b/drivers/media/platform/qcom/venus/hfi.h
> @@ -10,6 +10,8 @@
>
>   #include "hfi_helper.h"
>
> +#define VB2_MAX_FRAME                          32
> +
>   #define VIDC_SESSION_TYPE_VPE                  0
>   #define VIDC_SESSION_TYPE_ENC                  1
>   #define VIDC_SESSION_TYPE_DEC                  2
> diff --git a/drivers/media/platform/verisilicon/hantro_hw.h b/drivers/media/platform/verisilicon/hantro_hw.h
> index e83f0c523a30..9e8faf7ba6fb 100644
> --- a/drivers/media/platform/verisilicon/hantro_hw.h
> +++ b/drivers/media/platform/verisilicon/hantro_hw.h
> @@ -15,6 +15,8 @@
>   #include <media/v4l2-vp9.h>
>   #include <media/videobuf2-core.h>
>
> +#define VB2_MAX_FRAME  32
> +
>   #define DEC_8190_ALIGN_MASK    0x07U
>
>   #define MB_DIM                 16
> diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
> index e530767e80a5..6627b5c2d4d6 100644
> --- a/drivers/staging/media/ipu3/ipu3-v4l2.c
> +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
> @@ -10,6 +10,8 @@
>   #include "ipu3.h"
>   #include "ipu3-dmamap.h"
>
> +#define VB2_MAX_FRAME  32
> +
>   /******************** v4l2_subdev_ops ********************/
>
>   #define IPU3_RUNNING_MODE_VIDEO                0
> diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
> index 77921cf894ef..080b783d608d 100644
> --- a/include/media/videobuf2-core.h
> +++ b/include/media/videobuf2-core.h
> @@ -20,7 +20,6 @@
>   #include <media/media-request.h>
>   #include <media/frame_vector.h>
>
> -#define VB2_MAX_FRAME  (32)
>   #define VB2_MAX_PLANES (8)
>
>   /**
> diff --git a/include/media/videobuf2-v4l2.h b/include/media/videobuf2-v4l2.h
> index 5a845887850b..88a7a565170e 100644
> --- a/include/media/videobuf2-v4l2.h
> +++ b/include/media/videobuf2-v4l2.h
> @@ -15,10 +15,6 @@
>   #include <linux/videodev2.h>
>   #include <media/videobuf2-core.h>
>
> -#if VB2_MAX_FRAME != VIDEO_MAX_FRAME
> -#error VB2_MAX_FRAME != VIDEO_MAX_FRAME
> -#endif
> -
>   #if VB2_MAX_PLANES != VIDEO_MAX_PLANES
>   #error VB2_MAX_PLANES != VIDEO_MAX_PLANES
>   #endif
> --
> 2.39.2
>
-- 
Hsia-Jun(Randy) Li