Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <175a9095-bd8a-4384-c573-cfe8267a8417@intel.com>
Date:   Fri, 30 Jun 2023 12:10:46 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v5 08/10] acpi/nfit: Improve terminator line in
 acpi_nfit_ids
Content-Language: en-US
To:     Dan Williams <dan.j.williams@intel.com>,
        <linux-acpi@vger.kernel.org>
CC:     <rafael@kernel.org>, <vishal.l.verma@intel.com>, <lenb@kernel.org>,
        <dave.jiang@intel.com>, <ira.weiny@intel.com>,
        <rui.zhang@intel.com>, <linux-kernel@vger.kernel.org>,
        <nvdimm@lists.linux.dev>
References: <20230616165034.3630141-1-michal.wilczynski@intel.com>
 <20230616165034.3630141-9-michal.wilczynski@intel.com>
 <649deeb7c0e94_11e6852949@dwillia2-xfh.jf.intel.com.notmuch>
From:   "Wilczynski, Michal" <michal.wilczynski@intel.com>
In-Reply-To: <649deeb7c0e94_11e6852949@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OFI3R08xWTI3UGpldENTNDBoNUZ6SXJDazExZ0IrNitqdGxabDJEam5SbTJ2?=
 =?utf-8?B?d1VEZXlXNXY3NE9QUUFyL3NMa09kYUJSdlhGWk1vcUJPNEM5R0NjeW1ocnp3?=
 =?utf-8?B?MkszTTFDaFhkcUNzRHg2K0loYTg2cEMwdzRjcTNNVkViblA0U1hndTEreVMv?=
 =?utf-8?B?WmRMQjgrNlFaUWlidkczNSsyaTUzVWF4YUJKNTNDb0FkYWxtSUNTaXQzT1hB?=
 =?utf-8?B?WUJ1SWJUWStqV1ZVcW40cjFQem92OVhkMXl4QTBxL3AwY2FHZEd1Q2V4QXV4?=
 =?utf-8?B?ajhvQTJsWEFHUkVtc0ZoWU5JTzlRSnMrQTdCTkxWOWF5MXVHN1c5b2dJRGJn?=
 =?utf-8?B?eFVZY1lScXpMekt3TG1oWjBkdEdCb2VFMlZ2azhGODFISmFyWGh2cGVNZFQ3?=
 =?utf-8?B?NWJTVHF4clFYU1BoMkhRZTdzdEtqNDJqSElVVXIwZ3pXeHAxWmJ1eTNpZVp6?=
 =?utf-8?B?ZS94Q0IvSkU2TnRiNkVQTEhGZmt4L3haWFl0QVQvenJjYmt4R2R3ZmM0VFdK?=
 =?utf-8?B?ZHVieFJKNms2MEtqMU5TSUZzMXBaeVF3ZHE1Z3FRYUw5RHFxZkRhS1RRWStx?=
 =?utf-8?B?d0JUL2F5YlpxUzBzdDYzSmJ5eWVGU2JEaTNzVDRNUHYzT1QzeFRPMDRNeEkr?=
 =?utf-8?B?eWlPR2p4UVlNVElnK2FOSXlEeU4yMXVkRklFTjBPRVNLMGhTdjFaVHpiUzl0?=
 =?utf-8?B?VUR1S0Nib2dQYTFhUDdFalgwWU5RQW1lem5tOXQwVnN6bk5BODEyYTlGVTVC?=
 =?utf-8?B?ZnBLZTBHUHMzZVEyYU9BcC9GelhBVjA1NGtleDlQZFk1K0JUa0VObEhJdU0r?=
 =?utf-8?B?VlZySlkyOUJWVGpDSTZvL2tGeUgwSGxtQzZuSmdQWWpuQjkxclRGTmhHOVZ4?=
 =?utf-8?B?dlZ0eUY5UTQ1bGxGUEluS1FjbVNMTjU1c0xja0lkbk90ZmVTVUJXSjh2c3pE?=
 =?utf-8?B?NW1qakhDU2pLM3JoMTgxWEczUlFnY2diNjQyNmwwV2xKczFIODY4dXZYakZX?=
 =?utf-8?B?R1B1aTVYai9lV3lRK0pRS000WURyeG4yRW5mMk9xWWE2bHFrTks0M0llWmhC?=
 =?utf-8?B?MlVzOGdoNUxJOHByZHR6RUw0OE1FZktaRjRmc0tHaFlyN1ptNW9HT2pzd2x2?=
 =?utf-8?B?RXdhVDVEUGJRbGpHNDVTTnJ2ZVA5ZXJPeG5NZ0ZUTFlYZ2JZVFdvMkxZZDdV?=
 =?utf-8?B?cjRnVE9yZG9PNm50em1CYVR1RmIyS0tqN09kSm5YOHNleTM3WVpXWnZsWDc4?=
 =?utf-8?B?S0N2TWVlYXV4M1FXUWZ0eGVnUE1uZlh6aWcyRnFtZmp2VytqMUhYVmRPTnhH?=
 =?utf-8?B?Tlk2cnRqUlcrTjU4MTNrdjFiemFSSlJKSkhjbTlONzJzVHJPSi9zWDJQQlhH?=
 =?utf-8?B?d0xiclBXNmFEbmJzbVZSQ3lwRWZhUXFUSE15bGd3MzhiMklXa29UcTdWTFRS?=
 =?utf-8?B?VDI4NEVpNXpiNStEVDhJazZ6bC9CZENnMmRXYlZlVENYdlRkQm9ueDZ4d1Jz?=
 =?utf-8?B?K1pseXhEVGk4NGtCK05CSUFaNnIzR3paaDFwTy9OZmpHazNtYWRUZVVuay9Z?=
 =?utf-8?B?N1Nmak5ORFlsUjZXVVIvUnkyS05DalJ5VUlndnV3REpTd01lK2ZZNFNyekx0?=
 =?utf-8?B?M3NWQko1MWpuVFN0WWdsb2hWQjc0bUdRT0c0dm5GdHUyelpzek9qK3ZPMDFk?=
 =?utf-8?B?aWc4cnFQNFl4VXVUZDVUYStJbEw1T2QvOWxXcjkrR2xaU2ljTE1FQ1NudWV6?=
 =?utf-8?B?Zk9ZaU5JcmZoWE1wMVhxNEZzc3N4RlllekpFOHh2cFZlaDE4QzA0WDQ5Mnc1?=
 =?utf-8?B?NHZRY1BadGhEazZPVnhSWmtpSEZoZVdWbnFIbmxpd3Zja3RDZU5tM2dXdmYr?=
 =?utf-8?B?RU80NkQvbVFncmhJMkY0QUlRUEZLSk1mSmFRMkN4YWlJWldqNEJqdFEvS0tN?=
 =?utf-8?B?RkVwWEl5SktIZlFCZU1uVllIYmF0bldsWENzVUhScWd4Q01xeWNXSVFKWlNY?=
 =?utf-8?B?RkxlMGljUG85N2p4WDNWVjV6RlpNNVJnbXBKbjRRTUJqK0plaTFqZlM5MzlP?=
 =?utf-8?B?MnhhY2NGanltQkJkOGIxTXRKczhhbEtweTUzRmpZOUVjTGFQd2p5djBHOENv?=
 =?utf-8?B?TFdoUGhIQzlKVDJUL2JEV0lrd2Vyb0s4bUtyakpOSk82S21xTzNxZlR5MUZH?=
 =?utf-8?B?OUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d8653ef0-9a2f-4dc8-182a-08db795249f2
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 10:10:54.0256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QPLOSBt5PdTHjndkr2zZ/RpNzgiossFCFeRwlPCLNruHqVlAwMLAxgxuQ1J3ZwR55rfRRWC1RGwSCSEy+EZwkKxcbw1E8uWLzb6fmZln3mY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7579
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/29/2023 10:51 PM, Dan Williams wrote:
> Michal Wilczynski wrote:
>> Currently terminator line contains redunant characters. Remove them and
>> also remove a comma at the end.
>>
>> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
>> ---
>>  drivers/acpi/nfit/core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
>> index aff79cbc2190..95930e9d776c 100644
>> --- a/drivers/acpi/nfit/core.c
>> +++ b/drivers/acpi/nfit/core.c
>> @@ -3455,7 +3455,7 @@ EXPORT_SYMBOL_GPL(__acpi_nfit_notify);
>>  
>>  static const struct acpi_device_id acpi_nfit_ids[] = {
>>  	{ "ACPI0012", 0 },
>> -	{ "", 0 },
>> +	{}
> Looks like a pointless change to me.

It's not very consequential, but isn't totally pointless in my view:

"Terminator line is established for the data structure arrays which may have unknown,
to the caller, sizes. The purpose of it is to stop iteration over an array and avoid
out-of-boundary access. Nevertheless, we may apply a bit more stricter rule to avoid
potential, but unlike, event of adding the entry after terminator, already at compile time.
This will be achieved by not putting comma at the end of terminator line"


Anyway I can drop this change, it's just confusing everyone