Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753292AbXJVJNs (ORCPT ); Mon, 22 Oct 2007 05:13:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751496AbXJVJNj (ORCPT ); Mon, 22 Oct 2007 05:13:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:52953 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364AbXJVJNh (ORCPT ); Mon, 22 Oct 2007 05:13:37 -0400 From: Andreas Schwab To: Geert Uytterhoeven Cc: Sam Ravnborg , Linus Torvalds , Andrew Morton , linux-kbuild , linux arch , LKML , Linux/m68k , Rob Landley Subject: Re: [PATCH] m68k: Use cc-cross-prefix (was: Re: [GI:wqT PULL] kbuild updates - second round) References: <20071019204415.GA623@uranus.ravnborg.org> <20071021182245.GA5840@uranus.ravnborg.org> X-Yow: LOOK!! Sullen American teens wearing MADRAS shorts and ``Flock of Seagulls'' HAIRCUTS! Date: Mon, 22 Oct 2007 11:13:28 +0200 In-Reply-To: (Geert Uytterhoeven's message of "Sun\, 21 Oct 2007 20\:29\:29 +0200 \(CEST\)") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1377 Lines: 47 Geert Uytterhoeven writes: >> Did you mean to use $(SUBARCH) here? ^^^^^^^ > Oops, indeed. Sorry, here's a new one... > > m68k: Use cc-cross-prefix > > Signed-off-by: Geert Uytterhoeven > --- > arch/m68k/Makefile | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > --- a/arch/m68k/Makefile > +++ b/arch/m68k/Makefile > @@ -13,16 +13,14 @@ > # Copyright (C) 1994 by Hamish Macdonald > # > > -# test for cross compiling > -COMPILE_ARCH = $(shell uname -m) > - > # override top level makefile > AS += -m68020 > LDFLAGS := -m m68kelf > LDFLAGS_MODULE += -T $(srctree)/arch/m68k/kernel/module.lds > -ifneq ($(COMPILE_ARCH),$(ARCH)) > - # prefix for cross-compiling binaries > - CROSS_COMPILE = m68k-linux-gnu- > +ifneq ($(SUB_ARCH),$(ARCH)) ^^^^^^^^ You did test it, didn't you? Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra?e 5, 90409 N?rnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/