Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: hsdF/YGBpmK5Qwq5ZuSufM8300OqOAVBzHY/4kqS90qmbAQ197uXHEBC0QvuePcxTmP0KsrQH7
 1aom+fJ1Sr6sIlmidw+8BMF/zoQrsKYv+xqkNKmYpyVOuT2yHi5gTkxBAsgBHueLYK2ahsk9wT
 fn+RC58eEW5peD/Za9HZmxM/yeUQYBwbe9DwkyfsS4txkyXM236M0FcL2BsZH/WvpgjB9nVTJ1
 d/lsZWVfNeXpuPrN7a2yQQUHPd7MwRKdEWtjOLe3H7NISDm7Cs6kUkZ+9LaJdmzv+miMu984qT
 NM8=
IronPort-SDR: BB/MP/DP9PYG2W8ozfSUvfosXIO1Tb3sHvHTNsZAycCfu2mf5plwhkng046DNLz7bdpgY7nBi/
 pCogec2t0JHZpi4sWufPyz7m9dnoThepfNXZx2w8rzukEAyM3PMmZHuOdNdkHzQQPaic8pCsih
 GBFElw8JW4IH6iryx3MkYbji8FwWnsDbbyk0Xw3pQBdbWdZX3RbBHX+wDrKZoowPAz5gRyeFMw
 PHxPZfubYmBHey30ywTL1QZKtZObkaCCO6gsf4h13lcsM5w7HwMlVtX9QPxjY18OjrvMsYyRXW
 9ug=
WDCIronportException: Internal
MIME-Version: 1.0
Date:   Fri, 30 Jun 2023 16:03:46 +0530
From:   aravind.ramesh@opensource.wdc.com
To:     Hans Holmberg <Hans.Holmberg@wdc.com>,
        Aravind Ramesh <Aravind.Ramesh@wdc.com>,
        Jens Axboe <axboe@kernel.dk>,
        "open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
        hch@infradead.org,
        =?UTF-8?Q?Mat?= =?UTF-8?Q?ias_Bj=C3=B8rling?= 
        <Matias.Bjorling@wdc.com>,
        Andreas Hindborg <a.hindborg@samsung.com>,
        open list <linux-kernel@vger.kernel.org>,
        Damien Le Moal <dlemoal@kernel.org>, gost.dev@samsung.com,
        Minwoo Im <minwoo.im.dev@gmail.com>, ming.lei@redhat.com
Subject: Re: [PATCH v4 1/4] ublk: change ublk IO command defines to enum
In-Reply-To: <83E5C27A-9AEF-4900-9652-78ACFF47E6B0@wdc.com>
References: <20230628190649.11233-1-nmi@metaspace.dk>
 <20230628190649.11233-2-nmi@metaspace.dk>
 <83E5C27A-9AEF-4900-9652-78ACFF47E6B0@wdc.com>
User-Agent: Roundcube Webmail
Message-ID: <a7bb663d522cde468b868e8e77110217@opensource.wdc.com>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

> From: Andreas Hindborg <a.hindborg@samsung.com 
> <mailto:a.hindborg@samsung.com>>
> 
> 
> This change is in preparation for zoned storage support.
> 
> 
> Signed-off-by: Andreas Hindborg <a.hindborg@samsung.com
> <mailto:a.hindborg@samsung.com>>
> ---
> include/uapi/linux/ublk_cmd.h | 23 +++++++++++++++++------
> 1 file changed, 17 insertions(+), 6 deletions(-)
> 
> 
> diff --git a/include/uapi/linux/ublk_cmd.h 
> b/include/uapi/linux/ublk_cmd.h
> index 4b8558db90e1..471b3b983045 100644
> --- a/include/uapi/linux/ublk_cmd.h
> +++ b/include/uapi/linux/ublk_cmd.h
> @@ -229,12 +229,23 @@ struct ublksrv_ctrl_dev_info {
> __u64 reserved2;
> };
> 
> 
> -#define UBLK_IO_OP_READ 0
> -#define UBLK_IO_OP_WRITE 1
> -#define UBLK_IO_OP_FLUSH 2
> -#define UBLK_IO_OP_DISCARD 3
> -#define UBLK_IO_OP_WRITE_SAME 4
> -#define UBLK_IO_OP_WRITE_ZEROES 5
> +enum ublk_op {
> + UBLK_IO_OP_READ = 0,
> + UBLK_IO_OP_WRITE = 1,
> + UBLK_IO_OP_FLUSH = 2,
> + UBLK_IO_OP_DISCARD = 3,
> + UBLK_IO_OP_WRITE_SAME = 4,
> + UBLK_IO_OP_WRITE_ZEROES = 5,
> + UBLK_IO_OP_ZONE_OPEN = 10,
> + UBLK_IO_OP_ZONE_CLOSE = 11,
> + UBLK_IO_OP_ZONE_FINISH = 12,
> + UBLK_IO_OP_ZONE_APPEND = 13,

Curious to know if there is a reason to miss enum 14 here ?
And if UBLK_IO_OP_ZONE_APPEND is defined along with other operations
better to define that in patch 3 itself.

> + UBLK_IO_OP_ZONE_RESET = 15,
> + __UBLK_IO_OP_DRV_IN_START = 32,
> + __UBLK_IO_OP_DRV_IN_END = 96,
> + __UBLK_IO_OP_DRV_OUT_START = __UBLK_IO_OP_DRV_IN_END,
> + __UBLK_IO_OP_DRV_OUT_END = 160,
> +};
> 
> 
> #define UBLK_IO_F_FAILFAST_DEV (1U << 8)
> #define UBLK_IO_F_FAILFAST_TRANSPORT (1U << 9)

Regards,
Aravind