Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fed91877-6b55-efc1-76b3-e562f4c6914d@leemhuis.info>
Date:   Fri, 30 Jun 2023 15:05:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] ACPI: resource: Add IRQ override for MECHREV Jiaolong17KS
Content-Language: en-US, de-DE
To:     Li Chen <me@linux.beauty>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-acpi <linux-acpi@vger.kernel.org>,
        Len Brown <lenb@kernel.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Mario Limonciello <mario.limonciello@amd.com>
References: <1890c3fa24c.d101fdf01298845.3731868257024939195@linux.beauty>
From:   "Linux regression tracking (Thorsten Leemhuis)" 
        <regressions@leemhuis.info>
Reply-To: Linux regressions mailing list <regressions@lists.linux.dev>
Cc:     Linux kernel regressions list <regressions@lists.linux.dev>
In-Reply-To: <1890c3fa24c.d101fdf01298845.3731868257024939195@linux.beauty>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

[CCing mario and the regressions list]

On 30.06.23 14:20, Li Chen wrote:
> Fix a regression introduced by commit 9946e39fe8d0 ("ACPI: resource: skip
> IRQ override on AMD Zen platforms") on MECHREV Jiaolong17KS, which
> causes the built-in keyboard to not work. This restores the functionality
> by adding an IRQ override.
> 
> I have personally tested this on the 17" model but I'm not sure if this
> issue is present on the 16 model.
> 
> Fixes: 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen platforms")
> Signed-off-by: Li Chen <me@linux.beauty>

Not my area of expertise (so take this with a gain of salt), but I'm
aware of something that afaics concerns this:

A few days ago a patch was merged to mainline that afaics hopefully
might make a change like your unnecessary.  See a9c4a912b7d ("ACPI:
resource: Remove "Zen" specific match and quirks") in mainline or here:
https://lore.kernel.org/all/20230601221151.670-1-mario.limonciello@amd.com/

Might be worth giving a try.

There is a rough plan to backport this to stable kernels, unless
problems show up.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.