Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Jun 2023 15:13:20 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Vivek Pernamitta <quic_vpernami@quicinc.com>
Cc:     mhi@lists.linux.dev, mrana@quicinc.com, quic_qianyu@quicinc.com,
        manivannan.sadhasivam@linaro.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V1] net: mhi : Add support to enable ethernet interface
Message-ID: <ZJ7U8D1Ej63lX06g@corigine.com>
References: <1688118281-13032-1-git-send-email-quic_vpernami@quicinc.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1688118281-13032-1-git-send-email-quic_vpernami@quicinc.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zhZvINureo+c/P2MK52jam/zAYchwniE1F7YtFgebadJ3EVTOvHonCYXwtaP?=
 =?us-ascii?Q?+hiec+1jXSv6Jgbqbg3pK00ocextjrE58INM+dbJlVFTWmFUsnl0j6+fjncS?=
 =?us-ascii?Q?ZvrwqdRa2CBkeLcEY5dFj1NGsng3DVClkEdGJ4Qt9WSPrQqVHV4/D3mL4Hu4?=
 =?us-ascii?Q?jv0p+RVtuPt/aSaWv+FnLNKixifXx1EFbMgB0VWejiFBnYzc84C7+jc42Sek?=
 =?us-ascii?Q?8uBPmnn4f1TmIkbNv3Q2rZKhVPT9j0KhL9Fz9tuymzOkr7khzFNkrdoDPAM8?=
 =?us-ascii?Q?y2I1b25z/h0ydOh5RICNjBW/aghwj63JbyPyposkhf9irhSuNnkAGN/UCUMg?=
 =?us-ascii?Q?Aw2eR18qkV7DNrHDplq7Uk9rnz+NID70hecdJ7JMN8rYSZFkTOouXcCmDI9/?=
 =?us-ascii?Q?BBYtDdQf6V8SVNuvsKkr+w/ggYIsECHOY3nEFOQIspZ9cwdVhHrzlpL9AcjD?=
 =?us-ascii?Q?IRAQ5ccGo0mT4W4ZBqy+GgAGJQcEn2MW9+NNHK6DhCnn4DAOYCTOhR2UFqrC?=
 =?us-ascii?Q?ba4BFKxbmHxc37DGWtBHf95JU5in+TyQt6rG2MA9OjIKwJ3SAkUaGQh8PAMz?=
 =?us-ascii?Q?rcWFOG6b4J7s4KcGeBU1/aaccLPTwJVIqKizLp3YLCQ1EmEyrzmAjIUnKxGz?=
 =?us-ascii?Q?K767mLJZvj50HwEFq6C/h4N08MnhTS8joBUrnPoK/TAv5AdsasXIEAZXq8QX?=
 =?us-ascii?Q?IhzBTIvVFetc2DEhU+409bRLmsiYpdZh3+y3dpwoNzwCki4zWL6oW7leokn8?=
 =?us-ascii?Q?gvIsex1pkGyZ04/lR764ymwxUlB/lTiUBo3Vunv1KX6BBdZunaxqpH/pHHfu?=
 =?us-ascii?Q?x7/NWqihofYCsEYxwcP1OZlh1iKxob0MH1u5nhij/UUhfV0i7VSfowLYhDf9?=
 =?us-ascii?Q?0TugEYrCfhHK3NiuI/rX0T6XDcXbb5l3z+aJcaLUA0cMlzURxzrNiDlKHhuL?=
 =?us-ascii?Q?doyQn/PrU1Nua9W+41q1zIgHHNOCW1nCgrVxiI6ZMyw8vT2VoZGrpu/rxOyh?=
 =?us-ascii?Q?xkyKDYHyB0AgkwcXOTu5aAZTXY4HRpDEXOnHWKlT18DoyxtT0skixu6WPCf5?=
 =?us-ascii?Q?kgfZUk/G52L4zoXHWW2QD3XU4dzyXqBZ8yJvgjgEuSThi+At5aEpgkcQ5+0v?=
 =?us-ascii?Q?jqZCaZT+b9YyXdFbbsRi9dHBpEZN9RIDcBeXQQK4/xHiWWA2yPDQkhnw8xX8?=
 =?us-ascii?Q?JPFMlGAa2skEGrlDOY7sSmVaD4qobuv2voVU79z3BGy9ob1N+/LcByRRUssh?=
 =?us-ascii?Q?si8RpweMaOcjwKOKtS+RsYO8NG6Ase6f6xC1rACM+KlCjn6nR/6q2YhxTaYT?=
 =?us-ascii?Q?7AsCTxHof7iAa+LLooQSQXBWXkwXE2Zwcb0btykSu3iEp7RoCxw4OYImiW0v?=
 =?us-ascii?Q?6NUc/uExobN+JdBhLorIWXkzfX98nF61siErsX6HyqfGflBfbpqTds9mY1xg?=
 =?us-ascii?Q?BD8SONuwQrAEpHw1TDRv6LPYDo/A1dYMwyVWwF/r0mFH+NkqqYmRreQzzxzt?=
 =?us-ascii?Q?sLcFSto5V9OBy4m7BhRI1J1xTSXdTUuSl/axdSlqjjmuF64ieRGK/cVZEUhy?=
 =?us-ascii?Q?D1tum3ehvdKyzKzwBeXyABqajfrCCMpa72kbXOiHFkM7zs0719OzCSQsFCQ9?=
 =?us-ascii?Q?fInwLSkF5ZElgBl03/4udfpcxERj38LQIGSE0UtrHKyhYj89kCt6cbNYUx1q?=
 =?us-ascii?Q?DF2gGQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4365730-030f-42d8-04f6-08db796bcb1f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 13:13:28.0738
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zJgRDvkQq6vuYwRpQunEP2VTwBzA0KOnO0Q/oRsB892LON5wyJUK4g2EAyeX8wOh2wbS4WRS2FpWgEXlWrZbLJKUKFDVIS078/SAmMwuKns=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR13MB4572
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 30, 2023 at 03:14:41PM +0530, Vivek Pernamitta wrote:
> Add support to enable ethernet interface for MHI SWIP channels.
> 
> Signed-off-by: Vivek Pernamitta <quic_vpernami@quicinc.com>

...

> @@ -301,11 +318,17 @@ static void mhi_net_rx_refill_work(struct work_struct *work)
>  		schedule_delayed_work(&mhi_netdev->rx_refill, HZ / 2);
>  }
>  
> -static int mhi_net_newlink(struct mhi_device *mhi_dev, struct net_device *ndev)
> +static int mhi_net_newlink(struct mhi_device *mhi_dev, struct net_device *ndev, bool eth_dev)
>  {
>  	struct mhi_net_dev *mhi_netdev;
>  	int err;
>  
> +	if (eth_dev) {
> +		eth_random_addr(ndev->dev_addr);
> +		if (!is_valid_ether_addr(ndev->dev_addr))
> +			return -EADDRNOTAVAIL;
> +	}

Hi Vivek,

This doesn't seem right.
As GCC points out, dev_addr is const.
And I don't think eth_random_addr() produces invalid addresses.

Perhaps you want eth_hw_addr_random() here.

As was mentioned elsewhere in this thread, net-next, is closed.
So please post a v2 once it re-opens, after 10th July.

-- 
pw-bot: changes-requested