Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Jun 2023 15:34:36 +0200
From:   Wolfram Sang <wsa+renesas@sang-engineering.com>
To:     Ulf Hansson <ulf.hansson@linaro.org>
Cc:     Dennis Zhou <dennis@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Linux MMC List <linux-mmc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Biju Das <biju.das.jz@bp.renesas.com>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2] mmc: inline the first mmc_scan() on mmc_start_host()
Message-ID: <ZJ7Z7HL684hrSkdx@sai>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Dennis Zhou <dennis@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Linux MMC List <linux-mmc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Biju Das <biju.das.jz@bp.renesas.com>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>
References: <20230329202148.71107-1-dennis@kernel.org>
 <ZCTOMVjW+pnZVGsQ@snowbird>
 <CAMuHMdVK2zPnyB9s0uYwoKj0xspa0CRzqPjhrj-YFqVNdXxEkg@mail.gmail.com>
 <CAPDyKFqtgCK5Wb_fZ9+VVK1F-LWYL+htMvQ9JPpp0zPjzBZ9gw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ardNddU0yOlyz+Nq"
Content-Disposition: inline
In-Reply-To: <CAPDyKFqtgCK5Wb_fZ9+VVK1F-LWYL+htMvQ9JPpp0zPjzBZ9gw@mail.gmail.com>
Precedence: bulk


--ardNddU0yOlyz+Nq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


> Note that, even if the offending commit below triggers this problem
> 100% of the cases (as the probe path has now becomes synchronous),
> there was a potential risk even before. Previously, mmc_add_host()
> ended up punting a work - and if that work ended up sending a request
> to the host driver, *before* the irq-handler would be ready, we would
> hit the similar problem. I bet adding an msleep(1000) immediately
> after mmc_add_host() in tmio_mmc_host_probe(), would then trigger this
> problem too. :-)
>=20
> That said, I am going to revert the offending commit to fix these
> problems, for now. Then I will try to help out and fixup the relevant
> host drivers  - and when that is done, we can give this whole thing a
> new try.

I'll work on the TMIO/SDHI driver next week. Thanks for the input!


--ardNddU0yOlyz+Nq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmSe2egACgkQFA3kzBSg
KbYL0w//Uf2zwM8QA+MvS/28kErGL3iHJwmv3aOLVBcTQcZobGoGYTX7ylZridqi
k2bsQszEYrOqQHg5Nrgze3x1CmSW4zbKZhz67yhBWobwTY8wkYg/lVraQuXJPJQG
13J/Cfugtx+QcCfWwvdAyEd/FarBjMMUlBjjft8zz8OT5S4j3MWLKNg+k08Ytkou
C6TX2YYaSuzkUXo/6j8Zak+OUlIWVAthAnmExWwL8a2azufZoFizG+kWZIXyyjB3
MGFkNo39lM72eNCKhV8yScEm+DwRIVwnlMxGpy8bk5/Xh9YwJaYDAJgZHB3ZwcyE
LF/iI8h/EM6GTodNB97UQCFSkrHCyp9En+tqViXKaHrzZvG4Uudju8JZsNl1e/nX
TOmaSS4usgQfYX7nyO9niohJiw40KXC2xM+ZSLIQkxYwfPF0icqcOXm8mBTiJYO0
2W+Gs7iIK1+jroPGZtgu6uFplX8A5RgXSnBGyq0lE00GoEmVuV31kPuZPKGIXpdD
Q3INCdeaFEeR+0l+h9D3T5IkrVRv0VkxIPrgc2wZ13ZdgQx3/UzM57kybPZAz6Zk
x4FTMSxVOAQP57dOykCLOJMN0UhIB5RUJCJgKBPjbGt06fLEiuAzimd8+1O0jotl
BA9qn0A08k17fGaSL7bjmeNZkHQUoNiYiXgqJSMk5RREMDnavD8=
=suR+
-----END PGP SIGNATURE-----

--ardNddU0yOlyz+Nq--