Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Jun 2023 15:27:32 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Hariprasad Kelam <hkelam@marvell.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        davem@davemloft.net, sgoutham@marvell.com, lcherian@marvell.com,
        gakula@marvell.com, jerinj@marvell.com, sbhatta@marvell.com
Subject: Re: [net Patch 3/4] octeontx2-af: Add validation before accessing
 cgx and lmac
Message-ID: <ZJ7YRP9Fb4HUL1eg@corigine.com>
References: <20230630062845.26606-1-hkelam@marvell.com>
 <20230630062845.26606-4-hkelam@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230630062845.26606-4-hkelam@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HHgrFByFQl8RZH/9aBwVRd2u3KSP0kvKYIC+hjZD4vO0AzyrcpYpCBqIUd57?=
 =?us-ascii?Q?IMQwk2OID4i6eobndBXQHHVcQkWiR1G6Vp+s7EktighFdDPCi2ITif1Ogt/x?=
 =?us-ascii?Q?uO2mp7hIYNIVpKAz1FI830PVfzaBKsfIgS7hkXV4DlZh4/5HUlxDownpRAxu?=
 =?us-ascii?Q?VaTfWp0AN3rspA2zUgHfUybnv57M3gKdtgxz+b2OOCxEYj/heL+2a0qaJzSY?=
 =?us-ascii?Q?2/vy5aGGga2gQYdqY/zN5F87Br/RmkBSSybnJm1m7qDghfSTRb7JYMb5jzR3?=
 =?us-ascii?Q?Q3+/VokfSXzxhNv68rOM98qCoNY1iaTaglD6WfoFrtShVuLPs6Ozx7IswrZZ?=
 =?us-ascii?Q?g9N9foxju6PXaVtVxuxg2MtYC6sa1SkSb5/VqnojOHEmH/B7+lAK3ardQA9n?=
 =?us-ascii?Q?i/3Jh3aMTWrmxVPG9l+bzG37mVWgAYmEh4Jg83Wp8/cCvS44rtbwMNK+cNOW?=
 =?us-ascii?Q?QNlni5uyll2gbjyuhrYrgV+BMHOVxI9+Hrvw2fiYq879tEmqhkrT+E9hFq5O?=
 =?us-ascii?Q?efWn1vDAk0bE6yKiAaxVKXFxwTMTIxOWEuGr9cG1Lqw0cEfWdplJBwsFyMts?=
 =?us-ascii?Q?EYdLHPZlqlM7Uwz6MTDzlPLcOtj773tMx2ZFC8mDym81eRamJHte3oXuzAiw?=
 =?us-ascii?Q?jd8SBjWR0hVbm5tlvs3iGQSpCXoqxqjkjc+KpNExvU8fF+0bwHzL0PB7LHdl?=
 =?us-ascii?Q?dYMG1TH47pBK2MRb9mYcmWRoPwOIXNi42K9D9mpHMh6aH9WjpgEaG5+rWNIx?=
 =?us-ascii?Q?iQHb9gVuCUFfJEbwF24tYE0lOJhPfXgPpp9elpF9xg4zCglMzZLu+yqDQNrP?=
 =?us-ascii?Q?bYlV4qiNLsS4AuKyn2tdQ6jh4Ubr75Uh8mZCysiO0vVUMf8GhCirBYbsQRYj?=
 =?us-ascii?Q?hqFzSWt+sEBVvAnWhzAx4UeS7/rcWVWwgX8WzCtHwlgzbz1R4RovkCM4OxXU?=
 =?us-ascii?Q?jepkJEXAppVq1kHq3UPMSN6n32M526vAHm+qr1rvr4VBRmq6jjEHvXufoir8?=
 =?us-ascii?Q?/OeEp/AukhOQnX7GzEt9PqP36QyHQv2KGaisKLq37TZssu6P+NWlpDOD2mLm?=
 =?us-ascii?Q?5tXuL2yikoUsvpKo/Uel0n3glQY4bQqyalB4N9jQnArxYJmEEEvAhoITjCnH?=
 =?us-ascii?Q?WSjhlW4kDA0XzbkdxSRx403b5BPq7I9UT8g36FCr3xMKUG2dwTuxydsBTZhh?=
 =?us-ascii?Q?XyJvrhXTfXCb2vzzUo8burqYzNSwAP2H6WF9C6KPzLNY8auUBOazJ5relNmB?=
 =?us-ascii?Q?XvFt3VjG7XBuIHKqQNitUXH0Y/A19R+N05J4PXm70V11kRQdphgZ7GpMSHgE?=
 =?us-ascii?Q?YzeLZDpUfzDximswmoc37u9eV9C95Kb7iHu+TaFzBndUJRIUJEzZKVOTNaw1?=
 =?us-ascii?Q?X8q2FR2t7V/AGAuDDQ0jntEgQsFaqLGlKF9g2/TFULHImhBZvYTZcW4sxNfb?=
 =?us-ascii?Q?R3mHUg46fRgFjY5ZOaXNiIoxG7kGk9XTPvt3/qxnkt5z4tocwZq3PV98HMMn?=
 =?us-ascii?Q?ods/4jY1LKOEa6tEItEEN9q+kD4mYOutVinelx6nzVvUDS9xh1rW6aeuFTba?=
 =?us-ascii?Q?LLHqX4s2OxnzLfpBKghRb2V7IikN0Q0msoXPb1IbNhWFmT22mBlB+Rd+AWQW?=
 =?us-ascii?Q?LmyEg48u1IUy7k6KIUS3pcFTCHrI7A5sqHrMMCacV1d08Z11hn6ghuvGrsAL?=
 =?us-ascii?Q?f9s3EA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69986158-fae0-4271-cde0-08db796dc5a6
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 13:27:37.8546
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xfLEwHtIq3zOhl8ZV91NLNoLLLwqCo3HH4c0y905hv/OddlKCmFTM0BffNjsW0ttuv62/pGUEYqmtny3LPU5CigZfBnknwNJZXnWU8Q8u6I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB4527
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 30, 2023 at 11:58:44AM +0530, Hariprasad Kelam wrote:
> with the addition of new MAC blocks like CN10K RPM and CN10KB
> RPM_USX, LMACs are noncontiguous and CGX blocks are also
> noncontiguous. But during RVU driver initialization, the driver
> is assuming they are contiguous and trying to access
> cgx or lmac with their id which is resulting in kernel panic.
> 
> This patch fixes the issue by adding proper checks.
> 
> [   23.219150] pc : cgx_lmac_read+0x38/0x70
> [   23.219154] lr : rvu_program_channels+0x3f0/0x498
> [   23.223852] sp : ffff000100d6fc80
> [   23.227158] x29: ffff000100d6fc80 x28: ffff00010009f880 x27:
> 000000000000005a
> [   23.234288] x26: ffff000102586768 x25: 0000000000002500 x24:
> fffffffffff0f000
> 
> Fixes: 91c6945ea1f9 ("octeontx2-af: cn10k: Add RPM MAC support")
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Goutham <sgoutham@marvell.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>