Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Jun 2023 15:44:35 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     David Howells <dhowells@redhat.com>
Cc:     netdev@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
        Dave Chinner <david@fromorbit.com>,
        Matt Whitlock <kernel@mattwhitlock.name>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>, linux-fsdevel@kvack.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Christoph Hellwig <hch@lst.de>, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH 2/4] splice: Make vmsplice() steal or copy
Message-ID: <ZJ7cQ8Wdiyb0Ax/r@corigine.com>
References: <20230629155433.4170837-1-dhowells@redhat.com>
 <20230629155433.4170837-3-dhowells@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230629155433.4170837-3-dhowells@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yB1nDa6TZUSPqz1oO9nhTLUQWpcxjubFKuJEHxi3CPFfuxdH0VM2RthzdRob?=
 =?us-ascii?Q?r2daUWJCmuwZxjQAB3/S+zN9Kq/yEQU7fNOJPT1Ba5AfQV+TbTkoXvFEOY1q?=
 =?us-ascii?Q?Uo54OGSLJFjr1sqNfWQxR6SufE23TYwHqshHCZ4j0844S8qaq28rzqvT0XZs?=
 =?us-ascii?Q?DfYpWsLkBhlXCUTfHu6xa+p1rbnbb/2C6Tgo1zeMrdVqeLVuolkWaNv4znXa?=
 =?us-ascii?Q?qsySnUpAKuW5EQpJuPgVXVIsblZvysoWUe0CzEb0Y5fXsOJW1iJBYCdQ37bf?=
 =?us-ascii?Q?8Km6TGmIqEmwg1nzVUnSZg78GI+sofV5pfMoK2FCWRF6q/c4C5i4ntqgAZaH?=
 =?us-ascii?Q?+IuO/KUiivGfFA8Zte0ZyPo9tInLibZ9SAgNzejGUEABZrMHl8qwk+YdxIz2?=
 =?us-ascii?Q?YDVkjZtzpvizXCrkHk8hTfYMngW5dJf9Qf6TP7pS1rV7xQNFxSjUXFUmxTJA?=
 =?us-ascii?Q?Vj8n6Dsh5kbtuU2oKLV6Lf8L6y1r64A1UvUHccvCzcc7Il/dxroZrJW0fqO1?=
 =?us-ascii?Q?9JkhxZQaEhL7goEC2f5TTMl5+q8kkHLe7Ho9E0zYjNpm3LvpNjkyHOppkNue?=
 =?us-ascii?Q?xnR6CJ7a9JKvlst3ow4A9PSGWF2Bfc96zZGqwJU7SSMpVwRmOS/pmGbJNDv4?=
 =?us-ascii?Q?E5B2/DND7hEDJ7hpVhBfbaRS3CsuZNAaUauMxfvDxOBGUbN6BLWwmc9TEjvn?=
 =?us-ascii?Q?LwfK2iNc11p8QFmFsL4m0dVuhNhz/IKMVnXhfozHa+cDP0jm2fJ0ZiSktufO?=
 =?us-ascii?Q?L8y2JAaiGRZUfFncdcL8OGwjKS6L3jg9dFl2J1RYFhbbXa3VIeyPCxfwQpyG?=
 =?us-ascii?Q?CsvF3/gYkMO73bDNWJvY2j4a7AxOrcoPRIDh86JYHxu54Svob5yGhf1aSm/2?=
 =?us-ascii?Q?2KyxK7tJh/EGRPVyYrpgZ5QzxyCjaDhUjlZD6AiwzxJFzNKmjp2PzUAT/yH+?=
 =?us-ascii?Q?Wmw75xD03zbP29SBy7Ft00agu2dDCAQwVf/nRAmsM/lN0emxkAnd3syxTa7K?=
 =?us-ascii?Q?vM8GivHcY05F0FrEi929gt+hXNHGjcFm1S71LVhZNFKI5wn+uliDsXg3Rxps?=
 =?us-ascii?Q?WG7dWAyHDe3pgK0kRvDAaUJx/2uKQeQtfzI9b1fdVybtEvftzors890KhN4d?=
 =?us-ascii?Q?/+ZNZzjOON4zE0cDUvirXJs8W8h+g0qH1piZXsTGYzQHK/bAHFE3D6jeD8wk?=
 =?us-ascii?Q?nlyE9aI7Ut0AjtNIIB+rgApifPD/ozNPY9hHsl8HGfD3dxNBGJMG101YZCIe?=
 =?us-ascii?Q?0zrEZaEwQyNmDLgiskJ8Yb7OGy4rL2iC0G9A989IsjlzKfOFldkzJ1xKdRXs?=
 =?us-ascii?Q?Ja2qH5SCZPiPQkM4oA4IxusfsAkb4EV47zP8pChb+x0h1jZwX1VneWLkL4yo?=
 =?us-ascii?Q?uM83ubPniCEhfeWzpne//IX0dOqs4N7hsEwX2x0aKZY0wSP5AoYl5hmkAqpW?=
 =?us-ascii?Q?8vTyfBUYZ6NoiIVGK6GUWZQFgfEHYZAdfnVOAurp3a1Oh++JOEhcztzQDHKT?=
 =?us-ascii?Q?TIFYvZYIRm2VP0Uj2aTx7B/N9NNgiikWYWd5FLaH1M15R+wuzSaZ4DdywMiC?=
 =?us-ascii?Q?a8CuKr75rP/VvtOYIq1hv+J+7jkP2225jw2z7NRT2dzQ1IO0NrFdDGD4V9cj?=
 =?us-ascii?Q?AxbeD5HE8KR2apdmlIz4PiW6xb98BYdhTZlihULuCiG805HBE8ntEjOPEGuS?=
 =?us-ascii?Q?uUqCjw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fa56558-d481-4b48-02ab-08db7970281e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 13:44:42.1473
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ue+Nby+rVc2c45BHGOs48EegBC6amvgSgBU9WFoyLO+D2zfiSXxjWmDVLy7ntAwKYqsGIKfldPNptnl+NWYGcFgOPnWct+Y4yvfs1pnxL7Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB4928
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 29, 2023 at 04:54:31PM +0100, David Howells wrote:

...

>  static int iter_to_pipe(struct iov_iter *from,
>  			struct pipe_inode_info *pipe,
>  			unsigned flags)
>  {
> -	struct pipe_buffer buf = {
> -		.ops = &user_page_pipe_buf_ops,

Hi David,

perhaps this patchset will change somewhat based on discussion
elsewhere in this thread.

But, on a more mundane level, GCC reports that user_page_pipe_buf_ops is
(now) unused.  I guess this was the last user, and user_page_pipe_buf_ops
can be removed as part of this patch.

...