Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Jun 2023 15:29:25 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: dsa: tag_sja1105: fix MAC DA patching from
 meta frames
Message-ID: <ZJ7YtXGLZDuV+az1@corigine.com>
References: <20230629141453.1112919-1-vladimir.oltean@nxp.com>
 <20230629141453.1112919-2-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230629141453.1112919-2-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?X3SH0cBneBYAwcxsuaCuPtHVLfc4OLQiuCWsr/ygGe3LCrah5OKDgpX4Edy6?=
 =?us-ascii?Q?RcDscR4Itm2+B4iS4FdDLZySzHW3iY70Xmm1RRvvIFEXDEjLIm8hQuDrg6BX?=
 =?us-ascii?Q?NsyVYanYYcuLBw2R+Arx3upUMrKtIFmshgOn/7yNs/6lHCQF+/sF2ofF5wWK?=
 =?us-ascii?Q?e39plKcmAs7izN/rlHGkv9OrR3eojLWwnRMiGhQaiCy0NU7jA1O3uWB3jn5A?=
 =?us-ascii?Q?xLQVWRem4gUZq3e3B81K8+rW1EtiZIEzb22jYglK00yN7Mg/YEnjhpCmOnTA?=
 =?us-ascii?Q?qyN6Luxvho3zM+zl22GDakC9XxzD19l/l49PfDd6gQ/Xw1hyt1Uc9tHL/nMt?=
 =?us-ascii?Q?vc/5i3knmII8lHP7dCd0509YD79Dz6DLPNBsSL86VzUaVFpHOy6xXrUwd1cY?=
 =?us-ascii?Q?kzU6WdNsD8rVKCvs6GozzGmxk5H//PWL3eFFSyioSaxumlGgpjo5ITduzR9P?=
 =?us-ascii?Q?BzrxfAl/28RXIOr1bMbpUYVh4iX1ZI8ABAd9nEpzE0VvjQ+Y7SZN7f+EoYpq?=
 =?us-ascii?Q?a7bUdr5JhTaD6zW9mAw1ZOJg46misNOUeE/DuDInCPn1OH9D/28Z2bowAa9R?=
 =?us-ascii?Q?ZLqXBI+kusM4EFs5KOpsTnhnwqeD4ENQSbcWYxa+/seAynrBh2dJjIY3k3C3?=
 =?us-ascii?Q?Q0e5yV3QhhfyC5YTMRig12yyPZ0Lwz0mi6JR1u3dQ3oiedRyxnLf1BewQup9?=
 =?us-ascii?Q?+J4sXdE93wMvztheyWH4GY/pcf/r0ETjK30K+NwDG72G1Dz9yTqJ96lNgV4t?=
 =?us-ascii?Q?y16azea9It2Gea6z4teaN9YQMjAzXV+vMNfDNHcLRQ92E0n49GdyLDl42DJo?=
 =?us-ascii?Q?z7Q/ImKuV+zbM74Hs5TL8x1L7mWbwujetTO3/r2PiGFM3e69P8tnQsNIrrjo?=
 =?us-ascii?Q?82FxTKrg5QB208/PT/Ort9Vooa9zFqQO4p4NwfvpjeYrKODiDNihU4MmX5/i?=
 =?us-ascii?Q?9K0+AVajS/qAJUoFMVFjD43wCDZYRvQXm9XCMegusPVv/0XIdX607wBlpjRG?=
 =?us-ascii?Q?YP/yCTQW3p008P8UfN4/2M2B8DVMIFRBKzFmfRcROlweeCmm/BHMi7UObQYY?=
 =?us-ascii?Q?68p2ZYDfVLDRcrV3HQOa9FD1wx+KySEBNOJo3OBk0g6dhzlTnqwrBAvWW8qH?=
 =?us-ascii?Q?H2Pkp/88xTwtASZiUEgpO4SiKwD+5Tt1hpSv02faz4iJYR+l1WBzX714Gqpw?=
 =?us-ascii?Q?KsU5emSxjW72OqId7mQxJ+HTeGDQ9B15xkPrbVEAsMRGqnPnkHQHyk0dJc0r?=
 =?us-ascii?Q?PCDxnhof7wGoOVmW6QKs18dplf0vwckzwwSDIKMjYPX+Hcb8SCrSKJs7w1sj?=
 =?us-ascii?Q?+OATD8E79QpYwl92QwPq3aiySjIcAVUhAIO/KYwwMnHV0rKev2uT3h+VGUrq?=
 =?us-ascii?Q?asKoo2tZ6aNNQl8fyi0QsZnGpTsztCbo9hvY38sb95gC3hvHaRCn6KVMY7xY?=
 =?us-ascii?Q?aPs+kazzozRNLecWHVstWYsOHu7vvYV+7uMSBnl86ScKEnAD0xJ5EwSj2O6c?=
 =?us-ascii?Q?2x8dE8jj3L/VijjTZwpX8TBiD5cIPB5tP1QUoAVFNn7sieXmFOYWdrdKXF8Y?=
 =?us-ascii?Q?2sumNw9nbfvigjypj+JhiEV3q/alFihn9YYWm29QcaQv6jZr7HsnE5lWVbx1?=
 =?us-ascii?Q?iVfqp4LovSwR66gFp4S6grchx3q6QjZs0PRGI0/9QYfEfq5puDsfG5J7CItA?=
 =?us-ascii?Q?IM7Wcg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1743f72-3ace-4b9d-d40b-08db796e097e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 13:29:31.7240
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MrKtuHIw6ecb7x37DPoaOdzzctuEeDFhWIPmUNSVeI/15U8E8E7eXPePwPzFJxZyzfmfPga7bMGnvprUi5egb/61vxI9lsSjENNKkOlUYSs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3768
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 29, 2023 at 05:14:52PM +0300, Vladimir Oltean wrote:
> The SJA1105 manual says that at offset 4 into the meta frame payload we
> have "MAC destination byte 2" and at offset 5 we have "MAC destination
> byte 1". These are counted from the LSB, so byte 1 is h_dest[ETH_HLEN-2]
> aka h_dest[4] and byte 2 is h_dest[ETH_HLEN-3] aka h_dest[3].
> 
> The sja1105_meta_unpack() function decodes these the other way around,
> so a frame with MAC DA 01:80:c2:11:22:33 is received by the network
> stack as having 01:80:c2:22:11:33.
> 
> Fixes: e53e18a6fe4d ("net: dsa: sja1105: Receive and decode meta frames")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>