Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp22453731rwd; Fri, 30 Jun 2023 08:11:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlFkmwfOXiTBPi9M443J7yOZzeqxWno/sCzquGihPnLwUCdeVEwvjW49dInA/W/7/lsKQTjC X-Received: by 2002:a17:90a:d085:b0:259:b065:da4f with SMTP id k5-20020a17090ad08500b00259b065da4fmr2605129pju.36.1688137919232; Fri, 30 Jun 2023 08:11:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688137919; cv=none; d=google.com; s=arc-20160816; b=EnIsPGNFz89OpNWcqEvBsEdjite0i5Mha7Hu/DMbGLc5wgT+dQsn2a9TmHgECdQ3ON Zl9u0DPtimbmFYIomZAcbqoMdRmWUVszOfx7898OBx/vDn8KNwpm1w1yCnsSIuKhVOqs dV5bVNnKy+O+fbeiykuStOD1+Oi9udNEO7PII9H/sVvGtdSSIF5aveVb5TAJ7HNCFTgY vqs8tZOaVMmFFXWO099MyoRSnX0jOVFO9VzGAqJnnqDrUvH3UwsUHnvZmDu/9z1CxwtI nzs2MGHW5y4xkJDsRXxQ2mXXpDAPo19aFoY2hV4aBEATR75tQs5zRNkxZ3ZMSYTvIRjb sf4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=O+7N+RpWhjjER73lgAnJg3/KuwNUZLf32hCpl/lcCjg=; fh=YVPmoIIa7mX6MDU4FhdLZh+M+2mpKthEbh1CBO8KejA=; b=kRnBS5v4ZO8Dr2/YoeHgqiBiZIgjNdZV06QEUkN6S1HOO1pLiHn6uJUpDPnh9eH8vS RED4r72enAZD9Q8Vwo4jo1EwoMQnURJqaAQT3WOlu9rPC5tKbARJk+3zOEtNBpE9WzvP KrTpHlQHtzhgTrgFiZDVVSgX8GdGjUIV9afWYE6WPfFhbVlKnDNUyjt1/5B+cQzsvjKM z1rgrkJSvqXxuAn2E7xkSOwNo3xeuXyMWsGFNnxLkcyH5IvfXpPqwUVsZC4Ot+N9Wo2p q4yafF6kSWJgmt+FGFmUDWBI3r/GfrMqXgqNa8h0jzqNSPEe1GASWP5kml+JfkX3E+2F 1Teg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=CsYVivMP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d11-20020a17090a628b00b0026308f709e6si7928057pjj.113.2023.06.30.08.11.44; Fri, 30 Jun 2023 08:11:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=CsYVivMP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232834AbjF3O7M (ORCPT + 99 others); Fri, 30 Jun 2023 10:59:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232823AbjF3O7J (ORCPT ); Fri, 30 Jun 2023 10:59:09 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C427F35AF; Fri, 30 Jun 2023 07:59:07 -0700 (PDT) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35UB5F8N004978; Fri, 30 Jun 2023 14:58:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=O+7N+RpWhjjER73lgAnJg3/KuwNUZLf32hCpl/lcCjg=; b=CsYVivMP5Nj7p2YiMGPoPcpkczwwmtjqXGhlvznK+KxysAZYAX5ghlNf//DJKf/RZlRp iyluJhYakWVZuVKnaOyz2SZvIe3vycn8qsX2zaubzeO+TiH5IeLgUGueEa5K7niuZEnc woSN5ejP7VOyrMBNCz38bTkmy6zdecZqyZ1rvlVOhh3abJXSEOEz2XfdyyYnAZPuTD3g udxyTIuMWecivD6gPEsyBoMIUBNBWPDH7H5NtEWc+Ms9et5ibstDFivVezFJ/tSLElHr UaEK175lmIwJc8d79jM9ogKclzSfib6IMMdNeNrAfON3U4NCNNvcUwKKbIuRWS9KOFZY Bw== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rhfewa7qs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 14:58:47 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 35UEwlbS007764 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 14:58:47 GMT Received: from [10.216.37.216] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Fri, 30 Jun 2023 07:58:37 -0700 Message-ID: <69f8c351-9654-2b4b-b95c-cd1b26b28057@quicinc.com> Date: Fri, 30 Jun 2023 20:28:33 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 18/21] pinctrl: qcom: Use qcom_scm_io_update_field() Content-Language: en-US To: Andy Shevchenko CC: , , , , , , , , , , , , , , , , , , , , , References: <1687955688-20809-1-git-send-email-quic_mojha@quicinc.com> <1687955688-20809-19-git-send-email-quic_mojha@quicinc.com> From: Mukesh Ojha In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: NDy_K3d84hReuGKT4_iTMuOBUX4jA1ys X-Proofpoint-GUID: NDy_K3d84hReuGKT4_iTMuOBUX4jA1ys X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-30_05,2023-06-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 spamscore=0 mlxlogscore=877 adultscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306300126 X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for your time and suggestion. On 6/28/2023 7:14 PM, Andy Shevchenko wrote: > On Wed, Jun 28, 2023 at 3:37 PM Mukesh Ojha wrote: >> >> Use qcom_scm_io_update_field() exported function introduced >> in last commit. > > the last > > But what is that? Be more specific. > > ... > >> + mask = (GENMASK(2, 0) << g->intr_target_bit); > > Outer parentheses are not needed. Will apply the changes. -Mukesh >