Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4cda8a4a-e9f6-9d8b-2246-0b3f2ef7900c@oracle.com>
Date:   Fri, 30 Jun 2023 11:56:09 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 1/2] mm: remove page_rmapping()
To:     Peng Zhang <zhangpeng362@huawei.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Cc:     willy@infradead.org, akpm@linux-foundation.org,
        wangkefeng.wang@huawei.com, sunnanyong@huawei.com
References: <20230630121310.165700-1-zhangpeng362@huawei.com>
 <20230630121310.165700-2-zhangpeng362@huawei.com>
Content-Language: en-US
From:   Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <20230630121310.165700-2-zhangpeng362@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bElMazIvY2ltdGYrVXZvZ21UYm5wQUl4bVRnWVNoTmpRMTh6ZzFzYUpCY2ZU?=
 =?utf-8?B?TzZvZ1lrNmszOTlMVDFFWmh2OXVsdkd4WDlUeTEwMDlFMUFuM0dqSnRhZU1n?=
 =?utf-8?B?akhhYW52VTloa2g4SnNJNlNPZHpmWmltY0RpMkNWRXBYTUNlb0ZsOUNLQVRi?=
 =?utf-8?B?K2JiRDZDd0FCQVdmVjUzL2RxL2hKelVNM0VBRHJMTENmblZEck9UcjN3V1J6?=
 =?utf-8?B?dGdxaytKSjZOTVZRSkNPQmxVM2hJdUpubGJ0OTFYUVcvMWhEQTA0MWI1UFE0?=
 =?utf-8?B?WEJYRmNpaEFTcUNHVkNCSWpaTUxrV1BMSEpDbmpHNG93YlpSRU5ST3poNFYz?=
 =?utf-8?B?cjRpWTlUZFdtbTdNMDlESDdsUUpLeWU3UTJiN2Y5SXBGelJDeE9ScGRwa2E3?=
 =?utf-8?B?YU1oM3cva1VPUzZKZDFMR0VuV2R6MDNtZ1c4cnVsUS9jbkh6aWtnbXlGdXQz?=
 =?utf-8?B?dkNtVlFaSFZNbm0yd3M0Yk9zQStFcWV2Uyt0QjdrVnFSL3V4em9FZ2hLZ2t4?=
 =?utf-8?B?WWlqOW1uM0V0b3orbW55WjNhMmVpWHYyVGpicmZrOGMwRlhkN2hDcXFsZUti?=
 =?utf-8?B?b1BEbzRFNVNXRW5DMXk3TlBXY1Z4bHlId3FxMGFyUzlxZGttajUzZDFReWdN?=
 =?utf-8?B?Z2NnNVdrYkk5eHR2YVBjOXhyN2VHakZ4Q1R1bWNsQWdDTWllQkplQ3VRbXZR?=
 =?utf-8?B?RkNxTG9PTVFWWENwbWtGSmM5OUhZSVI4a21YLytzem9SNTBIaUlDN05RQ21i?=
 =?utf-8?B?Y0JicG5maGx0aE1qbkVHVlJjUGV6cEc1cCs1Vi9SdnVoY1VGZU94dDk2a0J6?=
 =?utf-8?B?ajVUSUFlZlpKelpFdWszK1U1bzJ2QXlzS21IWmxwUjFoRUp3L1l2d2JWU0FD?=
 =?utf-8?B?OUNGL1F1alhDNnA0bnY2aVlNbkh6amJZSnBObkdRNWI1ZHFHS1BHaXVLNUll?=
 =?utf-8?B?VUM5dHZOSitJN1dWY2Z0NUh5alVDQW93eEpTZ1hDM2liQU45OGZKRlo1allU?=
 =?utf-8?B?Nzk5QXpBczJuSmFEOU5wYTRCcjllRVVkck16UXZNaXlsWW9qV2VEV1hxL2pQ?=
 =?utf-8?B?bUN2R0x6U045Z0NlU2RoRTQ5SkNpRmxzNDRoQ2lxTDJhTWZ3UTRnckdrbEVm?=
 =?utf-8?B?TUhFUnFPSjZwOVBIZDlSVWduSkVmV2c0bGtaa3hUbTlZcU1hcm5JYlpFK2xC?=
 =?utf-8?B?TkVGS2RVbW1XUG5jN00xanI4TEJkQXFZL244L0NMSFZmS211MXV6ZkZ1bjdB?=
 =?utf-8?B?aHVxbUR6UE0rZndZay9aeDdwcHhnK2xpdDlFaHlwMEV0a2xuLzBqRlNWRkVL?=
 =?utf-8?B?Z2VsYlBZNDZmbnRxMHBEa3NpaVVyMlpuMXRCNWs4ZHhSZnFOeUJLUUVObEk1?=
 =?utf-8?B?UnlDS2hMVE1yUGsrcjRLY0RXOUdDTnd5QmdockFGSytMTGRZN095SDVtcHk5?=
 =?utf-8?B?b1FoaHU3K1hVQ2hIRjUzS0VOUk5RMDJBOThRNFkwZkxubnp5bWZYSEp0VFUy?=
 =?utf-8?B?ZHlYVW80R01wc25JQzZ6TysvVDVmWnJaU0Y5WXdrMUFHZzVvMEU1MmhleFRn?=
 =?utf-8?B?UlA2Qm9Pem94R1pFOXBqdURBYzVKZFcydlo3YThZOVFBbWNwOEljL3V3RS9G?=
 =?utf-8?B?RnlQUjdjY3c5NVF2d2FzS2drb21CQUp3dHRnKzVRbW1pcjNlclNMTWtlYUxo?=
 =?utf-8?B?ZWY4M1ZwNEVWNXErb3UyWmJyS3ZIK1J3VzhyL3pCYnJsZEcwM2c4VkdVc29m?=
 =?utf-8?B?ZjQ5NWlHMVZUd1ltanpPU0UxbFBhWThvQVlBSmJlMmJ5WEQxTHhsenQ1RWJO?=
 =?utf-8?B?NmxyNEY0TGNFTTJ1dzlDdzdDc3JVSGErbUw2dXFXckhOeTlRbWZWOWNRSDN2?=
 =?utf-8?B?bzh6UktES2V3UmJyN2wxWFphZ2hMeWJJTWtQcUFkZHVXZWdxZkdLenluWlN1?=
 =?utf-8?B?M2JHdkpuYk1laUZ4Q0x5SVJlVjdlVWUyaTR3TFk1NkhDY25XUW5sY0hBVDlh?=
 =?utf-8?B?R2Jna2FQd3BSWWVaOCt3WXVuaGJDNDBCa2dLcHJkQTZLOGxHN2tvb2xoTTFm?=
 =?utf-8?B?YnBxWUpkaXpqaFl5d0Y3dTJ6S2ptbFpBRi9UTkR3RHJjVjhvN3h4eVBZYklo?=
 =?utf-8?B?U0NWVENJYmwrdHBOekVoYXlpUXFHWDgrMTdqNWV2SENOMUVVbTFhbEs2cWtu?=
 =?utf-8?B?MHc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: P0vvWrGqoPwBfDOY0xTSIblAw3pgVm7yZStUkUbWoHqdpT6YD6TnHESnybpcANbecq+ndTIsAyBYLA5aEZLBrglh6DGQE0YS/zzXAvyIjd7gjCC4H45qFeoj1rizJ6bJqVla3eA/ZX4TA8L8nDb+64UI4pRzQEXutFsAUec2EPiJBDMRj5al68q0/hOblyGjwK3LWVgC6NVFhCSLyn3M137L2JAymngCTAllcCXnkbYjIHVNQO9Y9gjphI5YwTLXHwWgRuh+Fcn811eYnwdiZVfX7M91nAcc6BEOqAhfCVZ4LKEdpG6qA5Ca1HQ6rMFSSFRl9UZgujVWn9iHQ8JWltyrpqECIw4bhHZ+T6T7FsS55J/kaBrfTgT3jknYw3s9Pb9PBQ6/JPgkqdhvfmVZkbd1L4AQnUVkuRzzCFxBOPZVqMnTxxt5FbuAD1aJZbLvBP289miWSiFht4Bg2+za4NSN1sR6lald1+fHSZPMw3pAGXO3dbQ+hcz0I5ehSafBswgWI4zKJEYWLbbFZ2inf5QADlPCloIy60TZTvoKGG9+RZfttFZWWuXP8rU3VhC081R9sT+42O1BDw7nbd8KEV2vO9nN1Y9pOd3cTjiaf+dtxshOKaZ46ROIWPk0LowAV1YpMKtjZPyP/EqHzT1Hv58a42UXw+2Yo27L1FOtTuY/S7S3KDGk1LQhLK2jI+ikUox5o3d6t02Aj3UyIaeP2SC4VJg+2vcIPTb/xZYt2yXDl6uF8/E0Gy3i4jka9zbZaLeAVBZEPDFMdGlosQJJxhEbrADL24NyY9yZi4O+h/DrV+wGk8LnEwFW3oalwLeDyv+PjAzNii8HDfsQbQJmcVryYbQQpsxDi3laDNTHkx8L/+JRpWO0lyuNhlpK86QWBo46FFYUaEjpcj0K4zSZyvhyHBGX5RjoLrAjbgfeCjc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a3d3f7c-35af-4ada-20ca-08db79828739
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5113.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 15:56:12.6583
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tXQ03bE4wdf+oUv2ZGQ0+feejiEAIXUL93HhspUb5FH1JtDE8EB94Fr56AvTHRIMQYlKSsDxYkhkP1ZzCqxKWl89BHTQTz7ulCmy2sSeRU0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB7653
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-30_08,2023-06-30_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0
 malwarescore=0 adultscore=0 mlxlogscore=999 phishscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2306300136
X-Proofpoint-GUID: sNNJlNegysbuvrzbVSI-oZ_X-PtRltwL
X-Proofpoint-ORIG-GUID: sNNJlNegysbuvrzbVSI-oZ_X-PtRltwL
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/30/23 5:13 AM, Peng Zhang wrote:
> From: ZhangPeng <zhangpeng362@huawei.com>
> 
> After converting the last user to folio_raw_mapping(), we can safely
> remove the function.
> 
> Signed-off-by: ZhangPeng <zhangpeng362@huawei.com>
> ---
>   include/linux/mm.h | 1 -
>   mm/memory.c        | 2 +-
>   mm/util.c          | 6 ------
>   3 files changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 9ecb8b9c07f6..8c7eba7370b2 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -2129,7 +2129,6 @@ static inline void *folio_address(const struct folio *folio)
>   	return page_address(&folio->page);
>   }
>   
> -extern void *page_rmapping(struct page *page);
>   extern pgoff_t __page_file_index(struct page *page);
>   
>   /*
> diff --git a/mm/memory.c b/mm/memory.c
> index 21fab2727209..6921df44a99f 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -2979,7 +2979,7 @@ static vm_fault_t fault_dirty_shared_page(struct vm_fault *vmf)
>   	 * pinned by vma->vm_file's reference.  We rely on unlock_page()'s
>   	 * release semantics to prevent the compiler from undoing this copying.
>   	 */
> -	mapping = page_rmapping(page);
> +	mapping = folio_raw_mapping(page_folio(page));
>   	unlock_page(page);
>   
>   	if (!page_mkwrite)
> diff --git a/mm/util.c b/mm/util.c
> index dd12b9531ac4..5e9305189c3f 100644
> --- a/mm/util.c
> +++ b/mm/util.c
> @@ -734,12 +734,6 @@ void *vcalloc(size_t n, size_t size)
>   }
>   EXPORT_SYMBOL(vcalloc);
>   
> -/* Neutral page->mapping pointer to address_space or anon_vma or other */
> -void *page_rmapping(struct page *page)
> -{
> -	return folio_raw_mapping(page_folio(page));
> -}
> -
>   struct anon_vma *folio_anon_vma(struct folio *folio)
>   {
>   	unsigned long mapping = (unsigned long)folio->mapping;
Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>