Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Jun 2023 19:53:00 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Simon Horman <simon.horman@corigine.com>
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/2] net: dsa: sja1105: always enable the send_meta
 options
Message-ID: <20230630165300.jmy7duyrqj3gzjmp@skbuf>
References: <20230629141453.1112919-1-vladimir.oltean@nxp.com>
 <20230629141453.1112919-3-vladimir.oltean@nxp.com>
 <ZJ7aG/tzAxutRoeo@corigine.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZJ7aG/tzAxutRoeo@corigine.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WCpbz6hHQ1i4JXLALIyOF9szcQf3yXe60pyyPUwT1EOf2rRGV9R9ymTeABGr?=
 =?us-ascii?Q?90wgcCRLSHkXHG2psnb+GqOJk+Iw8DZJgrU6YHhkNbAbodzIdKxa1IN8H9Oy?=
 =?us-ascii?Q?os0Q+lnNvdOWqRRMhUc/ld8jj7qn7LJj03fmNw0o/1bjNoKZc6M/1vZqoQJT?=
 =?us-ascii?Q?3FxrQiFPm5B3QBAAvXyiLB+hRCL56fdCtjylYXChCiCZPlycFiVml+nkz4cz?=
 =?us-ascii?Q?2eCk0jZxtM1T5ROe62s1jTU7s/j30YPj9z7gT/Fhs5DAmMNsYw5o7/C4WRm0?=
 =?us-ascii?Q?H2mU59HA0E6QNn+rVgT9834Aw65YYnezCusaSZPSJa7Bu1/f5yVZLlRfl7vo?=
 =?us-ascii?Q?UEIuKkpIpHEUnF5MVaGJmKoInLvz3+5gElPUPGktWxovGGGkdXGXN6ECeigz?=
 =?us-ascii?Q?oueRSKc3B4BcM2wzJDtgSYXGN9NfzRx94HxR5sPipVp2rQusLWyOYIKjyThv?=
 =?us-ascii?Q?5L1+8YTu+NsVLrDmsKzjcq6/6oFLMYiPQfWfZC1zBi6YcbfiMUPsZlEeV8Vf?=
 =?us-ascii?Q?1fPisCH/WG4TU++gKr//qTz3DN0mdjEckwcLmWNMWF2E5SyQOLyIYuDAIHoK?=
 =?us-ascii?Q?YYlqWq95xQQ2GPSYMdt7rr6MvNDpJruqL9BjRqlktNgKP+sWdZ0OgZ7VfeQl?=
 =?us-ascii?Q?OuybjCns3u577Edq2z2Oq7XXnRuw86WWgm3bMEK3osez88zvSZMB5p6lauYU?=
 =?us-ascii?Q?/Z8wd00xE/RgEF9SaBsJXjkl1+4ts/NYdhV1NW5Dktcu/1VMy4LnMYitQCwR?=
 =?us-ascii?Q?4R7Kt3lLQ5VLAcG+elrOPA7fbJIpSIXj/dY5ZRIBW1tuUCJo4trv3PR++akQ?=
 =?us-ascii?Q?7rRVl25LgdWdY/bbUypfZrtVgmr2/KDZsLPfqHUTPmycbyYADyMmXgb/ULDS?=
 =?us-ascii?Q?rkGKsJhq6UrN9YWe6QN2j3sYMgaWrQ6lzouDjtzQd3e9QPv8O4NUu6+4bVRG?=
 =?us-ascii?Q?TqHWGAZy/Si6ptiCIB/qU3rcJh9JO3RRxioHiQtXn3LC/0PyjjRVnXjYHIYb?=
 =?us-ascii?Q?fd7oxajzo0osmXOFFIRYCcQZtqdYfzbIxZeEVGV7SICNfoVWwdiqjVg0u5dg?=
 =?us-ascii?Q?pRSy3QaN+oDDbv5d1WJkCwRhXFv4ZpXaH1MFLfJSuf5IeRN9vCnUnUIjHtUV?=
 =?us-ascii?Q?gOhylBJCUFq4fursVvvqhxPcRmWfun/gG2LNeNDm4W5TUfx00Ab95LAmH5gF?=
 =?us-ascii?Q?+XKSQnSh4aSKfg2GBzqKRjjLuR4umN7tbfb+6wkwmjzNtTGzH2YIW+4Pqzrk?=
 =?us-ascii?Q?vSCOhX4gMc4rWR6PLOEO3k/wZPYyYT8PE1hGzOusGjjVnWUJTuOFFuo+DQIC?=
 =?us-ascii?Q?EFhZxvwsKFarKQ6Zq90WCmqDGc5QnqEOqYdefvqLLI2si7hhYYDJ8fiVWvaz?=
 =?us-ascii?Q?lUYhbKIP8H+SzfcxsIUZNtamycgbyIW+oemA7swAO2dBVxyQOYxeJayQqZNI?=
 =?us-ascii?Q?il3bsz0JYBoR3RoD3qhWTa2GS9nwEPR2jvAkvB8V+y13GznRrgsQldKY5jai?=
 =?us-ascii?Q?2qQZkTFMMsq5LjEJREg9bboEVaMp04xQKT3FDuwetrZQWzjplV+vKh8v5Hgp?=
 =?us-ascii?Q?h1txwc1CiKqwyMxs8HUGeeJF4+SRRdwLfh/Z3t+Eb9JQdtHOmQ3F3E5B67JG?=
 =?us-ascii?Q?dg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aeffe937-5f57-4524-12db-08db798a78a4
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 16:53:04.1027
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IGDCOcy4Mw/+SoMz7iUmM2u9HqyY4SQ/dlwvDbHbB/kapUIedt8tYt/fs65349nyyzwVPUDRuXAKgLl9AcfHrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7618
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Simon,

On Fri, Jun 30, 2023 at 03:35:23PM +0200, Simon Horman wrote:
> Hi Vladimir,
> 
> this patch isn't that big, so I'm ok with it.  But it also isn't that
> small, so I'd just like to mention that a different approach might be a
> small patch that enables meta frame generation unconditionally, as a fix.
> And then, later, some cleanup, which seems to comprise most of this patch.
> 
> I do admit that I didn't try this. So it might not be sensible.  And as I
> said, I am ok with this patch. But I did think it was worth mentioning.
> 
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> 
> ...

Thanks for the feedback.

You're saying that it's preferable to leave sja1105_rxtstamp_set_state()
and sja1105_rxtstamp_get_state() where they are, accessible through
tagger_data->rxtstamp_set_state() and tagger_data->rxtstamp_get_state(),
but to only call tagger_data->rxtstamp_set_state() once, statically with
"true", and to never call tagger_data->rxtstamp_get_state()?

I probably could, but I'd have to delay the tagger_data->rxtstamp_set_state()
call until sja1105_connect_tag_protocol(); it's not going to be available
earlier. And this is going to be just filler code that I will then delete
as soon as net-next reopens.