Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <81dbbc8f-fc05-754d-56bf-5e74169b8dc8@intel.com>
Date:   Fri, 30 Jun 2023 18:56:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v5 09/10] acpi/nfit: Move handler installing logic to
 driver
Content-Language: en-US
To:     Dan Williams <dan.j.williams@intel.com>,
        <linux-acpi@vger.kernel.org>
CC:     <rafael@kernel.org>, <vishal.l.verma@intel.com>, <lenb@kernel.org>,
        <dave.jiang@intel.com>, <ira.weiny@intel.com>,
        <rui.zhang@intel.com>, <linux-kernel@vger.kernel.org>,
        <nvdimm@lists.linux.dev>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
References: <20230616165034.3630141-1-michal.wilczynski@intel.com>
 <20230616165034.3630141-10-michal.wilczynski@intel.com>
 <649def832ce1f_11e68529491@dwillia2-xfh.jf.intel.com.notmuch>
From:   "Wilczynski, Michal" <michal.wilczynski@intel.com>
In-Reply-To: <649def832ce1f_11e68529491@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDdWajN3WUxMWEVFWDQyb085Y2JVUzcxdHZSKzRuQVJidVJvRkdoZGIvM2xr?=
 =?utf-8?B?c3FhZzlKTktnMzljNW5GTm5wdk5XUWZhMEJHeXgyWUltbHU4Y3VjVnB0WHh1?=
 =?utf-8?B?THA5c001TWRnbXBjNTNQT2lxSS9lVlpadGVzSTNWelFSMWFLY01VNFJMY2pO?=
 =?utf-8?B?TmdNSGpGbFBjbE42ZEp3K0U2Z0FEUXRhUGI3em5yd0hNU1haYmhlbmdnMlYr?=
 =?utf-8?B?aUgxV3RldTZoanVURmgzR3JBY0grTFdneEdrNGxiT2RLTFp2UGpWMnBYOWRU?=
 =?utf-8?B?WWRBbk5UdjEzUVMzcHFqQkdIM2xrV2NzamNlUUhMc3R2WitsdDBuY3R1ellJ?=
 =?utf-8?B?elFscFhBNEpYNHNXWUY1cWg3VXQrNXBqNjVTZXZGM3BpbDQzdDBOVFBhZEJO?=
 =?utf-8?B?aFFDZklVcEVOa3RwenVmbUpzSS9wcUcvR3E0M1U2S3E4Mktqb3QwL0tRTmZh?=
 =?utf-8?B?UW5Ra2JhUlhLeEk5RCtDd3pyNzFySXFheVlkcTdyT3I1TmV2TUI4aVgrR0My?=
 =?utf-8?B?QTUrRWswUSsrQ1pIWDBHN2djMzgrMjR5YlBXc0NDZWJjWmlWRUZSSUJlRXJL?=
 =?utf-8?B?MW0yMHFxbkJzZXFjeHlsSFRxSEVpYVpOdGNGaGZySFRyOEMwa0YvYVcyS1Qw?=
 =?utf-8?B?VFZaMVRSaytVd2Y3aDRJbWhTcklkZDFVSWdYRisvN3ZtcU1od0k2L2U3SnhU?=
 =?utf-8?B?U05UMjVVVmJUbFNIc0lQUWxkdUg5RUplU25ZT1owa2M3OS9xWkJxWnJLdEwv?=
 =?utf-8?B?VkhDYmIvTzFjUUN6TnJUc2FWTHF1d2tGTFJJUlVHQklMc254UWhhYlZWZktW?=
 =?utf-8?B?aXFPb1BNdkJTNjgxZUJqU2MrT2VEa1prR0dFTlZBT3dKTlZWUmZYRkhBeU5Z?=
 =?utf-8?B?dGZnWFJXYW53WU9FTWZ3ZEZXOFNRV1ZUL21pRDNhS0V4cUFQUitxWjk0TVFD?=
 =?utf-8?B?c3V5SFhnZmFNMmt2bWpBaTBkMTJpNTczK2tvR3FzM01weUdveGJUUGRQN1RS?=
 =?utf-8?B?djN0Z1hXc1ptRFZDUCthY3BLY0NTV3A4T0FZZVo2NGlZOUk2WmljRkhFREpo?=
 =?utf-8?B?bjljdXVUOXEwQnE1RmJXeVlhbnc3QXFPUFdTelJQQnJNQ0NmN3ZkbFBLdE1K?=
 =?utf-8?B?TXM2V3pQLy9ZRXR3Uk94aTR5bnJ0RHc1dWFGd2RsYU93aFVkRzF5SGpmOE8w?=
 =?utf-8?B?bmtEZ20ya21sZ2I3VlBDeWR0a3Y1aWZOVklGaDM4akVUd3liYTgvb0QyL0ZB?=
 =?utf-8?B?S1dZWWdGelhadXNVa1FWWnM3OFIwZWcySGxSY09ramFSOHR5TzNJRXJ3amlF?=
 =?utf-8?B?a1BCWU9yTUVoTURqRHdHT3N6TjhIeUNQaS9TMVV0a3duTWZ5aEpyVnZ1bzB2?=
 =?utf-8?B?dzI3aUdhc0JSYzZwMXFiM2QxdEh6U205K0xhMVNPRXJiTEgzZDFEYVoxQ3lv?=
 =?utf-8?B?OE1RTGFlVFVJOTR6VUNtU21pZEZLckh2M25iUXVyT2xYWHQ3MERBTzdSaDdv?=
 =?utf-8?B?TDZoRWp3RFloK25Ra1JEc1luaitCSzVJby9aVzhSOGgwcDlQdzBrUkdXazN4?=
 =?utf-8?B?SGVJWHFLZVNFb1ZWcklDL081aEVSY3hhVlovR2ZDV25qVW5GTUlOVlo5K21J?=
 =?utf-8?B?NXRybGd1VWVYaTVGcHQ5eUhseW1qVzlRakpldUVlUWxzOGw1cU1nTmNmZTF6?=
 =?utf-8?B?ejVUcGkwSVFDZzJkKzM1empDbWZVdzdSWDNSUGZCQ25XS1lqeW1nTUVjQ1ln?=
 =?utf-8?B?SWhvNUJlMU9qVndYRnJ1YVpZSERuVU9hd3d1TG1UZVh5c2R4Y1BvenhWZ3JL?=
 =?utf-8?B?eDBjT0NBVEZOR0Z0cHhoaHI0ZWU2VHdNNm1TSUVlUTRnSmJQZmVqZWtXVnZH?=
 =?utf-8?B?YlhHOHU1RkRCZDV2N1FGdWIxekF6cHNTY1poOVhGM2hZU0JwUTEvZ3ZjWVpM?=
 =?utf-8?B?aTgzTHNMT3pjZlJZVzVxZGc4dnhZaExTTmwydm13djVWa3oyUlk2MHZxNVdH?=
 =?utf-8?B?MzJHWjZTZlo4UzU1cHMvZHJFZTVkQlB2RHZqK1RpWW1oR3I1L2U3eW1ISGMz?=
 =?utf-8?B?R3JYRnpaMGVhclR3U1QzemNZcXNkQkdwU3BMaUpYZ0w5K2drWXpHQWxtbmZ1?=
 =?utf-8?B?Z3ZmL1dOb0V0ODZySzVwN3FYWm4rbE9RZldvZEpMUnI1TTFsWFEyTWwxVkxF?=
 =?utf-8?B?cGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 598b07e6-7d51-4e9e-1b10-08db798aff95
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 16:56:50.5786
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fPA/hUqQFt+UHCNnKzBt0RK+D49ElEgpW07HXysQHFdR4CKIk75NTtMuK4QbJXPr92XfR+7vr9zToqfm1HFRzcFZir8BEzHYW2rXpyQmPHY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8316
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/29/2023 10:54 PM, Dan Williams wrote:
> Michal Wilczynski wrote:
>> Currently logic for installing notifications from ACPI devices is
>> implemented using notify callback in struct acpi_driver. Preparations
>> are being made to replace acpi_driver with more generic struct
>> platform_driver, which doesn't contain notify callback. Furthermore
>> as of now handlers are being called indirectly through
>> acpi_notify_device(), which decreases performance.
>>
>> Call acpi_dev_install_notify_handler() at the end of .add() callback.
>> Call acpi_dev_remove_notify_handler() at the beginning of .remove()
>> callback. Change arguments passed to the notify function to match with
>> what's required by acpi_install_notify_handler(). Remove .notify
>> callback initialization in acpi_driver.
>>
>> Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
>> ---
>>  drivers/acpi/nfit/core.c | 24 ++++++++++++++++++------
>>  1 file changed, 18 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
>> index 95930e9d776c..a281bdfee8a0 100644
>> --- a/drivers/acpi/nfit/core.c
>> +++ b/drivers/acpi/nfit/core.c
>> @@ -3312,11 +3312,13 @@ void acpi_nfit_shutdown(void *data)
>>  }
>>  EXPORT_SYMBOL_GPL(acpi_nfit_shutdown);
>>  
>> -static void acpi_nfit_notify(struct acpi_device *adev, u32 event)
>> +static void acpi_nfit_notify(acpi_handle handle, u32 event, void *data)
>>  {
>> -	device_lock(&adev->dev);
>> -	__acpi_nfit_notify(&adev->dev, adev->handle, event);
>> -	device_unlock(&adev->dev);
>> +	struct acpi_device *device = data;
>> +
>> +	device_lock(&device->dev);
>> +	__acpi_nfit_notify(&device->dev, handle, event);
>> +	device_unlock(&device->dev);
>>  }
>>  
>>  static int acpi_nfit_add(struct acpi_device *adev)
>> @@ -3375,12 +3377,23 @@ static int acpi_nfit_add(struct acpi_device *adev)
>>  
>>  	if (rc)
>>  		return rc;
>> -	return devm_add_action_or_reset(dev, acpi_nfit_shutdown, acpi_desc);
>> +
>> +	rc = devm_add_action_or_reset(dev, acpi_nfit_shutdown, acpi_desc);
>> +	if (rc)
>> +		return rc;
>> +
>> +	return acpi_dev_install_notify_handler(adev,
>> +					       ACPI_DEVICE_NOTIFY,
>> +					       acpi_nfit_notify);
>>  }
>>  
>>  static void acpi_nfit_remove(struct acpi_device *adev)
>>  {
>>  	/* see acpi_nfit_unregister */
>> +
>> +	acpi_dev_remove_notify_handler(adev,
>> +				       ACPI_DEVICE_NOTIFY,
>> +				       acpi_nfit_notify);
> Please use devm to trigger this release rather than making
> acpi_nfit_remove() contain any logic.

I think adding separate devm action to remove event handler is not
necessary. I'll put the removal in the beggining of acpi_nfit_shutdown() if you
don't object.

>
> An additional cleanup opportunity with the ->add() path fully devm
> instrumented would be to just delete acpi_nfit_remove() since it is
> optional and serves no purpose.

Will do,

Thanks !