Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp22628775rwd; Fri, 30 Jun 2023 10:20:31 -0700 (PDT) X-Google-Smtp-Source: APBJJlHyHbMKvb5K2wUSwrKwr/R/BOg3qmWr4DbXZUrPovmTEGo+7FAh51ZhyXaB99ZJndLL/B/e X-Received: by 2002:a17:90a:42:b0:263:16f3:f04a with SMTP id 2-20020a17090a004200b0026316f3f04amr2541470pjb.1.1688145631555; Fri, 30 Jun 2023 10:20:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688145631; cv=none; d=google.com; s=arc-20160816; b=vMpEIof1nwq4GYhB0UagnKnmqPXbrLXFRAQss+dg/LVw0tXAJ2O6MO3mXBCwgAQtcI yu4ddbQZGfzMhgboW4tO4WFEJuLUgRgEruIB7/GVqFc1ZzMkUmTvPattLKYJmmPjVz4X Gj6yBZ571co8xTmvbqEefs4syGSK4pC2tVmq40/CmviH+fBG7tfydWel4FN3neZkSwa4 bNDgPzoXOZK2np+lr33sTN0uTbiA4AHD4GUV8dDHayhjWR2ISZ221K/VKwG40E4O+qBO D7Jfaf1ZlsX6mR4ozAeq3hje/5MAldi3n7JBFBag+ZpQx2FyqGVfOFjZblGb3VB7C4oq cprw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=cFm+MwUTJ0Nrf5st/c0X4e2ak6wIZTxERF+a0wkzT1c=; fh=I1duY+W817wZ7K9mE9FpLzz1bQbbKRk/etjA9bK6ZgY=; b=Van66bOUP+qEoCMNxWFoN8rsrLWjCa0pRuse0yG0CK9yKQ8bxA6NTKJGNcQA18X/gi AGgd2Uv6gtMtDFMbTIA1xxgRKJcgloCMrUYRa71PqLbXLndPP4OjDDE5hwMNKq343Onm Bwqmy17utoyP+5iIvqLDB3xWlAV6JeZklos+11XdBehg9PEkY94Bws9mBOUu9Fn3y+Ap DsC9ES7L/cMIVGDiJhSRIfJ+Us1G5ILeOY2Ij8+Aj+LE3oG8bw6+PrWFa6kqTed/F//c mdDkIrs9DH0BVHVp162ONRJnekLl8BtvtoiJ6STCkV4N2xtbAL3oHE6gK4vmLee/f+3W 44mQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 22-20020a17090a019600b0026101590c32si12939441pjc.2.2023.06.30.10.20.18; Fri, 30 Jun 2023 10:20:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232467AbjF3Qtf (ORCPT + 99 others); Fri, 30 Jun 2023 12:49:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230009AbjF3Qtc (ORCPT ); Fri, 30 Jun 2023 12:49:32 -0400 Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5607D1BD0; Fri, 30 Jun 2023 09:49:31 -0700 (PDT) Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-3459baa237bso9107515ab.3; Fri, 30 Jun 2023 09:49:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688143770; x=1690735770; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cFm+MwUTJ0Nrf5st/c0X4e2ak6wIZTxERF+a0wkzT1c=; b=EZ9vGeSgJuPE2tUkc1JAOJ1BvqGWz/a5IunxQIQHAXJ4xNxKS6VCy/De6dNyuJCkhF jCrSoOLIq3mVsO6VLHWa3osGoY4/XitxTQuIdQ7Ac/JI2QJsgiuZPdsB2PSEARqnDV10 r25jHETDM7JMiPvfEc57UYIy+ZYE/5IXmCD27irJxfrDkcM8CugfH4Jcfl/zvlL9Pd0h DYGj8Yjh4DuSJ84NOUzUTxw2qlnkULXOsJ1qpXFlUsE7kDBReWEwLwxzayOR2qgb24XD owNlk2kJT+Nq24UeonjfzJYyNCosHQCleGwDpNKTkH9gnWHs76xq9wTZKOWONqW1ajz/ /ByQ== X-Gm-Message-State: AC+VfDw81jQsyB/cVK7cXPBf5q4yoCAyhDd+dnpXYC/gD+6B61RG5IFa bjqQ47EUPZy51hx2hdIFcaGGh7eDOQ== X-Received: by 2002:a5d:94c3:0:b0:76c:71dc:55f3 with SMTP id y3-20020a5d94c3000000b0076c71dc55f3mr3486773ior.6.1688143770566; Fri, 30 Jun 2023 09:49:30 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id k8-20020a02a708000000b0042aebaf294dsm2142602jam.146.2023.06.30.09.49.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 09:49:29 -0700 (PDT) Received: (nullmailer pid 1887131 invoked by uid 1000); Fri, 30 Jun 2023 16:49:28 -0000 Date: Fri, 30 Jun 2023 10:49:28 -0600 From: Rob Herring To: Astrid Rost Cc: Andy Shevchenko , Krzysztof Kozlowski , Jacek Anaszewski , Pavel Machek , Lee Jones , Conor Dooley , kernel@axis.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: leds: Read max-brightness from devicetree Message-ID: <20230630164928.GA1884613-robh@kernel.org> References: <20230630092248.4146169-1-astrid.rost@axis.com> <20230630092248.4146169-3-astrid.rost@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230630092248.4146169-3-astrid.rost@axis.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 30, 2023 at 11:22:47AM +0200, Astrid Rost wrote: > Add max-brightness in order to reduce the current on the connected LEDs. > Normally, the maximum brightness is determined by the hardware, and this > property is not required. This property is used to set a software limit. > It could happen that an LED is made so bright that it gets damaged or > causes damage due to restrictions in a specific system, such as mounting > conditions. Note that led-max-microamp should be preferably used, if it > is supported by the controller. > > Signed-off-by: Astrid Rost > --- > Documentation/devicetree/bindings/leds/common.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) The patch order is wrong. You have to define a property before you can use it. Otherwise, Reviewed-by: Rob Herring