Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230628102949.2598096-1-john.g.garry@oracle.com> <20230628102949.2598096-2-john.g.garry@oracle.com>
In-Reply-To: <20230628102949.2598096-2-john.g.garry@oracle.com>
From:   Ian Rogers <irogers@google.com>
Date:   Fri, 30 Jun 2023 10:22:16 -0700
Message-ID: <CAP-5=fXNFpDGJtESvYy=JF8snPyYrUVZ0m_G3XajXqqS_XLbHg@mail.gmail.com>
Subject: Re: [PATCH RFC 1/9] perf metrics: Delete metricgroup_add_iter_data.table
To:     John Garry <john.g.garry@oracle.com>
Cc:     acme@kernel.org, namhyung@kernel.org, jolsa@kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        renyu.zj@linux.alibaba.com, shangxiaojing@huawei.com,
        zhangshaokun@hisilicon.com, qiangqing.zhang@nxp.com,
        kjain@linux.ibm.com, kan.liang@linux.intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jun 28, 2023 at 3:30=E2=80=AFAM John Garry <john.g.garry@oracle.com=
> wrote:
>
> Member metricgroup_add_iter_data.table is only used in
> metricgroup__add_metric_sys_event_iter() as the @table arg to the
> add_metric() call there.
>
> However we only use the @table arg in add_metric() for resolving metrics,
> which is currently not relevant to sys event metrics. As such, don't
> bother passing this @table arg and use iter table instead, which is more
> sane.
>
> Signed-off-by: John Garry <john.g.garry@oracle.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/util/metricgroup.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.=
c
> index a6a5ed44a679..4389ccd29fe7 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -798,7 +798,6 @@ struct metricgroup_add_iter_data {
>         bool system_wide;
>         struct metric *root_metric;
>         const struct visited_metric *visited;
> -       const struct pmu_metrics_table *table;
>  };
>
>  static bool metricgroup__find_metric(const char *pmu,
> @@ -1112,7 +1111,7 @@ static int add_metric(struct list_head *metric_list=
,
>  }
>
>  static int metricgroup__add_metric_sys_event_iter(const struct pmu_metri=
c *pm,
> -                                       const struct pmu_metrics_table *t=
able __maybe_unused,
> +                                       const struct pmu_metrics_table *t=
able,
>                                         void *data)
>  {
>         struct metricgroup_add_iter_data *d =3D data;
> @@ -1123,7 +1122,7 @@ static int metricgroup__add_metric_sys_event_iter(c=
onst struct pmu_metric *pm,
>
>         ret =3D add_metric(d->metric_list, pm, d->modifier, d->metric_no_=
group,
>                          d->metric_no_threshold, d->user_requested_cpu_li=
st,
> -                        d->system_wide, d->root_metric, d->visited, d->t=
able);
> +                        d->system_wide, d->root_metric, d->visited, tabl=
e);
>         if (ret)
>                 goto out;
>
> @@ -1275,7 +1274,6 @@ static int metricgroup__add_metric(const char *pmu,=
 const char *metric_name, con
>                                 .system_wide =3D system_wide,
>                                 .has_match =3D &has_match,
>                                 .ret =3D &ret,
> -                               .table =3D table,
>                         },
>                 };
>
> --
> 2.35.3
>