Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230629195535.2590-8-casey@schaufler-ca.com> <b09a9753d31dc4b842cc2e058ae01f34.paul@paul-moore.com>
 <d39d5784-058f-9298-1cdb-2f0e550b206a@schaufler-ca.com>
In-Reply-To: <d39d5784-058f-9298-1cdb-2f0e550b206a@schaufler-ca.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Fri, 30 Jun 2023 14:23:43 -0400
Message-ID: <CAHC9VhQfejt=5+pUbUGZr1XAAEQsdmGBsenTiP-na6wmUUVUVg@mail.gmail.com>
Subject: Re: [PATCH v12 7/11] LSM: Helpers for attribute names and filling lsm_ctx
To:     Casey Schaufler <casey@schaufler-ca.com>
Cc:     linux-security-module@vger.kernel.org, jmorris@namei.org,
        serge@hallyn.com, keescook@chromium.org,
        john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp,
        stephen.smalley.work@gmail.com, linux-kernel@vger.kernel.org,
        linux-api@vger.kernel.org, mic@digikod.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 30, 2023 at 1:11=E2=80=AFPM Casey Schaufler <casey@schaufler-ca=
.com> wrote:
>
> On 6/29/2023 7:14 PM, Paul Moore wrote:
> > On Jun 29, 2023 Casey Schaufler <casey@schaufler-ca.com> wrote:
> >> Add lsm_name_to_attr(), which translates a text string to a
> >> LSM_ATTR value if one is available.
> >>
> >> Add lsm_fill_user_ctx(), which fills a struct lsm_ctx, including
> >> the trailing attribute value.
> >>
> >> All are used in module specific components of LSM system calls.
> >>
> >> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
> >> Reviewed-by: Serge Hallyn <serge@hallyn.com>
> >> ---
> >>  include/linux/security.h | 14 +++++++++++++
> >>  security/lsm_syscalls.c  | 24 ++++++++++++++++++++++
> >>  security/security.c      | 44 +++++++++++++++++++++++++++++++++++++++=
+
> >>  3 files changed, 82 insertions(+)
> > ..
> >
> >> diff --git a/security/security.c b/security/security.c
> >> index 199db23581f1..72ad7197b2c9 100644
> >> --- a/security/security.c
> >> +++ b/security/security.c
> >> @@ -770,6 +770,50 @@ static int lsm_superblock_alloc(struct super_bloc=
k *sb)
> >>      return 0;
> >>  }
> >>
> >> +/**
> >> + * lsm_fill_user_ctx - Fill a user space lsm_ctx structure
> >> + * @ctx: an LSM context to be filled
> >> + * @context: the new context value
> >> + * @context_size: the size of the new context value
> >> + * @id: LSM id
> >> + * @flags: LSM defined flags
> >> + *
> >> + * Fill all of the fields in a user space lsm_ctx structure.
> >> + * Caller is assumed to have verified that @ctx has enough space
> >> + * for @context.
> >> + *
> >> + * The total length is padded to a multiple of 64 bits to
> >> + * accomodate possible alignment issues.
> > We should drop the sentence above now that alignment is the caller's
> > responsibility, but since that was largely my fault I can fix this up
> > during the merge assuming you're okay with that Casey.
>
> I have to fix the error in patch 8/11 anyway. I can fix this, too.

Great, thanks.

--=20
paul-moore.com