Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp22735642rwd; Fri, 30 Jun 2023 11:51:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlFtkYe0d3ErxkU9cZk1cjNK8X3fkQvlapTC/hudcn/BjKCClhtnESsxIwZdt+DymKNL9AW5 X-Received: by 2002:a17:90b:30c3:b0:262:df79:6f81 with SMTP id hi3-20020a17090b30c300b00262df796f81mr2509602pjb.24.1688151102552; Fri, 30 Jun 2023 11:51:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688151102; cv=none; d=google.com; s=arc-20160816; b=sClYIfUfqDJxQ0o/fVIbz7RzUC4quZouCD4H9OxbmJW6Vr4jKMi5Qo/YGZgZRPgnXa 3YX1xXb9xkehIrDRgdGgb7+DPf1BZYBhe6N7ZUSbvUwHOmYsmFv6I/69s1fdTERV/Jhn p+LUh8nc2+5GybRknjKuR1WdSfjn1eSVjkSJvEyhfe+GZUz3arGx5HakZCzxIdi2HUvY MmQNCh1t/Q4FUHpDtctsXvH1SVDbK1u3crbfFh2Qf8qcJlZSx5pzmhhYswZ279YDGuyc Z1HOAhlEJb83l74I+ojf4bptfqfbnFU5OFoPTI5ud5nICoxMIzn5sXs+NlX9VkLpmpSI 6wow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=NNf5I4mmX1jddRjQ2IuxkVUSBIaX6T/iNihW1d+D4H4=; fh=/XQ51QkqbP7JVPGG56nUUnH2W8aWS6gRjB9yEPt/6v4=; b=XQsWN1II/71EEi0c3zyVZv4jOV7AHwTzSLpb2gjP9IwXFabpK7d09zugGe09dND5QV T9YPjt/9KI+UyylwJ8NO341CjnbHYq0R37SIBuQVimh3dEYWEPh/NybZ3yDisZJkxfTP vTbcQXOtVsvqxLm5gqsdLRSTZVh5STgGrbj1SF95tGO6u8SkdqKSU2pkiCkXFKmnq0Zo plm8K3qQbsn4p4RVnkwjzOJt943HAIoDUr0E/vfuIgB2Mlbp41NuQJvWxK1K1kqT9aLN fgt6o2qp0Rg2Jx8sGW1vE6EoyIVK4qmdz5Jh6nGN0P1FHXyC9CTdzaZVu7nEt38uC+sO aWsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=FuBU9vc5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q80-20020a632a53000000b0055af2b131b7si8762006pgq.519.2023.06.30.11.51.28; Fri, 30 Jun 2023 11:51:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=FuBU9vc5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232805AbjF3StE (ORCPT + 99 others); Fri, 30 Jun 2023 14:49:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233239AbjF3Ssi (ORCPT ); Fri, 30 Jun 2023 14:48:38 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52C303C35; Fri, 30 Jun 2023 11:48:37 -0700 (PDT) Received: from mercury (dyndsl-091-248-211-174.ewe-ip-backbone.de [91.248.211.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 98AD166057EC; Fri, 30 Jun 2023 19:48:35 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1688150915; bh=SBBllfHo7bvybxOlx0jHFD0nrtAr7RUdPig05tF/QEE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FuBU9vc5FJn2Wt0zZYh2C3cohLT8a+12t7KPmUtbeGD4OfqEqEmU/KMTU89sC9tVy +0d/1Wle6xUyEgOXy6qTm1z6han1O0/p6D4q6t08Has0jxrIacb/bB3afOmYuar0Ky 6iEih5FKmTRDRhWIgzznSYSR5bC9BipiSasmGQCsZI/ai5dSl6x42SSmOGDWPi5tW4 46CJKmxyGZYyCNcypPiVzF+qytwp6sEPl/GiTXjfTt5iTpSpCsxn2TY73FC00eiq+J bxx7Mcj71vPWjTHpWBrAdEgHTdr2dv4HermFjqYrsuKkYCZmcj1J6urxKRRQnOYY17 o4aLxWwnr4QYQ== Received: by mercury (Postfix, from userid 1000) id 4696610613E0; Fri, 30 Jun 2023 20:48:33 +0200 (CEST) Date: Fri, 30 Jun 2023 20:48:33 +0200 From: Sebastian Reichel To: Geert Uytterhoeven Cc: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Lee Jones , Michael Turquette , Stephen Boyd , Linus Walleij , Mark Brown , Liam Girdwood , Alexandre Belloni , Alessandro Zummo , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Diederik de Haas , Vincent Legoll Subject: Re: [PATCH v8 05/14] mfd: rk808: split into core and i2c Message-ID: <20230630184833.o3lgqrtqzzwgb7nk@mercury.elektranox.org> References: <20230504173618.142075-1-sebastian.reichel@collabora.com> <20230504173618.142075-6-sebastian.reichel@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iqtscgntphb3oqls" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --iqtscgntphb3oqls Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Geert, On Fri, Jun 30, 2023 at 01:34:44PM +0200, Geert Uytterhoeven wrote: > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -1183,12 +1183,17 @@ config MFD_RC5T583 > > Additional drivers must be enabled in order to use the > > different functionality of the device. > > > > -config MFD_RK808 > > +config MFD_RK8XX > > + bool >=20 > Is there any specific reason why this cannot be modular, like most (all?) > of its users that select it? I don't remember why I made that bool. Tristate should be perfectly fine. Do you want to send a patch (I will test it of course), or should I take care of it? Greetings and thanks for the report, -- Sebastian --iqtscgntphb3oqls Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmSfI3IACgkQ2O7X88g7 +pqfHQ/+OX906BcLDwv+c9Vj7iD1xMf/jeseVPwosYdbwztaWSudEc2oqnLracEz qQBXFFZ2oQWA36fWxJfdrEIHW8OgcrkaAQ9IYKUja4qT4mNKEtyfC+xEH1PxTpTd Elj3lUA9NaLILoR2MN1Q2hTWHmmrevL0P1QEIEAXB2N6+D+fWKNApHvPZDw4eI+R iD2LLbVjYdmddX88zmZhKnAB4vuCZp/ReMR6Nki+eF/rCH3iR9S6gUomMFgW11Zq fwxTKYBlxxBz439pj7o+zgiZf3Dbk6oyv74FbsCgiP4oeNjrcrQqxUX28vwi8NwP FiCGdlCjY1gC4KwN4FqFBElQhKYJfU/0lxX60JUXh8EcDk3EVXatZUfSW+tfJFJw DZ49WcCb/RjvKsx9Q5vgK432RV0avSLgarHhFmRfs83c4Tj1CbormHQs2iZPZwyt n0R3mN+oI1v+ucvtGETOmICww36sWdf1nniscIKayv7FsOIqQlpF+WXB6or+UTUB 1RfrfcdsexLjNaJPHZ93Yfnkb1DQfOKEn9yYY1IUGpPBPH7vz2FoDdjrt2LYq6xR niQNPMqzD2KO/GYhGA2ipu4paWPvuZE+UDCCjWZiC+knxFL1zBf5eQzoeOQqFdTk tJovpTIl42CKM1oKm0MqAy1+lOqeWbkmJ7aHIkEB01Fb26w+3xc= =iqU3 -----END PGP SIGNATURE----- --iqtscgntphb3oqls--