Return-Path: <linux-kernel-owner+w=401wt.eu-S1754632AbXJVMWS@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754632AbXJVMWS (ORCPT <rfc822;w@1wt.eu>);
	Mon, 22 Oct 2007 08:22:18 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751828AbXJVMWL
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 22 Oct 2007 08:22:11 -0400
Received: from hu-out-0506.google.com ([72.14.214.230]:26019 "EHLO
	hu-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751706AbXJVMWJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 22 Oct 2007 08:22:09 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-disposition:content-type:content-transfer-encoding:message-id;
        b=FOvrBh/z/p/eT5r6sJDofnMrmr/u40QR4vHI4+TDAthExaZwxxL7XlQxGXXzclHqjwN93nnJ64qTf9Wm2co6jJR4Mkdn4F604RY3lB8kJ+SYKcD3c2VcJRWPb5pALoxHwARmwyxTOKHr4UEbNOWMY/CS6Ix5qDcl7CVXwF5QqsQ=
From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Fengguang Wu <wfg@mail.ustc.edu.cn>
Subject: Re: 100% iowait on one of cpus in current -git
Date: Mon, 22 Oct 2007 14:21:21 +0200
User-Agent: KMail/1.9.6
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org,
       Fengguang Wu <fengguang.wu@gmail.com>,
       Andrew Morton <akpm@linux-foundation.org>
References: <200710220822.52370.maximlevitsky@gmail.com> <200710221258.11384.maximlevitsky@gmail.com> <393051953.24752@ustc.edu.cn>
In-Reply-To: <393051953.24752@ustc.edu.cn>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200710221421.21439.maximlevitsky@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2839
Lines: 74

On Monday 22 October 2007 13:19:08 Fengguang Wu wrote:
> On Mon, Oct 22, 2007 at 12:58:11PM +0200, Maxim Levitsky wrote:
> > On Monday 22 October 2007 12:55:25 Fengguang Wu wrote:
> > > On Mon, Oct 22, 2007 at 12:40:24PM +0200, Maxim Levitsky wrote:
> > > > On Monday 22 October 2007 12:22:10 Peter Zijlstra wrote:
> > > > > > [  673.365631] pdflush       D c21bdecc     0   221      2
> > > > > > [  673.365635]        c21bdee0 00000046 00000002 c21bdecc c21bdec4 00000000 c21b3000 00000002
> > > > > > [  673.365643]        c0134892 c21b3164 c1e00200 00000001 c7109280 c21bdec0 c03ff849 c21bdef0
> > > > > > [  673.365650]        00052974 00000000 000000ff 00000000 00000000 00000000 c21bdef0 000529dc
> > > > > > [  673.365657] Call Trace:
> > > > > > [  673.365659]  [<c03fd728>] schedule_timeout+0x48/0xc0
> > > > > > [  673.365663]  [<c03fd50e>] io_schedule_timeout+0x5e/0xb0
> > > > > > [  673.365667]  [<c0170d11>] congestion_wait+0x71/0x90
> > > > > > [  673.365671]  [<c016b92e>] wb_kupdate+0x9e/0xf0
> > > > > > [  673.365675]  [<c016beb2>] pdflush+0x102/0x1d0
> > > > > > [  673.365679]  [<c013fa82>] kthread+0x42/0x70
> > > > > > [  673.365683]  [<c01050df>] kernel_thread_helper+0x7/0x18
> > > > > > 
> > > > > 
> > > > > That looks more like the inode writeback patches from Wu than the per
> > > > > bdi dirty stuff. The later typically hangs in balance_dirty_pages().
> > > > > 
> > > > > 
> > > > > 
> > > > 
> > > > Yes, you are right,
> > > > 
> > > > both revisions 1f7d6668c29b1dfa307a44844f9bb38356fc989b and 3e26c149c358529b1605f8959341d34bc4b880a3 work fine
> > > > But I didn't pay attention that those are before f4a1c2bce002f683801bcdbbc9fd89804614fb6b.
> > > > So, back to the drawing board.... :-)
> > > > 
> > > > Will test revision 2e6883bdf49abd0e7f0d9b6297fc3be7ebb2250b, just after writeback patches.
> > > 
> > > Thank you. I'll try if I can reproduce it locally...
> > > 
> > > Fengguang
> > > 
> > > 
> > 
> > Bingo,
> > 
> > Revision 2e6883bdf49abd0e7f0d9b6297fc3be7ebb2250b shows this bug.
> > 
> > I will now bisect to find exact patch that caused this bug,
> 
> This one is most relevant:
> 
> 1f7decf6d9f06dac008b8d66935c0c3b18e564f9
> writeback: introduce writeback_control.more_io to indicate more io
Exactly.
> 
> Still compiling the kernel...
> 
> Thank you,
> Fengguang
> 
> 
Hi,


I Bisected this bug to exactly this commit:

2e6883bdf49abd0e7f0d9b6297fc3be7ebb2250b
writeback: introduce writeback_control.more_io to indicate more io

Reverting it and compiling latest git shows no more signs of that bug.
Thanks,
	Best regards,
		Maxim Levitsky
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/