Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754760AbXJVMfb (ORCPT ); Mon, 22 Oct 2007 08:35:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752531AbXJVMfY (ORCPT ); Mon, 22 Oct 2007 08:35:24 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:35019 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951AbXJVMfX (ORCPT ); Mon, 22 Oct 2007 08:35:23 -0400 Date: Mon, 22 Oct 2007 14:35:06 +0200 From: Ingo Molnar To: Satyam Sharma Cc: Andrew Morton , Linux Kernel Mailing List Subject: Re: [PATCH] sched: Use show_regs() to improve __schedule_bug() output Message-ID: <20071022123506.GB4990@elte.hu> References: <20070831215822.26e1432b.akpm@linux-foundation.org> <20070902122835.GA27438@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.14 (2007-02-12) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.1.7-deb -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1085 Lines: 28 * Satyam Sharma wrote: > BTW would something similar would be useful in __schedule_bug() too? I > sure think so -- I'm not sure if EIP holds anything useful there, but > CPU#, EFLAGS and the init_utsname() stuff would be definitely helpful > ... > > [PATCH] sched: Use show_regs() to improve __schedule_bug() output > > A full register dump along with stack backtrace would make the > "scheduling while atomic" message more helpful. Use show_regs() > instead of dump_stack() for this. We already know we're atomic in here > (that is why this function was called) so show_regs()'s atomicity > expectations are guaranteed. > > Also, modify the output of the "BUG: scheduling while atomic:" header > a bit to keep task->comm and task->pid together and preempt_count() > after them. thanks, applied. Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/