Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230630201206.2396930-1-daniel.thompson@linaro.org>
In-Reply-To: <20230630201206.2396930-1-daniel.thompson@linaro.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Fri, 30 Jun 2023 13:56:55 -0700
Message-ID: <CAD=FV=WCa5LugcNwosHOPG8GSVfUEnDB9hbXWEop0z0ner12Yg@mail.gmail.com>
Subject: Re: [PATCH] kdb: move kdb_send_sig() declaration to a better header file
To:     Daniel Thompson <daniel.thompson@linaro.org>
Cc:     Jason Wessel <jason.wessel@windriver.com>,
        Kees Cook <keescook@chromium.org>,
        kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Fri, Jun 30, 2023 at 1:12=E2=80=AFPM Daniel Thompson
<daniel.thompson@linaro.org> wrote:
>
> kdb_send_sig() is defined in the signal code and called from kdb,
> but the declaration is part of the kdb internal code.
> Move the declaration to the shared header to avoid the warning:
>
> kernel/signal.c:4789:6: error: no previous prototype for 'kdb_send_sig' [=
-Werror=3Dmissing-prototypes]
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>

FWIW: these days, I think checkpatch yells at you for a bare
"Reported-by" like above. It ideally wants a "Closes" tag to follow
immediately with a link to the report, or in the very least a "Link"
tag if this doesn't fully address the issue.

> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>

Reviewed-by: Douglas Anderson <dianders@chromium.org>