Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp23030594rwd; Fri, 30 Jun 2023 16:55:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4ONGO1glAc9895jTXKf6cauPZhrix9DHgQNV9sewWGV2D6I+5SebFFC5KSKSRqsYL1YXAS X-Received: by 2002:a05:6808:3943:b0:3a1:df2a:2041 with SMTP id en3-20020a056808394300b003a1df2a2041mr3608130oib.45.1688169304859; Fri, 30 Jun 2023 16:55:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688169304; cv=none; d=google.com; s=arc-20160816; b=WD1+ruI5hPV1GcPipaP5SmOibRBo2Yfqbhug/LPlidqy6yN6QY7kQL/Q7LAC5Gtf6N nUKZO2HssxvbSD7RztW64+6h8W+ZwcLXEhzbHRLhN4i38XnEo/PWWwq8o6eUKtTHtYTr RJtoar+veekVDN5OA8ul7sj4giG1cOT+FExjOgmBNOAmgNpliPWeN1Pzjos1vz2G6xyx sN2KyiQmzM5a0IuXJSETkkIz/agnET406xtBqaYCISz69qhafRRQ2Mj/jNAKcWT0JVbQ llBshvBSCABL1QIcZW2KIitwmGkgi0eKpAoEO5qdqlo/++sjFhq+T1yLeJ+4RmuQ/4Ml mlUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=jvdz0LbFUd5KiEFSNFVLvK0uJCLqVYTsPuq+h53F+6E=; fh=GonUFlnzdesB7QiRYMHSCwh/0BBXRsN/U3SmGw2Jc8Y=; b=lEapTk+ZLDXTY6KHe3AcLFrWoLS+gmYibfa8P3LfVIGqdKf2zuQ9yMBN3azJtvgJuu Xs3jiY6kGHtqlBgLA2i0N32IWNk9FX/eybQgw7PecoK51gXn5lRK6Gn9SermP0bkKMSz xZ7RyLYlFsvvG86i9sYjtjYPJIOLD4xCV/eMUE8A+KxgQgJlV7t9RJijX0h8Vwd2jobJ KHoZWtxAQbFBFmWf7rtg+rrfDu1H5Ep83GgvRJPMy5U/b5Dmop5AUb8Rr+P7N2lggsEv YUKwvnS3nX2q6hzLVfjAzarDSg1xMksPwqEGXidYczxEM/TGtdetw8vKKwtJ6X+r+bLI mh4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="u/vsEj2F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d6-20020a630e06000000b0055731f11410si13406087pgl.470.2023.06.30.16.54.52; Fri, 30 Jun 2023 16:55:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="u/vsEj2F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232663AbjF3XV6 (ORCPT + 99 others); Fri, 30 Jun 2023 19:21:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232242AbjF3XVi (ORCPT ); Fri, 30 Jun 2023 19:21:38 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 193E75242; Fri, 30 Jun 2023 16:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jvdz0LbFUd5KiEFSNFVLvK0uJCLqVYTsPuq+h53F+6E=; b=u/vsEj2FgZ9QmeEuNpjS7q+tuh hONGbehXcGJxZhd9FubfoY6WSSYbJ9UPF61udiyY3YDrjQYxphEMAEmqW13hZrjYlrxP9Aj0+80Mv lSHjcDIUUYBt37PBBzN0m+QkmonWpmQLq/GzYl2uGsUYUh8itiU4LW5ukJtsPfTYW3ijiAUHQvXGD /rpdUy97sLEY2g6GOCv+CDWGzno0N9uACVNRdj00rgV0xz+EZ4SF3kwchTHqSgRqom7nK2WZbhQIG ZmRcejFw7P/KjuG88ANRAXoXaBUnf4BHaHCr5ZC/TzjAtteUMi03cESvUlAvVzauCMdK7+4M7+MBI SpvKEtHA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qFNPi-004kne-2X; Fri, 30 Jun 2023 23:20:30 +0000 Date: Fri, 30 Jun 2023 16:20:30 -0700 From: Luis Chamberlain To: Kees Cook Cc: Tom Rix , yzaikin@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] sysctl: set variable sysctl_mount_point storage-class-specifier to static Message-ID: References: <20230611120725.183182-1-trix@redhat.com> <202306131330.AAC4C43AC@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202306131330.AAC4C43AC@keescook> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 13, 2023 at 01:30:47PM -0700, Kees Cook wrote: > On Sun, Jun 11, 2023 at 08:07:25AM -0400, Tom Rix wrote: > > smatch reports > > fs/proc/proc_sysctl.c:32:18: warning: symbol > > 'sysctl_mount_point' was not declared. Should it be static? > > > > This variable is only used in its defining file, so it should be static. > > > > Signed-off-by: Tom Rix > > Reviewed-by: Kees Cook Queued up, thanks! Luis