Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Jun 2023 17:20:02 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>
Subject: Re: [PATCH v8 00/14] cxl/pci: Add support for RCH RAS error handling
Message-ID: <649f71329689f_14494294cc@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20230630231635.3132638-1-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230630231635.3132638-1-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tu162WkGC3PKUgInZ/VHhDUJLaI2h8huQYlMkYEP8jVuyIz/N19x01MD7/Tw?=
 =?us-ascii?Q?W0LH4qWX1YRTh6qkxHRv6Ug4k2irvOThG6aZWPhwQCBJ+siCQqKnUV/CUi3H?=
 =?us-ascii?Q?5S6ak2qnkuHbpthFXdugcpf+lW3gWWberjX6D+kSaVy57b/Q/tKNjY+Zb/J4?=
 =?us-ascii?Q?btIrZ4E8bXj3GzAHAXxPeEHw0pPTeU/TGoXWEWqODj5guNlczob3SQDwzkTY?=
 =?us-ascii?Q?+tM512P7PXZrqJ2Gi9nTARfITA7PF84pT5ZoBaPTGjCOk8FRBf0X8KnmKon7?=
 =?us-ascii?Q?8nZCOq6bQ4EeybcM12OixtJdxtBmo8DL1Ly37CdTYverh3rIA6pwe3Bjbj2m?=
 =?us-ascii?Q?0l76cXTYuQPUsE8MRwf9cYpOtwXvTGelGp38PhHKA3cpV1hrSb6NVxsgSd67?=
 =?us-ascii?Q?t5E/T5wc0MY6oNcHIXLeU5JbMp3tpcmdJscfpe5MQHVtPkQkpjOwXp3LzmnT?=
 =?us-ascii?Q?CBGnte/pw85UBrOmO8W2MiusdOZtna1lMOhCSCEDtHVeumzYw7Ax0PpIexy9?=
 =?us-ascii?Q?z4U2P4c2UJ4rlSPEOTl2bstWrqkg9Pgibf8iCrbV2HKrZBkrX/KpFM+/I1nT?=
 =?us-ascii?Q?v9icCYPiefEtFNJn1Cl9wYAmsjGFNIt63ryVVg7H4mcRwP4lpANpeFtGi0dq?=
 =?us-ascii?Q?A8Dw/fAnZUKwcmjK3/bo7BT663qsdNKucgkm85A5bDRe9g4ZjpkfdDKVN1zT?=
 =?us-ascii?Q?jtpqaNp4nKCdNAbMZsp4N5FhWWxYh0i/RnCQITBO/U78fO9l5wyI64R+j42P?=
 =?us-ascii?Q?dYTj7VTQFmoSKe4HEYRN9bHjhuix7ryOuTcj2kbndEw3t4UBh8JizwbxVAfc?=
 =?us-ascii?Q?iyBpoAfNN8vQYzrU9dTWGViOcmlFeAEopdPvGra1atIxZiNj5UYSxZ7hM9vG?=
 =?us-ascii?Q?vUp9nPEo8T4QwI2usi+yLo0DYvt/W0OP7oS62Mhax6hbjidjpUBjV6e5WTsd?=
 =?us-ascii?Q?Ucw7OndbR4VqsU0qgW/FkbvOwaRxfWF6UMRSOR/ZCA9bodbnPR0MRPNNTVxt?=
 =?us-ascii?Q?R3LSkP/rQR74IUqHaYyGqBGfx8sSh5vMms2af9+202RMXEwQ8THhYUK47Plm?=
 =?us-ascii?Q?uJQC7vIhNOQdZSJpc0OGoCcalitZsRvdInlLZ9IQ5tEskFpc0bi9khmyAM+w?=
 =?us-ascii?Q?aM9dQKScaUcryg+jCJfZoTqwbdp4BHqIZZf5VP9W/+Mo1cSgOry11uWlJQaQ?=
 =?us-ascii?Q?ugzgv6PGhzIVkQKTS1aPipf3AoC2FU1HGmw8OZIWaa/7jQZSU5NbjtGVJonz?=
 =?us-ascii?Q?B3noNOLsXTMJib8Veo9Z+vfoQRhd4eeyNvM9eOoQRraDnb3FFqCgXUFF0xvq?=
 =?us-ascii?Q?3zBBy15W4SSLeHXOYdyR0gboT1D5FfoLHHsR7y4JX0QvQf9e78tGgtzdn6rx?=
 =?us-ascii?Q?9PETl/Zj8zkRzxzmKA52pho1V1ezpLp3TCjUoBx5AHVUPZrVnxs/+g/PeVZr?=
 =?us-ascii?Q?eyWJoTnPtrMISY8TlG/4jvYKBYjs7uptaFnk2m/sPNawY6MAsNsMg9+i6Wt6?=
 =?us-ascii?Q?MCOqTuZzqfIx5DD2f43H6QpKSDKb1sD2ZVcXAWDXhljqUYdss4AqOploxZmh?=
 =?us-ascii?Q?piwS5NojL6PLnSmBaxneSogkeuZeDmpHBp6E3SYPw+OLByr86rvnX/tAN5aN?=
 =?us-ascii?Q?4Q=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 50531197-2f25-449d-b795-08db79c8ebce
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2023 00:20:06.1126
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ay+87+p53Kn5Pmn2UO69L8698a4Ql5Hrd0/LbiqSRNleAOt2hm8o3D0VKz1il89zpGUTqYahY4WmNL4kj+vuvi2PTkRCxI2lGD/PlHE/8sI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5701
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Terry Bowman wrote:
> This patchset enables CXL RCH error handling. This is necessary because RCH
> downstream port protocol error handling is implemented uniquely and not
> currently supported. These patches address the following:
> 
>    * Discovery and mapping of RCH downstream port AER registers.
> 
>    * AER portdrv changes to support CXL RCH protocol errors. 
> 
>    * Interrupt setup specific to RCH mode: enabling RCEC internal
>      errors and disabling root port interrupts.
> 
> Changes in V8:
>   - Rebased onto: commit
>     0c0df63177e3 ("Merge branch 'for-6.5/cxl-rch-eh' into for-6.5/cxl")
>   - cxl/port: Pre-initialize component register mappings
>     - Added patch to pre-initialize component register mappings.
>   - cxl/pci: Remove Component Register base address from
>     - Separated removal of Component Register base address in struct
>     cxl_dev_state to not break functionality.
>   - cxl/hdm: Use stored Component Register mappings to map HDM decoder
>     capability
>     - Implemented a less strict check in devm_cxl_setup_hdm(), be tolerant
>     if HDM decoder registers are not implemented.
>   - cxl/pci: Map RCH downstream AER registers for  logging protocol errors
>     - Fixed uninitialized access of map->dev in cxl_dport_map_regs().
>   - PCI/AER: Forward RCH downstream port-detected errors to the CXL.mem
>     dev handler
>     - Fix typo in patch description.
>   - cxl/pci: Update CXL error logging to use RAS register address
>     - Fix typo in patch description.

Hey Terry, thank you for turning this around so quickly. I will have a
look and see if this is suitable as a follow-up merge for v6.5 next week
since it would be nice to finish this off this cycle, but no promises.