Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230630113337.123257-1-colin.i.king@gmail.com>
In-Reply-To: <20230630113337.123257-1-colin.i.king@gmail.com>
From:   Steve French <smfrench@gmail.com>
Date:   Sat, 1 Jul 2023 00:23:50 -0500
Message-ID: <CAH2r5mvkWeMO-AoPEpDbeKy8_K5hz3nJL3-BPh+w4Dow0qoOkg@mail.gmail.com>
Subject: Re: [PATCH][next] smb: client: remove redundant pointer 'server'
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     Steve French <sfrench@samba.org>,
        Paulo Alcantara <pc@manguebit.com>,
        Ronnie Sahlberg <lsahlber@redhat.com>,
        Shyam Prasad N <sprasad@microsoft.com>,
        Tom Talpey <tom@talpey.com>, linux-cifs@vger.kernel.org,
        samba-technical@lists.samba.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

merged into cifs-2.6.git for-next

On Fri, Jun 30, 2023 at 6:35=E2=80=AFAM Colin Ian King <colin.i.king@gmail.=
com> wrote:
>
> The pointer 'server' is assigned but never read, the pointer is
> redundant and can be removed. Cleans up clang scan build warning:
>
> fs/smb/client/dfs.c:217:3: warning: Value stored to 'server' is
> never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  fs/smb/client/dfs.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/smb/client/dfs.c b/fs/smb/client/dfs.c
> index 26d14dd0482e..1403a2d1ab17 100644
> --- a/fs/smb/client/dfs.c
> +++ b/fs/smb/client/dfs.c
> @@ -143,7 +143,6 @@ static int __dfs_mount_share(struct cifs_mount_ctx *m=
nt_ctx)
>         struct smb3_fs_context *ctx =3D mnt_ctx->fs_ctx;
>         char *ref_path =3D NULL, *full_path =3D NULL;
>         struct dfs_cache_tgt_iterator *tit;
> -       struct TCP_Server_Info *server;
>         struct cifs_tcon *tcon;
>         char *origin_fullpath =3D NULL;
>         char sep =3D CIFS_DIR_SEP(cifs_sb);
> @@ -214,7 +213,6 @@ static int __dfs_mount_share(struct cifs_mount_ctx *m=
nt_ctx)
>         } while (rc =3D=3D -EREMOTE);
>
>         if (!rc) {
> -               server =3D mnt_ctx->server;
>                 tcon =3D mnt_ctx->tcon;
>
>                 spin_lock(&tcon->tc_lock);
> --
> 2.39.2
>


--=20
Thanks,

Steve