Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp23324051rwd; Fri, 30 Jun 2023 23:15:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlFiPTQoH/DMvryQeZLOglbtErm80QsVQ5HoW3OorpoFCgf4gHlQX/zLe/uhOwTnylDuGwa/ X-Received: by 2002:a0d:ddc4:0:b0:578:e260:7751 with SMTP id g187-20020a0dddc4000000b00578e2607751mr1652801ywe.24.1688192159742; Fri, 30 Jun 2023 23:15:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688192159; cv=none; d=google.com; s=arc-20160816; b=QaMXUEt86nyg+SjNPrDnKfMypzt6Kns/GET8LdF0vs3wA3IuA/09yOXZPqasfhR98V jeTZRgw2cAOmw7eI9S+MpsJSw26f3uNbmp6mWF/tWHlNB30J8vI1yVPkL2RZFfE/8pfA WTGURl7n3HL9s4x83xNDFC8w8U4jrbH7Drf4Wn9lqdYF28dM2nJNeNhb4WBAeP97PvGL Y3DzFrl8Kkxu4pHaXJqSEJygeqYLSTYor989Hr8HYtNGcrDFHQrhfJK0AcFPHDqbOpT0 ZXryyWjZ30gob4+VCzKX1gONhE0zex7e3St3btDp5jFmUQBG2D/8b5i51roPllh+8poi fqtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=8RecPPsiSTWBxpWdpzI5Sl/AYU7LBN8bZWqUZfNxw00=; fh=BZBYumpHHsfane6a1QErVXuglKnSK2z6fDrg5UIisfs=; b=nwC8Qny4dtony+A830YxYss3PlowkSwX++cJJHc3O6v07RCp14zVbBFiU1zWGBJvOo yshJ4SWSXiMn3oH232tHG8ShxSaaGLZZLNgmUl39kqpBrBp9rrc04xthurGUZKbN4v8a uAVEhJVJyR6dNr3arNE1NdW5RpVWZF4BrC5flOhFaOXRGRXd5IekfQ+Jtb0FcAoVbd08 3eQkoFsFDyYqPTm6I9xEzRoR01a6pPHGK+6etWd+AOx0TPhel4S5r0fHMNWzKClK8JCd /uO3AILCPhRZEHAlN5A0FrCpRG/VrH+dbM+ghBiDvRca0d+DPHGaeDa962cHqWY9DdVD Ne2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=B7zw9yit; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t19-20020a63dd13000000b005572b563e65si14056520pgg.305.2023.06.30.23.15.47; Fri, 30 Jun 2023 23:15:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=B7zw9yit; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229641AbjGAFrU (ORCPT + 99 others); Sat, 1 Jul 2023 01:47:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbjGAFrR (ORCPT ); Sat, 1 Jul 2023 01:47:17 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA148B7 for ; Fri, 30 Jun 2023 22:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=8RecPPsiSTWBxpWdpzI5Sl/AYU7LBN8bZWqUZfNxw00=; b=B7zw9yitHEQTmDn2kjTgWPrHOh WPMiXKAvJiw89W5PVFiIWljU0g7oQmHwQ/1zQOQbFc2feJyCz9x3egbwTkathgRDkXfEJfLwZp8xz sV35J02ktnzA0LjbkTmLeZFhhUWWFZ25f+cKB2mmqnfc1tbuhEn0ZHHbcf77wupPqH6B9hVpCvcJ0 2PVs7pDJR5yKjw/Or8Hmz5YGk1TyNYyRxan6vJpx8QcVMudlOfaF+4Gvva1wFZdAHoJjN1pys7PQx VaSyTwf3Xkmi7FnI1G7miGTzb4a0Juf5DhX6/x9JUfWBfA5C3CmFeFbvKFrHuOPyvDEx/fr/PUgPl xZba4xhg==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qFTRz-005E95-1c; Sat, 01 Jul 2023 05:47:15 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Kumar Gala , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Michael Ellerman , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org Subject: [PATCH v2] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y Date: Fri, 30 Jun 2023 22:47:12 -0700 Message-ID: <20230701054714.30512-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In a randconfig with CONFIG_SERIAL_CPM=m and CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error: ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined! Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y. Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial ports.") Signed-off-by: Randy Dunlap Cc: Kumar Gala Cc: "Pali Rohár" Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Pali Rohár --- v2: add Pali's R-b; drop Scott Wood from Cc: list arch/powerpc/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug --- a/arch/powerpc/Kconfig.debug +++ b/arch/powerpc/Kconfig.debug @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x config PPC_EARLY_DEBUG_CPM bool "Early serial debugging for Freescale CPM-based serial ports" - depends on SERIAL_CPM + depends on SERIAL_CPM=y help Select this to enable early debugging for Freescale chips using a CPM-based serial port. This assumes that the bootwrapper