Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 01 Jul 2023 09:18:25 +0200
Message-ID: <87wmzk6qwu.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     dengxiang <dengxiang@nfschina.com>
Cc:     tiwai@suse.com, yangyingliang@huawei.com, perex@perex.cz,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ALSA: hda/realtek: Add quirks for Unis  H3C Desktop B760 & Q760
In-Reply-To: <20230701063051.2543538-1-dengxiang@nfschina.com>
References: <20230701063051.2543538-1-dengxiang@nfschina.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sat, 01 Jul 2023 08:30:51 +0200,
dengxiang wrote:
> 
> These models use NSIWAY amplifiers for internal speaker, but cannot put
> sound outside from these amplifiers. So eapd verbs are needed to initialize
> the amplifiers. They can be added during boot to get working sound out
> of internal speaker.
> 
> ---
> V3:
> - do some adjustment for eapd verbs and keep the capital letters for
>   ALC_* enums.
> v2:
> - remove warning about unused variable 'spec'.

Looks almost good, but I forgot one more thing:

> @@ -11792,6 +11800,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1b35, 0x1234, "CZC ET26", ALC662_FIXUP_CZC_ET26),
>  	SND_PCI_QUIRK(0x1b35, 0x2206, "CZC P10T", ALC662_FIXUP_CZC_P10T),
>  	SND_PCI_QUIRK(0x1c6c, 0x1239, "Compaq N14JP6-V2", ALC897_FIXUP_HP_HSMIC_VERB),
> +	SND_PCI_QUIRK(0x10ec, 0x0897, "UNIS H3C X500s", ALC897_FIXUP_UNIS_H3C_X500S),
>  
>  #if 0
>  	/* Below is a quirk table taken from the old code.

The table is sorted in SSID order, so please put at the right
position.


thanks,

Takashi