Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp23624251rwd; Sat, 1 Jul 2023 05:03:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlFqCS2Va2IC0DqLvLkQdEsFcpqZEbhYRYhnBn6OZuE8IDLnnnaR2dqznenFzp8+h0gpMKeU X-Received: by 2002:a17:90b:954:b0:262:fc42:c7bc with SMTP id dw20-20020a17090b095400b00262fc42c7bcmr3467701pjb.32.1688213029174; Sat, 01 Jul 2023 05:03:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688213029; cv=none; d=google.com; s=arc-20160816; b=U1yVOhH8JL7WGLTInTxN6OPnsxbgEtJrB+Iv4Kt6Gzwg/qsT5l/UiYso7xnsJ1PhCN HL5jN1jDJNdwpAyOvn1mr1NAvepQ4VCu9YJmKtiMhXOj0m16L+evHb3AxXheoLyyu2cK WdwO2SIJb8Ml5rhbrGCwFylbvZxyVB7LblByKqPzbWZRCdUc8bdoSk9TWVb6ymVMP6hc PY5CVW1Pv6aDyoUSHwCLI/IFJXcvI6rQBWBOq4wgxnVhBGPHq9cJTuSr88paukKhPHPG w+nLK9Pk9VCSh3/wYhVF4pR+sOGDnJfi1GuEsrJmtX+8ZcrOufJK3s3+R7lDNoCtejTU wPbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gmmxI/09Vu1gvcqFW6wSCMsDrsU4gDstlNgv8XFwqYg=; fh=+ZZY8euKXQQoxYm0pLRD1pWFekG9R9jkoM3JiIIId1o=; b=HaA7Z2AtYoL/jZOMWxAqRPJ7wDMM0YU3YEwdK3BW3z5SSLYrVyLfD5DZums1tOq15Z 6pNrOMNMjnD8DsCicUEwVWd2duFJzDgc2UwLVFswpOT96vk7nzPCPVc0EkRxcDXevB7O uKx2Q9tOA9rLV7GHmO8RIrzcMmb5tqUDed8C8/9yfrF2Qbq5o2CdDnL95UD65DSIcNrA oPuGuFJbkWYY92PGtI40LxAdV18zYytHaYPbfMTAuOdUdWkuHerLDEh5rdTVVl+p8hU/ +6VstuIJCwNN+mqiwBQ+YRvlN7MvahyNvXzMFkWmFCOHhE+bllt+s7sRsuLEhC2UV9Re v1og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hYrTCI7J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t9-20020a17090abc4900b0026306d2d484si9702584pjv.111.2023.07.01.05.02.49; Sat, 01 Jul 2023 05:03:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hYrTCI7J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229762AbjGALGJ (ORCPT + 99 others); Sat, 1 Jul 2023 07:06:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbjGALGJ (ORCPT ); Sat, 1 Jul 2023 07:06:09 -0400 Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5416A3ABF for ; Sat, 1 Jul 2023 04:06:08 -0700 (PDT) Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-3a3373211a1so2015546b6e.0 for ; Sat, 01 Jul 2023 04:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1688209567; x=1690801567; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gmmxI/09Vu1gvcqFW6wSCMsDrsU4gDstlNgv8XFwqYg=; b=hYrTCI7JxoaqJZg/w4gVpQgy48lZiuGWo+hifIVceh6qtqUdzsRTROEVXNPinlvfig BRpaenb+2Tadwnhn3gTkXC5r/x4rgdVPWBAD6PUjl+IHgWs/YMbNSXRJVIWYmfVrIb1I 40cO21V4kRB8KA0ezJ5ZV+J4h/24JpkVQSWFI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688209567; x=1690801567; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gmmxI/09Vu1gvcqFW6wSCMsDrsU4gDstlNgv8XFwqYg=; b=fyRIrMYNV99H5+QbQ2AMM+NgqAEhOVm4TIWDYw6QRkRAtbCtd48fG9bazt4t68WxcZ IE8fXbVYVXP4k/MmGifBUmfBSfb7Wm0oVPz8ImfgWA2Q2Q0EqH9heAFA+toxE0eL0mRo Gg67ySJMRGCf0B1yAB1sU88vryIyKYXaibCuWXvylL+5E/lR6hCJ3uOYAcd9iFSRvChd NVKGTIYXeadezIFLYEYn6TrFvpuYgQHBDmtC4xZK/gKrCIi7ZxTxvUkSPHKW0qWXYsx/ HaGe5dkqC4mxjyjKzhfuICj65xHHfyC+GPIrFdzTs1QBOiPsiHx+cKYLlnMj8/rbyNl9 1PlQ== X-Gm-Message-State: AC+VfDztgY3y6QmSvc+x/RGVXsyfgo20NdKGQjF03iqvjIUsySvi5py0 s6u6WE31Vn2r/T5OrRcNZn0jEA== X-Received: by 2002:a05:6808:158d:b0:3a3:6e8e:5168 with SMTP id t13-20020a056808158d00b003a36e8e5168mr6106193oiw.39.1688209567625; Sat, 01 Jul 2023 04:06:07 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id g19-20020aa78193000000b0065dd1e7c2c1sm9025796pfi.63.2023.07.01.04.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jul 2023 04:06:07 -0700 (PDT) Date: Sat, 1 Jul 2023 20:06:02 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 3/3] zsmalloc: remove zs_compact_control Message-ID: <20230701110602.GB283328@google.com> References: <20230624053120.643409-1-senozhatsky@chromium.org> <20230624053120.643409-4-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FSL_HELO_FAKE, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (23/06/26 10:14), Minchan Kim wrote: > On Sat, Jun 24, 2023 at 02:12:16PM +0900, Sergey Senozhatsky wrote: > > From: Minchan Kim > > > > __zs_compact always putback src_zspage into class list after > > migrate_zspage. Thus, we don't need to keep last position of > > src_zspage any more. Let's remove it. > > > > Signed-off-by: Minchan Kim > > Thanks for picking it up, Sergey! Thank you for clearing up the code!