Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp23938415rwd; Sat, 1 Jul 2023 09:35:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6CreNOz53NMJ2L/ut1NYHg2/8l8SY/m6ymzVr8CHuouRreQKRLcWIJ9KR9r7h7ZsQpYen4 X-Received: by 2002:a9d:7e8c:0:b0:6af:870c:b71b with SMTP id m12-20020a9d7e8c000000b006af870cb71bmr6444339otp.27.1688229321450; Sat, 01 Jul 2023 09:35:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688229321; cv=none; d=google.com; s=arc-20160816; b=tjMc9axUiF6HdjaSK1eGiW7NZOisPiIeMWcPbqgzFw0dwSvmLI+c8X34gPxJT3B1mT pxbfdD/5T00FXiLnj4lkT7CIIxDpTNGsEjdC68hwcslqN04y8Ii3z4Xn37IR8gP3+3C5 FRJOmK5/3OofiU/S1+lUIEtH9XIUNJD06lDqKCUt4Tuwm7gtpUnqk0Md41e7Ffi5w3My 23/QyqMl9C1euZctVKdHFiEbTohzLjkpihN+LkJElAYpmuAf0ywc/DNV84l9u5RLehk6 kD18XFdseKxSSylXLDFqok2eVwGqCYQZkQfs82g9my4R2Y0un8ru/77z+M2Gg9SlC5UO znJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9PVVUcb5RkwFUjMyrKy1zG2bSIkmM/JEyEAWV9cGkZ8=; fh=ApUO0fuTJD3LdDtObuv5Veq1fnN6bOjCp7tNCU1Rfiw=; b=NC62sE+NjQaj8GS1dxQUjlEkX2GdbkltVWZTj2K39Ag2FOfm3S2fmoO9KB3Q3kUFQY h6AHH1ogEuRsQTiVgM0mXzJiokFQT+Z5rCS1RkXlc8kM95/e45lqQGm2YnHvPg0J/eY0 p/Q8R8zo++wCfnic9YKDkJwt7gJP8JF1n+Ew1mx5Fdiszx1RFis6nEhhm55QTAfgKtkM 1A1VifyM3owcbplLUMN3JnxcVJTAxMplVcU7SNR49FFApYE+gPWqdBoneX0xufIOeWg0 wcMQU+6ZiF54kO6CRQQ3/K7Fstr6oLShTmr5I5syYNae3J9ioXat2PPBnJa8ofVfY8hz Up5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=tcEWTOzM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z2-20020a656642000000b00553b02a9a1dsi14426036pgv.217.2023.07.01.09.35.09; Sat, 01 Jul 2023 09:35:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=tcEWTOzM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229906AbjGAQVg (ORCPT + 99 others); Sat, 1 Jul 2023 12:21:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbjGAQVf (ORCPT ); Sat, 1 Jul 2023 12:21:35 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9964A10DC; Sat, 1 Jul 2023 09:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=9PVVUcb5RkwFUjMyrKy1zG2bSIkmM/JEyEAWV9cGkZ8=; b=tcEWTOzM+VUgGcLfG7qPNzcJgm aFwCefY9v4aGd6IpO37Sivc+M5B6+rIeayxeVKYHfhS7J/8aTrrwiCtl5Fl+kvJ14sIIE7stQ4VbL lo33g5f9u98sY8vpRKNmmUvBjihWBl98MavpYqksC7+mVodbn8lk7oLXuD2aCc+x2vMo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qFdLW-000NLQ-89; Sat, 01 Jul 2023 18:21:14 +0200 Date: Sat, 1 Jul 2023 18:21:14 +0200 From: Andrew Lunn To: Jie Luo Cc: hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] net: phy: at803x: add qca8081 fifo reset on the link down Message-ID: <34ef466e-df95-4be4-8366-64baf5f04cca@lunn.ch> References: <20230629034846.30600-1-quic_luoj@quicinc.com> <20230629034846.30600-4-quic_luoj@quicinc.com> <0f3990de-7c72-99d8-5a93-3b7eaa066e49@quicinc.com> <924ebd8b-2e1f-4060-8c66-4f4746e88696@lunn.ch> <7144731c-f4ae-99b6-d32a-1d0e39bc9ee7@quicinc.com> <49f8ca40-e079-ad00-256e-08a61ffced22@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49f8ca40-e079-ad00-256e-08a61ffced22@quicinc.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hi Andrew, > it is the PLL related registers, there is no PHY ID existed in MII register > 2, 3 of this block, so it can't be instantiated as the generic PHY device. Well, phylib is going to scan those ID registers, and if it finds something other than 0xffff 0xffff in those two ID registers it is going to think a PHY is there. And then if there is no driver using that ID, it will instantiate a generic PHY. You might be able to see this in /sys/bus/mdio_bus, especially if you don't have a DT node representing the MDIO bus. Andrew