Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 2 Jul 2023 00:54:32 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Mike Rapoport (IBM)" <rppt@kernel.org>,
        Deming Wang <wangdeming@inspur.com>,
        Ira Weiny <ira.weiny@intel.com>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Peter Collingbourne <pcc@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Vlastimil Babka <vbabka@suse.cz>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2] Documentation/mm: Add information about
 kmap_local_folio()
Message-ID: <ZKC8uE9fE57PuL91@casper.infradead.org>
References: <20230701142041.9992-1-fmdefrancesco@gmail.com>
 <68a9b3aa-d064-ed6a-2bcd-9423eb4f595c@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <68a9b3aa-d064-ed6a-2bcd-9423eb4f595c@infradead.org>
Precedence: bulk

On Sat, Jul 01, 2023 at 08:21:20AM -0700, Randy Dunlap wrote:
> > -* kmap_local_page().  This function is used to require short term mappings.
> > -  It can be invoked from any context (including interrupts) but the mappings
> > -  can only be used in the context which acquired them.
> > -
> > -  This function should always be used, whereas kmap_atomic() and kmap() have
> > +* kmap_local_page(), kmap_local_folio() - These functions are used to require
> 
>                                                                          acquire ?

"create" might be better?

> > +  short term mappings. They can be invoked from any context (including
> > +  interrupts) but the mappings can only be used in the context which acquired
> > +  them. The only differences between them consist in the first taking a pointer
> > +  to a struct page and the second taking a pointer to struct folio and the byte
> > +  offset within the folio which identifies the page.
> 
> -- 
> ~Randy