Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230630085230.437-1-ravi.bangoria@amd.com> <CAM9d7chYnT2s1V1juP+EyewJfRD+2qHGs2pwghh=k3kFf1P9BA@mail.gmail.com>
In-Reply-To: <CAM9d7chYnT2s1V1juP+EyewJfRD+2qHGs2pwghh=k3kFf1P9BA@mail.gmail.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Sat, 1 Jul 2023 18:03:30 -0700
Message-ID: <CAM9d7ciV--mPi_MFQdsa8eoGp82NB0B5BmVccP_kMB65wGJafg@mail.gmail.com>
Subject: Re: [PATCH v3] perf evsel amd: Fix IBS error message
To:     Ravi Bangoria <ravi.bangoria@amd.com>
Cc:     acme@kernel.org, peterz@infradead.org, irogers@google.com,
        jolsa@kernel.org, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com,
        santosh.shukla@amd.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Sat, Jul 1, 2023 at 11:17 AM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Hi Ravi,
>
> On Fri, Jun 30, 2023 at 1:53 AM Ravi Bangoria <ravi.bangoria@amd.com> wrote:
> >
> > AMD IBS can do per-process profiling[1] and is no longer restricted to
> > per-cpu or systemwide only. Remove stale error message. Also, checking
> > just exclude_kernel is not sufficient since IBS does not support any
> > privilege filters. So include all exclude_* checks. And finally, move
> > these checks under tools/perf/arch/x86/ from generic code.
> >
> > Before:
> >   $ sudo ./perf record -e ibs_op//k -C 0
> >   Error:
> >   AMD IBS may only be available in system-wide/per-cpu mode.  Try
> >   using -a, or -C and workload affinity
> >
> > After:
> >   $ sudo ./perf record -e ibs_op//k -C 0
> >   Error:
> >   AMD IBS doesn't support privilege filtering. Try again without
> >   the privilege modifiers (like 'k') at the end.
> >
> > [1] https://git.kernel.org/torvalds/c/30093056f7b2
> >
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Applied to perf-tools-next, thanks!