Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 02 Jul 2023 10:01:25 +0200
Message-ID: <87mt0e7ne2.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     dengxiang <dengxiang@nfschina.com>
Cc:     tiwai@suse.com, yangyingliang@huawei.com, perex@perex.cz,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] ALSA: hda/realtek: Add quirks for Unis H3C Desktop B760 & Q760
In-Reply-To: <20230701080430.2560118-1-dengxiang@nfschina.com>
References: <20230701080430.2560118-1-dengxiang@nfschina.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sat, 01 Jul 2023 10:04:30 +0200,
dengxiang wrote:
> 
> These models use NSIWAY amplifiers for internal speaker, but cannot put
> sound outside from these amplifiers. So eapd verbs are needed to initialize
> the amplifiers. They can be added during boot to get working sound out
> of internal speaker.
> 
> ---
> V4:
> - put at the right position to keep the PCI SSID order for the whole.
> V3:
> - do some adjustment for eapd verbs and keep the capital letters for
>   ALC_* enums.
> v2:
> - remove warning about unused variable 'spec'.
> 
> Signed-off-by: dengxiang <dengxiang@nfschina.com>

Signed-off-by tag must be put before the line '---'.
But, above all....

> @@ -11772,6 +11780,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1043, 0x1bf3, "ASUS N76VZ", ALC662_FIXUP_BASS_MODE4_CHMAP),
>  	SND_PCI_QUIRK(0x1043, 0x8469, "ASUS mobo", ALC662_FIXUP_NO_JACK_DETECT),
>  	SND_PCI_QUIRK(0x105b, 0x0cd6, "Foxconn", ALC662_FIXUP_ASUS_MODE2),
> +	SND_PCI_QUIRK(0x10ec, 0x0897, "UNIS H3C X500S", ALC897_FIXUP_UNIS_H3C_X500S),

Now I noticed that 10ec is a generic vendor id for Realtek, so it's
not really specific to your device.  It implies that your BIOS is
still not mature.

I'm fine to take the change for the model name, so that the workaround
can be added via model option, but rather avoid applying the quirk
from this SSID.

Note that there are already a few similar entries, but those are only
for the early reference boards.


thanks,

Takashi