Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230630100321.1951138-1-jstephan@baylibre.com> <20230630100321.1951138-5-jstephan@baylibre.com>
In-Reply-To: <20230630100321.1951138-5-jstephan@baylibre.com>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Sun, 2 Jul 2023 17:50:47 +0800
Message-ID: <CAAOTY_8z9YDrC6yJ80TUJQ6FmU6wQOdgGJ0eCN15gu0LYds0ig@mail.gmail.com>
Subject: Re: [PATCH v2 4/4] media: platform: mediatek: isp_30: add mediatek
 ISP3.0 camsv
To:     Julien Stephan <jstephan@baylibre.com>
Cc:     Phi-bang Nguyen <pnguyen@baylibre.com>,
        Florian Sylvestre <fsylvestre@baylibre.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Andy Hsieh <andy.hsieh@mediatek.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Conor Dooley <conor+dt@kernel.org>,
        daoyuan huang <daoyuan.huang@mediatek.com>,
        devicetree@vger.kernel.org,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org,
        Louis Kuo <louis.kuo@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Moudy Ho <moudy.ho@mediatek.com>,
        Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
        Rob Herring <robh+dt@kernel.org>,
        Vasily Gorbik <gor@linux.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Julien:

Julien Stephan <jstephan@baylibre.com> =E6=96=BC 2023=E5=B9=B46=E6=9C=8830=
=E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=886:06=E5=AF=AB=E9=81=93=EF=BC=
=9A
>
> From: Phi-bang Nguyen <pnguyen@baylibre.com>
>
> This driver provides a path to bypass the SoC ISP so that image data
> coming from the SENINF can go directly into memory without any image
> processing. This allows the use of an external ISP.
>
> Signed-off-by: Phi-bang Nguyen <pnguyen@baylibre.com>
> Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
> ---

[snip]

> +
> +static irqreturn_t isp_irq_camsv30(int irq, void *data)
> +{
> +       struct mtk_cam_dev *cam_dev =3D (struct mtk_cam_dev *)data;
> +       struct mtk_cam_dev_buffer *buf;
> +       unsigned long flags =3D 0;
> +       unsigned int irq_status;
> +
> +       spin_lock_irqsave(&cam_dev->irqlock, flags);
> +
> +       irq_status =3D mtk_camsv30_read(cam_dev, CAMSV_INT_STATUS);
> +
> +       if (irq_status & INT_ST_MASK_CAMSV_ERR) {
> +               dev_err(cam_dev->dev, "irq error 0x%x\n",
> +                       (unsigned int)(irq_status & INT_ST_MASK_CAMSV_ERR=
));
> +       }
> +
> +       /* De-queue frame */
> +       if (irq_status & CAMSV_IRQ_PASS1_DON) {
> +               cam_dev->sequence++;
> +
> +               if (!cam_dev->is_dummy_used) {
> +                       buf =3D list_first_entry_or_null(&cam_dev->buf_li=
st,
> +                                                      struct mtk_cam_dev=
_buffer,
> +                                                      list);
> +                       if (buf) {
> +                               buf->v4l2_buf.sequence =3D cam_dev->seque=
nce;
> +                               buf->v4l2_buf.vb2_buf.timestamp =3D ktime=
_get_ns();
> +                               vb2_buffer_done(&buf->v4l2_buf.vb2_buf,
> +                                               VB2_BUF_STATE_DONE);
> +                               list_del(&buf->list);
> +                       }
> +               }
> +
> +               if (list_empty(&cam_dev->buf_list)) {
> +                       (*cam_dev->hw_functions->mtk_cam_update_buffers_a=
dd)
> +                                               (cam_dev, &cam_dev->dummy=
);

It's not necessary to use function pointer. Call
mtk_camsv30_update_buffers_add() directly.

Regards,
Chun-Kuang.

> +                       cam_dev->is_dummy_used =3D true;
> +               } else {
> +                       buf =3D list_first_entry_or_null(&cam_dev->buf_li=
st,
> +                                                      struct mtk_cam_dev=
_buffer,
> +                                                      list);
> +                       (*cam_dev->hw_functions->mtk_cam_update_buffers_a=
dd)
> +                                               (cam_dev, buf);
> +                       cam_dev->is_dummy_used =3D false;
> +               }
> +       }
> +
> +       spin_unlock_irqrestore(&cam_dev->irqlock, flags);
> +
> +       return IRQ_HANDLED;
> +}
> +