Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CA+CX+bjcvbtW2Wto1XF1dKcAbpGGisdyHAGHX12v3TchhLbKtg@mail.gmail.com>
 <CAPDyKFoTH0j1uVSKvY_d7boMdG0kt_WvmLEKenYG22ZJR=UmvA@mail.gmail.com>
 <CAAd53p4NPr7t2ykOVLfjRRSiO5oatMu-Kx6p=O=cTn239XY+Vw@mail.gmail.com>
 <CA+CX+bjit+BsLNWn1Oh0HYjJYratcUTnoEQri4M_BiKbdVn2yA@mail.gmail.com> <CAAd53p7_RbZDA=VgMQJtC23K0-WqteJH=cmC2WQMY1hAzC7bSQ@mail.gmail.com>
In-Reply-To: <CAAd53p7_RbZDA=VgMQJtC23K0-WqteJH=cmC2WQMY1hAzC7bSQ@mail.gmail.com>
From:   Pascal Terjan <pterjan@gmail.com>
Date:   Sun, 2 Jul 2023 12:49:25 +0100
Message-ID: <CA+CX+bhMz0kUm0E=nNETstkHfaFUOurgKJV_mhFhDqqMafJRJA@mail.gmail.com>
Subject: Re: rtsx_usb_sdmmc not detecting card insertion anymore
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     Ulf Hansson <ulf.hansson@linaro.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-mmc@vger.kernel.org, Ricky WU <ricky_wu@realtek.com>,
        Oleksandr Natalenko <oleksandr@natalenko.name>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 28 Jun 2023 at 02:21, Kai-Heng Feng <kai.heng.feng@canonical.com> w=
rote:
>
> On Wed, Jun 28, 2023 at 4:29=E2=80=AFAM Pascal Terjan <pterjan@gmail.com>=
 wrote:
> >
> > On Tue, 27 Jun 2023 at 14:23, Kai-Heng Feng <kai.heng.feng@canonical.co=
m> wrote:
> > >
> > > On Tue, Jun 27, 2023 at 7:01=E2=80=AFPM Ulf Hansson <ulf.hansson@lina=
ro.org> wrote:
> > > >
> > > > + Ricky WU, Kai Heng Feng, Oleksandr Natalenko
> > > >
> > > > On Sat, 24 Jun 2023 at 22:39, Pascal Terjan <pterjan@gmail.com> wro=
te:
> > > > >
> > > > > Hi,
> > > > > I have an ASUS PN50 machine with a 0bda:0129 card reader. The car=
d is
> > > > > not seen unless I reload the rtsx_usb_sdmmc module.
> > > >
> > > > Thanks for reporting, let's see how we can move this forward.
> > > >
> > > > I have looped in some of the people that has been involved in the
> > > > relevant changes for rtsx_usb. Let's see if they can help too.
> > > >
> > > > >
> > > > > I found a Debian bug report for the same regression
> > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D993068 but no=
thing
> > > > > to see there.
> > > > >
> > > > > Trying to understand things I found
> > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi=
t/commit/?id=3D4dad599b8b5d1ffc5ef12a2edb13d15d537202ba
> > > > > which seemed related, so I first tried to revert it and that work=
ed.
> > > >
> > > > Okay! That's certainly good information. Are you willing to help
> > > > running further debug testings?
> > > >
> > > > Unless I mistaken, I think we should avoid doing a plain revert
> > > > (assuming we can find another option) as it will cause us to waste =
a
> > > > lot of energy instead.
> > > >
> > > > >
> > > > > Assuming the description is correct and the rtsx USB driver runti=
me
> > > > > resumes the rtsx_usb_sdmmc device when it detects that a new card=
 has
> > > > > been inserted, I assume this means it doesn't detect that a card =
was
> > > > > inserted and the problem would be in rtsx_usb rather than
> > > > > rtsx_usb_sdmmc.
> > > >
> > > > There is also another interesting commit, which was also part of th=
e
> > > > re-work of the rtsx_usb_sdmmc driver that you pointed to above.
> > > >
> > > > commit 883a87ddf2f1 (misc: rtsx_usb: Use USB remote wakeup signalin=
g
> > > > for card insertion detection")
> > > >
> > > > >
> > > > > I am not sure how to debug this further, usbmon doesn't see anyth=
ing
> > > > > when I insert the card.
> > > >
> > > > If you are willing to run some tests, I suggest to add some debug p=
rints in:
> > > > drivers/mmc/host/rtsx_usb_sdmmc.c
> > > >   sdmmc_get_cd()
> > > >   rtsx_usb_sdmmc_runtime_resume()
> > > >   rtsx_usb_sdmmc_runtime_suspend()
> > > >
> > > > sdmmc_get_cd() should be returning 1 when it finds that there is ca=
rd
> > > > inserted, but of course the error path would be interesting too.
> > > >
> > > > rtsx_usb_sdmmc_runtime_resume() may be called during probing of the
> > > > rtsx_usb_sdmmc driver. Beyond that point, it should also be called
> > > > when you insert an SD card. Just having a debug print in there shou=
ld
> > > > help answer if that actually happens.
> > >
> > > Adding kernel parameter "usbcore.dyndbg" can also help, it will print
> > > out what's going on at USB side.
> >
> > Nothing happens for that device (4-4), I only get others (1, 2, 3, 5,
> > 7) waking up repeatedly:
>
> Interesting. Waking up repeatedly may be the root cause.
>
> Is it possible to file a bug at bugzilla and attach full dmesg?

Sorry for the delay, here it is
https://bugzilla.kernel.org/show_bug.cgi?id=3D217625