Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
In-Reply-To: <20230701055556.23632-1-machel@vivo.com>
References: <20230701055556.23632-1-machel@vivo.com>
From:   Namjae Jeon <linkinjeon@kernel.org>
Date:   Sun, 2 Jul 2023 21:51:08 +0900
Message-ID: <CAKYAXd_1MwLxrTRCj3e=p7MO+zyv16-NGKaK1Bjj-AfcYghx7g@mail.gmail.com>
Subject: Re: [PATCH v1] fs:smb:Fix unsigned expression compared with zero
To:     Wang Ming <machel@vivo.com>, Lu Hongfei <luhongfei@vivo.com>
Cc:     Steve French <sfrench@samba.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Tom Talpey <tom@talpey.com>, linux-cifs@vger.kernel.org,
        linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2023-07-01 14:55 GMT+09:00, Wang Ming <machel@vivo.com>:
> The return value of the ksmbd_vfs_getcasexattr() is long.
> However, the return value is being assigned to an unsignef
> long variable 'v_len',so making 'v_len' to long. Also, when
> comparing to zero in the following code, no type conversion
> is required.
>
> silence the warning:
> ./fs/smb/server/vfs.c:WARNING: Unsigned expression compared
> with zero: v_len > 0
>
> Signed-off-by: Wang Ming <machel@vivo.com>
I have previously pointed out that we can not apply your patch.
It still has issues and can't apply. The patch sent by your
colleague(Lu Hongfei) applied without problems. Ask him for help on
what's wrong.

Please check the warnings from checkpatch.pl.

ERROR: patch seems to be corrupt (line wrapped?)
#114: FILE: fs/smb/server/vfs.c:411:
, char *buf, loff_t *pos,

WARNING: please, no spaces at the start of a line
#119: FILE: fs/smb/server/vfs.c:415:
+       size_t size;$

WARNING: please, no spaces at the start of a line
#120: FILE: fs/smb/server/vfs.c:416:
+       ssize_t v_len;$

WARNING: please, no spaces at the start of a line
#130: FILE: fs/smb/server/vfs.c:433:
+       if (v_len < 0) {$

WARNING: suspect code indent for conditional statements (7, 15)
#130: FILE: fs/smb/server/vfs.c:433:
+       if (v_len < 0) {
                pr_err("not found stream in xattr : %zd\n", v_len);

ERROR: code indent should use tabs where possible
#133: FILE: fs/smb/server/vfs.c:435:
+               err =3D3D v_len;$

WARNING: please, no spaces at the start of a line
#133: FILE: fs/smb/server/vfs.c:435:
+               err =3D3D v_len;$

ERROR: spaces required around that '=3D' (ctx:WxV)
#133: FILE: fs/smb/server/vfs.c:435:
+               err =3D3D v_len;
                    ^

total: 3 errors, 5 warnings, 22 lines checked

> ---
>  fs/smb/server/vfs.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c
> index e35914457..e605ee96b 100644
> --- a/fs/smb/server/vfs.c
> +++ b/fs/smb/server/vfs.c
> @@ -412,7 +412,8 @@ static int ksmbd_vfs_stream_write(struct ksmbd_file *=
fp,
> char *buf, loff_t *pos,
>  {
>         char *stream_buf =3D NULL, *wbuf;
>         struct mnt_idmap *idmap =3D file_mnt_idmap(fp->filp);
> -       size_t size, v_len;
> +       size_t size;
> +       ssize_t v_len;
>         int err =3D 0;
>
>         ksmbd_debug(VFS, "write stream data pos : %llu, count : %zd\n",
> @@ -429,9 +430,9 @@ static int ksmbd_vfs_stream_write(struct ksmbd_file *=
fp,
> char *buf, loff_t *pos,
>                                        fp->stream.name,
>                                        fp->stream.size,
>                                        &stream_buf);
> -       if ((int)v_len < 0) {
> +       if (v_len < 0) {
>                 pr_err("not found stream in xattr : %zd\n", v_len);
> -               err =3D (int)v_len;
> +               err =3D v_len;
>                 goto out;
>         }
>
> --
> 2.25.1
>
>
> ________________________________
> =E6=9C=AC=E9=82=AE=E4=BB=B6=E5=8F=8A=E5=85=B6=E9=99=84=E4=BB=B6=E5=86=85=
=E5=AE=B9=E5=8F=AF=E8=83=BD=E5=90=AB=E6=9C=89=E6=9C=BA=E5=AF=86=E5=92=8C/=
=E6=88=96=E9=9A=90=E7=A7=81=E4=BF=A1=E6=81=AF=EF=BC=8C=E4=BB=85=E4=BE=9B=E6=
=8C=87=E5=AE=9A=E4=B8=AA=E4=BA=BA=E6=88=96=E6=9C=BA=E6=9E=84=E4=BD=BF=E7=94=
=A8=E3=80=82=E8=8B=A5=E6=82=A8=E9=9D=9E=E5=8F=91=E4=BB=B6=E4=BA=BA=E6=8C=87=
=E5=AE=9A=E6=94=B6=E4=BB=B6=E4=BA=BA=E6=88=96=E5=85=B6=E4=BB=A3=E7=90=86=E4=
=BA=BA=EF=BC=8C=E8=AF=B7=E5=8B=BF=E4=BD=BF=E7=94=A8=E3=80=81=E4=BC=A0=E6=92=
=AD=E3=80=81=E5=A4=8D=E5=88=B6=E6=88=96=E5=AD=98=E5=82=A8=E6=AD=A4=E9=82=AE=
=E4=BB=B6=E4=B9=8B=E4=BB=BB=E4=BD=95=E5=86=85=E5=AE=B9=E6=88=96=E5=85=B6=E9=
=99=84=E4=BB=B6=E3=80=82=E5=A6=82=E6=82=A8=E8=AF=AF=E6=94=B6=E6=9C=AC=E9=82=
=AE=E4=BB=B6=EF=BC=8C=E8=AF=B7=E5=8D=B3=E4=BB=A5=E5=9B=9E=E5=A4=8D=E6=88=96=
=E7=94=B5=E8=AF=9D=E6=96=B9=E5=BC=8F=E9=80=9A=E7=9F=A5=E5=8F=91=E4=BB=B6=E4=
=BA=BA=EF=BC=8C=E5=B9=B6=E5=B0=86=E5=8E=9F=E5=A7=8B=E9=82=AE=E4=BB=B6=E3=80=
=81=E9=99=84=E4=BB=B6=E5=8F=8A=E5=85=B6=E6=89=80=E6=9C=89=E5=A4=8D=E6=9C=AC=
=E5=88=A0=E9=99=A4=E3=80=82=E8=B0=A2=E8=B0=A2=E3=80=82
> The contents of this message and any attachments may contain confidential
> and/or privileged information and are intended exclusively for the
> addressee(s). If you are not the intended recipient of this message or th=
eir
> agent, please note that any use, dissemination, copying, or storage of th=
is
> message or its attachments is not allowed. If you receive this message in
> error, please notify the sender by reply the message or phone and delete
> this message, any attachments and any copies immediately.
> Thank you
>