Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <50181937-19ea-ccca-057c-eb6931f4b2da@nvidia.com>
Date:   Sun, 2 Jul 2023 17:46:42 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v3 1/1] gro: decrease size of CB
From:   Gal Pressman <gal@nvidia.com>
To:     Richard Gobert <richardbgobert@gmail.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, aleksander.lobakin@intel.com,
        lixiaoyan@google.com, lucien.xin@gmail.com, alexanderduyck@fb.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230601160924.GA9194@debian> <20230601161407.GA9253@debian>
 <f83d79d6-f8d7-a229-941a-7d7427975160@nvidia.com>
 <20230629123559.GA12573@debian>
 <431d8445-9593-73df-d431-d5e76c9085cf@nvidia.com>
 <20230630153923.GA18237@debian>
 <fdc1d609-5604-f372-6e64-1ea971fabe84@nvidia.com>
Content-Language: en-US
In-Reply-To: <fdc1d609-5604-f372-6e64-1ea971fabe84@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N25TZGlVaVY3Z1o4cW8xekhVMUtHNEh4RkZ4V0NaVXdhRUE5djRoa1B5SU5R?=
 =?utf-8?B?VS9HSFNtSmpmY1RDK2hWYW5McHlieUhaZ3hka08xTTNoSTMzTzRoQ01wM3o4?=
 =?utf-8?B?WmkzQThnS3pnNzMrL0ZQVzBjZ0VzUStPODRxL05lc2xQU1JoeDRCeW9SNVRl?=
 =?utf-8?B?RkIxdm1MSjh3VGluZUY5VzQ5Z2hLdy8xQkdobFI2bXovU0xwMitlRmt0Wmtu?=
 =?utf-8?B?N1RXYmkrYW96Ynd2ckRweitnVnEzSmhRTkxONWtmd0pFLzJZSXRqVDh6andQ?=
 =?utf-8?B?aHlrejVVemZEcUI2L2NzT01Bb1MrNmlKMDVCR3cxZnY2c25jbG1uOERvQTVr?=
 =?utf-8?B?aENtam53S0x6WHRHYkh2dG5yRGZkSHFYOGdabHdBNVo1bnRWNi9MejJpRisx?=
 =?utf-8?B?Q1V4OXpkcTJwMTdQZndSZ2hONFZ4cGUxVUtaT01MdUJuTnRrdk1zOWtwQTE3?=
 =?utf-8?B?WlZ2MWlvYW9XNTl6bWVib0dxZk1JWXMzMFlNWE5yaWMyTHJaZWF2RVJWWG1D?=
 =?utf-8?B?VFJ0OWZQa21LbnhIYzJsZ2R2RkFDb0xIR1BOeWVWdDZmTnBqdEFZejZCblJY?=
 =?utf-8?B?WFhhMVU0cVMrUm5zN0dKUFJ5QmhZVnJFVUhJVHdzaGM5UHZDWVdnK3ZpZDBn?=
 =?utf-8?B?cHAvMmo5ZGI2OFA5L1daSXhVMUdlZ1I3ckRqenREam90SFo4TTE0SHF6ZWFQ?=
 =?utf-8?B?OGJTeGZaZi8zY1Y4ODBTUFVadmdhMWRDVDAzNDJJNHFobm8vcEJYNndHNDVy?=
 =?utf-8?B?emJPZ2xsS1BQTXA0eVk5T09na2kvLzVzdUk4SHRtT1VhOEoyMDh0WDZxYzVY?=
 =?utf-8?B?VXFJa1FzRlNlbjd2aUdsbWZWN1lUcThUTS9aRG5kYjVWNHpNMnFZeWlOa1Mr?=
 =?utf-8?B?dmpXc2pWdTV3VTF3K3B0Y0kzWVZEVjRwdi83VFdoQmxpKzhPSllxbGVvUmlj?=
 =?utf-8?B?LytwL2V5dC9ZbnFkVXNqQ0JaamM5NnBoSHh4VVB0bzdPWlhhWnhIdTlrSXY1?=
 =?utf-8?B?TUxCNUFtR1QrbG50WGhOb1JFTll2dk9qZW95ZmNXc012RGNGUllObDRZVlJo?=
 =?utf-8?B?KzA5dlF3VHJWbm52NEY3eXJWNzFxWHFTRlNRR2RYVUhrYnBXYWw1ZkVGNmUy?=
 =?utf-8?B?ZTQxRUdaem9ibElteFUwT25qRmhWQ3RZdVFPdDJ6a1NEaU1hZ2FnK2Mvb1pv?=
 =?utf-8?B?L0d1Q3R6VFd0SUFaWW8yVzA0SjFGR3RncVAyOFRaMXpXSkd1MWR0Q1dFd2Fy?=
 =?utf-8?B?c1hFOEVmMkRQTFl4WS93YXJlbFoxYmE4bFFyNEt1eXN5cit4MWVvSjgwVTE5?=
 =?utf-8?B?VUg1Z241eVkzVk9ZaWdCSytKOXR4ZGdMTVB2UDFsR0ZWMHFFNUxqN0tZTmpO?=
 =?utf-8?B?c0ZYMGJ2UFNrd1dZQ2RkUmhoNWlYVlVjRUV5T1ZtRklhMnR3aWwyaWlsL2Uz?=
 =?utf-8?B?aDFpTGxXK0ZMak9YcTBuc1ZaV0JIRTVkK2hRa0dRZ2RSZERnZnhGWHRsS1F4?=
 =?utf-8?B?UlNiZmkyOWE0UHQyVXRVTVdkMnlLcXpZeWdTYkx1YXRmc2hkM0JXaWZaM3Fw?=
 =?utf-8?B?WFloTU01d2JiRTljSFB5UkZmdGNHdUN3R000MUxFUTl5WDVGYUFrems4RC85?=
 =?utf-8?B?VVF2ODloN0xxZS9XLzIzUTlnZXdMczAzNTB0d0w1bmRKQlJDblJHbS9xYWZ2?=
 =?utf-8?B?bEJ1YmV6UHRoVG5CZ2FPcnlhbnk3cHpIdjJkZkdmOXVYbVVvNnBRRWJuQ0tV?=
 =?utf-8?B?V08zRGtyd01LMFl3ODN0aDFyeXpjQWVFbVkyeTZMNmZWQ051ay9ZVFBYeVZP?=
 =?utf-8?B?NlZYZ1haQ2dBa2xCeDhIQlI3TG10d1VTVnJvSGlzMlVoNXdVbnNMd2JhVExS?=
 =?utf-8?B?RlBiNU84N2hJcmpmQm9RajB6VmVnTm9KV0FNY0pTSW52R3pmRXB3dDZtTzRE?=
 =?utf-8?B?R1ZNdzBFazJ2SEtYaWZkVCt0VFkyQVNiRXcrYUNBUVNwUTV5QnV5azRqVHli?=
 =?utf-8?B?bnFGK1hBNlB2Z3pYRUljbjdEeWptaEZQQ2d6b2ZkWThkcmwvUFJ3U2V4WjQ4?=
 =?utf-8?B?NWhGYVp6NmsrZEV3amNnTk0vSFFpSi92SHRhNUw1aWVrY3UwdGV6ZnFTZUli?=
 =?utf-8?Q?ZoKe8y4v+vHtkRxtafg1XAN+Q?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fceea5b1-fbe6-4b4d-2543-08db7b0b2b03
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6288.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2023 14:46:50.1691
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jBs/9+B6kwV5l49ldvhEQXB/t48K0hhpTGOGTCnWMnVAlgOp0xUTimuVSthQlN5R
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9394
X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/07/2023 17:41, Gal Pressman wrote:
> On 30/06/2023 18:39, Richard Gobert wrote:
>> I haven't been able to reproduce it yet, I tried two different setups:
>>     - 2 VMs running locally on my PC, and a geneve interface for each. Over
>>       these geneve interfaces, I sent tcp traffic with a similar iperf
>>       command as yours.
>>     - A geneve tunnel over veth peers inside two separate namespaces as
>>       David suggested.
>>
>> The throughput looked fine and identical with and without my patch in both
>> setups.
>>
>> Although I did validate it while working on the patch, a problem may arise
>> from:
>>     - Packing CB members into a union, which could've led to some sort of
>>       corruption.
>>     - Calling `gro_pull_from_frag0` on the current skb before inserting it
>>       into `gro_list`.
>>
>> Could I ask you to run some tests:
>>     - Running the script I attached here on one machine and checking whether
>>       it reproduces the problem. 
>>     - Reverting part of my commit: 
>>         - Reverting the change to CB struct while keeping the changes to
>>           `gro_pull_from_frag0`.
>>         - Checking whether the regression remains.
>>
>> Also, could you give me some more details:
>>     - The VMs' NIC and driver. Are you using Qemu? 
>>     - iperf results.
>>     - The exact kernel versions (commit hashes) you are using.
>>     - Did you run the commands (sysctl/ethtool) on the receiving VM?
>>
>>
>> Here are the commands I used for the namespaces test's setup:
>> ```
>> ip netns add ns1
>>
>> ip link add veth0 type veth peer name veth1
>> ip link set veth1 netns ns1
>>
>> ip a add 192.168.1.1/32 dev veth0
>> ip link set veth0 up
>> ip r add 192.168.1.0/24 dev veth0
>>
>> ip netns exec ns1 ip a add 192.168.1.2/32 dev veth1
>> ip netns exec ns1 ip link set veth1 up
>> ip netns exec ns1 ip r add 192.168.1.0/24 dev veth1
>>
>> ip link add name gnv0 type geneve id 1000 remote 192.168.1.2
>> ip a add 10.0.0.1/32 dev gnv0
>> ip link set gnv0 up
>> ip r add 10.0.1.1/32 dev gnv0
>>
>> ip netns exec ns1 ip link add name gnv0 type geneve id 1000 remote 192.168.1.1
>> ip netns exec ns1 ip a add 10.0.1.1/32 dev gnv0
>> ip netns exec ns1 ip link set gnv0 up
>> ip netns exec ns1 ip r add 10.0.0.1/32 dev gnv0
>>
>> ethtool -K veth0 generic-receive-offload off
>> ip netns exec ns1 ethtool -K veth1 generic-receive-offload off
>>
>> # quick way to enable gro on veth devices
>> ethtool -K veth0 tcp-segmentation-offload off
>> ip netns exec ns1 ethtool -K veth1 tcp-segmentation-offload off
>> ```
>>
>> I'll continue looking into it on Monday. It would be great if someone from
>> your team can write a test that reproduces this issue.
>>
>> Thanks.
> 
> Hey,
> 
> I don't have an answer for all of your questions yet, but it turns out I
> left out an important detail, the issue reproduces when outer ipv6 is used.
> 
> I'm using ConnectX-6 Dx, with these scripts:
> 
> Server:
> ip addr add 194.236.5.246/16 dev eth2
> ip addr add ::12:236:5:246/96 dev eth2
> ip link set dev eth2 up
> 
> ip link add p1_g464 type geneve id 464 remote ::12:236:4:245
> ip link set dev p1_g464 up
> ip addr add 196.236.5.1/16 dev p1_g464
> 
> Client:
> ip addr add 194.236.4.245/16 dev eth2
> ip addr add ::12:236:4:245/96 dev eth2
> ip link set dev eth2 up
> 
> ip link add p0_g464 type geneve id 464 remote ::12:236:5:246
> ip link set dev p0_g464 up
> ip addr add 196.236.4.2/16 dev p0_g464
> 
> Once everything is set up, iperf -s on the server and
> iperf -c 196.236.5.1 -i1 -t1000
> On the client, should do the work.
> 
> Unfortunately, I haven't been able to reproduce the same issue with veth
> interfaces.
> 
> Reverting the napi_gro_cb part indeed resolves the issue.
> 
> Thanks for taking a look!

BTW, all testing is done after checking out to your commit:
7b355b76e2b3 ("gro: decrease size of CB")