Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Jul 2023 08:51:28 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Rob Herring <robherring2@gmail.com>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        Frank Rowand <frowand.list@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH] of: fix htmldocs build warnings
Message-ID: <20230703085128.3d8cbf0e@canb.auug.org.au>
In-Reply-To: <c5db0099-a7fd-8f1c-16ad-8388d3cf6a05@infradead.org>
References: <20230220163638.04e9d0c4@canb.auug.org.au>
        <20230310113258.463f836c@canb.auug.org.au>
        <20230322180032.1badd132@canb.auug.org.au>
        <c5db0099-a7fd-8f1c-16ad-8388d3cf6a05@infradead.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/i4G9G7rZmlV77xksRQz4Qfn";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/i4G9G7rZmlV77xksRQz4Qfn
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Rob,

On Wed, 22 Mar 2023 11:50:53 -0700 Randy Dunlap <rdunlap@infradead.org> wro=
te:
>
> On 3/22/23 00:00, Stephen Rothwell wrote:
> > Fix these htmldoc build warnings:
> >=20
> > include/linux/of.h:115: warning: cannot understand function prototype: =
'const struct kobj_type of_node_ktype; '
> > include/linux/of.h:118: warning: Excess function parameter 'phandle_nam=
e' description in 'of_node_init'
> >=20
> > Reported by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Reported by: Randy Dunlap <rdunlap@infradead.org>
> > Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node c=
reation functions")
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> =20
>=20
>=20
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
>=20
> Thanks.
>=20
> > ---
> >  include/linux/of.h | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >=20
> > Replaces "[PATCH] of: fix htmldocs build warning" and additionally
> > fixes the new warning about phandle that Randy reported.
> >=20
> > diff --git a/include/linux/of.h b/include/linux/of.h
> > index 9b7a99499ef3..d55dab9ad728 100644
> > --- a/include/linux/of.h
> > +++ b/include/linux/of.h
> > @@ -100,10 +100,12 @@ struct of_reconfig_data {
> >  	struct property		*old_prop;
> >  };
> > =20
> > +extern const struct kobj_type of_node_ktype;
> > +extern const struct fwnode_operations of_fwnode_ops;
> > +
> >  /**
> >   * of_node_init - initialize a devicetree node
> >   * @node: Pointer to device node that has been created by kzalloc()
> > - * @phandle_name: Name of property holding a phandle value
> >   *
> >   * On return the device_node refcount is set to one.  Use of_node_put()
> >   * on @node when done to free the memory allocated for it.  If the node
> > @@ -111,9 +113,6 @@ struct of_reconfig_data {
> >   * whether to free the memory will be done by node->release(), which is
> >   * of_node_release().
> >   */
> > -/* initialize a node */
> > -extern const struct kobj_type of_node_ktype;
> > -extern const struct fwnode_operations of_fwnode_ops;
> >  static inline void of_node_init(struct device_node *node)
> >  {
> >  #if defined(CONFIG_OF_KOBJ) =20

I am still getting the above warnings :-(
--=20
Cheers,
Stephen Rothwell

--Sig_/i4G9G7rZmlV77xksRQz4Qfn
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmSh/3AACgkQAVBC80lX
0GwIpwf/aA4H4y8LTmzjdHcwtCNvdjPt77alVANDyuqLgIE6PsFWnhWsYfFxeuLL
WsbRtG75xhzwLUF629Ltmsjqm9V+cxwSrzSZ5009PLPMqMsie619wCf1dcAzopL+
UkyKbxD9VaSo5G8jHltvu+HrVh4BHuQfwrFSETkDkKTS20y/Gsd34X0bh8TFeXak
2ZmMAn2W4t0/UpJqKTDy1syZeJ7b/yvVEQ2nHhhzsMsEucOGPTZ8xerS5JaxAu5N
OwAj9UAJWSGjdHcQyZlPc9weIOH3YMPAULzW3XYBLaBM+lElC/RpzMO8uAac6MED
ziGAHPNi5FRxYdmJDPadjMS627AZtg==
=0ORD
-----END PGP SIGNATURE-----

--Sig_/i4G9G7rZmlV77xksRQz4Qfn--