Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Marge Yang <Marge.Yang@tw.synaptics.com>
To:     Andi Shyti <andi.shyti@kernel.org>,
        Marge Yang <Marge.Yang@tw.synaptics.com>
CC:     "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        David Chiu <David.Chiu@tw.synaptics.com>,
        Derek Cheng <derek.cheng@tw.synaptics.com>,
        Sam Tsai <Sam.Tsai@synaptics.com>,
        Vincent Huang <Vincent.huang@tw.synaptics.com>
Subject: RE: [PATCH V2] Input: synaptics-rmi4- Add a new feature for Forepad.
Thread-Topic: [PATCH V2] Input: synaptics-rmi4- Add a new feature for Forepad.
Thread-Index: AQHZnNVd24wMbjxTzEiZuXJ/Dr71X6+JN0SAgB5A3tA=
Date:   Mon, 3 Jul 2023 02:49:50 +0000
Message-ID: <MW4PR03MB6651FF948B63B6FB209DA2C6A329A@MW4PR03MB6651.namprd03.prod.outlook.com>
References: <20230612022607.315149-1-marge.yang@tw.synaptics.com>
 <20230613204855.bm4wxneamkd76heq@intel.intel>
In-Reply-To: <20230613204855.bm4wxneamkd76heq@intel.intel>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fNRT4KPmnyk/qoG4h97oEwO2+g9j8FwxRxPSy/ryRLcE2I/CjrLV6gBKR9II?=
 =?us-ascii?Q?8/YvjcheHJDMMrMm97PijVQCS/B7dUK1D91Ewx6K1cvtsQ6V3zhWWw5Vo1VV?=
 =?us-ascii?Q?TeA+x2waoq/YbiLtQpR/32xcKJIJ/mLRCOFcHf2UyPqG1ZO98BARVE+Ur9No?=
 =?us-ascii?Q?ysglB5alVjncXhbsZhId7V7zjk7L6Com0Z+LJs1w1rDOfJL83Bo8iLp0pQzr?=
 =?us-ascii?Q?X+kaT5gt7EpaayrLpnqZkoumCMHqxaI7/hxfrBXVOYPUioRcD7F48zKqm/x5?=
 =?us-ascii?Q?I7tzBWgT0Gun99DOBHfK/Ra5ONxaIKgbJIQuNtnCn7lCyl39pt6UYXi33iqz?=
 =?us-ascii?Q?MK6EjPzzUeWu7dKQ7ggW61IgTm4a+Ea6awshRpKUiB7IZ+kWRGwC9onZ7AiU?=
 =?us-ascii?Q?e9ecUHZdmscbHw96mv68KheioGMFtdGXVnVPYZ++6JC5jBouMhO7MjrumZYG?=
 =?us-ascii?Q?aDIlVUf8tNzoY6CclPlkn6LZsa1KHDS0lqQ6POuKwOIZMvfjb1ujieFcIZVC?=
 =?us-ascii?Q?GJger7Szcp9f1LN15j8rmufwBQ2GOE2jYrOdvCbISP1775cZZi5kZNI3VrWc?=
 =?us-ascii?Q?oA8SokFDuxXWeeP2K6FUF4VLZOQVL9se4hI8lU1v5tCnbFxol3j/9phrfv0B?=
 =?us-ascii?Q?VD7XbAf4m84Tr84Vb2uuqXuvCCvCGKoMxayy9RsneAF5reLUJ4wqUQlfaiPd?=
 =?us-ascii?Q?Oz17ue4F3G+5qmHkaaw9dG7XbV+LxI+Bbv+u/AJF3ui01QxXrJ1tMZx+yez6?=
 =?us-ascii?Q?n5so7U3tFIFAb3ak4ascBiMBYCVjRQ2N50vkPS90EJpfi6J9/AqTF6sCLaXO?=
 =?us-ascii?Q?q/DRBU6vddnUump/Zl1Jnl5jaGfAeX6alDb/XTqLC53OR44ZzuBwb9LnV4e2?=
 =?us-ascii?Q?ADxysEQ7wdYvEBMReK/4TQkcLIidqCaOgcBT2ZzfvNPsLqruAieb0iCwQ8aB?=
 =?us-ascii?Q?tmCrezGsh0PiP7N3aQUZR6xY2i16nqNT6RN6lstoJkUErdQsdawbRXa2HMMU?=
 =?us-ascii?Q?/qSIPBnXE9zQEtn9oqxXhaENQCJuXBB021RnNPnEwIXALZG0D3vxoomB0TV5?=
 =?us-ascii?Q?4DWydP7+qsCEbbn+njFn6qsZ0pTaSg7q4yebld+cpdLZ8H714aLnmwRYfg2H?=
 =?us-ascii?Q?LV9N0jb6sGu+h5/xdN2lLY5YYmMm6HIR+U1GgXyRD7/MUq933AO780r2Aptv?=
 =?us-ascii?Q?bny2Ws5+hFGi82mHQsxhG6bpBrTGBRJ3RKzjtPaRlcVDRJ05HBQL7QhZYv7Z?=
 =?us-ascii?Q?tyr5HWkDpYfqzC1xrVIu3pod3DmBckrb1yDY4PvUyO8lwfpAPRsdMndb1SZU?=
 =?us-ascii?Q?BYfx4TIaMsOZKUL2qfMpyK0FvSyg1t4X5cdkKOIVNhhwdrw+Rc29jyDj/jW0?=
 =?us-ascii?Q?pnVDzSQqt0I7Ud4Sz/XUplg3zgIs/2sdvFnB8OdU1WzYTR82nwIGKjnjt1B2?=
 =?us-ascii?Q?zqH8wxAG7s8mqO7UbY/WOdZ7EcxreRPkvD+kAgZBbwMi/S9XXh6UsJrMUBOZ?=
 =?us-ascii?Q?EEyorovC9uCBqAnzUojTPDA7cmbAs9hjoiI0+3uOcESWW9DKAnBCYQ+WDzjW?=
 =?us-ascii?Q?Y7Qtc316ktHWBkWfSLs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: tw.synaptics.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6651.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49a00f08-3344-4937-5eac-08db7b702ba5
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2023 02:49:50.1311
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335d1fbc-2124-4173-9863-17e7051a2a0e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1AIR/RCO+CawE/zc3xXvsrUZ/Z0g6tJrYJAqBM2K6vX1FPP85jBV+FhKviYzEHZOF9um8v24smLv2/OnuUG6nQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5477
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andi,
	I have modified it and send PATCH V3.
Thanks
Marge Yang

-----Original Message-----
From: Andi Shyti <andi.shyti@kernel.org>=20
Sent: Wednesday, June 14, 2023 4:49 AM
To: Marge Yang <Marge.Yang@tw.synaptics.com>
Cc: dmitry.torokhov@gmail.com; linux-input@vger.kernel.org; linux-kernel@vg=
er.kernel.org; David Chiu <David.Chiu@tw.synaptics.com>; Derek Cheng <derek=
.cheng@tw.synaptics.com>; Sam Tsai <Sam.Tsai@synaptics.com>; Vincent Huang =
<Vincent.huang@tw.synaptics.com>
Subject: Re: [PATCH V2] Input: synaptics-rmi4- Add a new feature for Forepa=
d.

CAUTION: Email originated externally, do not click links or open attachment=
s unless you recognize the sender and know the content is safe.


Hi Marge,

[...]

> +static irqreturn_t rmi_f21_attention(int irq, void *ctx) {
> +     struct rmi_function *fn =3D ctx;
> +     struct f21_data *f21 =3D dev_get_drvdata(&fn->dev);
> +     int error;
> +
> +     error =3D rmi_read_block(fn->rmi_dev,
> +                             fn->fd.data_base_addr+RMI_F21_FORCE_CLICK_O=
FFSET,
> +                             f21->data_regs, 1);
> +     if (error) {
> +             dev_err(&fn->dev,
> +                     "%s: Failed to read f21 data registers: %d\n",
> +                     __func__, error);
> +             return IRQ_RETVAL(error);
> +     }
> +
> +     if (!!(f21->data_regs[0] & RMI_f21_FORCE_CLICK))

no need for double negation here.

Andi

> +             input_report_key(f21->input, f21->key_code, true);
> +     else
> +             input_report_key(f21->input, f21->key_code, false);
> +     return IRQ_HANDLED;
> +}