Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp25675914rwd; Sun, 2 Jul 2023 22:41:26 -0700 (PDT) X-Google-Smtp-Source: APBJJlEapBoZ0sYaG3QnGg1hF5PB842yBuJso1pmL17L5avz5WbclhnK7+5CrAMPfgsn/dfLrw8E X-Received: by 2002:a05:6359:a21:b0:133:b86:cbef with SMTP id el33-20020a0563590a2100b001330b86cbefmr5287935rwb.5.1688362886341; Sun, 02 Jul 2023 22:41:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688362886; cv=none; d=google.com; s=arc-20160816; b=rM6kkWXToAOJN4V2595GoqbzJcMfK7z3dYJ2apln5bfbfB11dDkuBI7IIJJSuTpYZO USRbSEnefDZNBs1Bf053Jt18U8mQVTXemnAw6VnHxEM43PTMHq18Rhjq82NAJuBObd31 io/+y4NXvTXRFxyeME9530xWKAP8ITMo7a9QzG/f1WDPoqkbLlZIT+iWhGNdaxoAzYSj 1pUBL09yam5GtzFT++s9jow5dOtJ0adVJ35fUdLxetVDOjZuvwCyWjydvwhewFn6ozdM LWpiwrYu3CSYTJQXppLABgOaL+s1USosC3N5cZIP4A4mZR5N3S1MI7E5+5Vo7+4RLQ6m yrsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=+ymc/7kr1pnJkCYIfIi9KhN7z8WWHgYWadSsjAEGm7w=; fh=IR91BQ3BTLGB+0AI4Bc2xTyey5jdWHvJZTUP1W3El1o=; b=Gv23QayTnn3DifsWlKRPWYfNL/JeAF3xArjipG8jZUrRl4SzsTbmSRAn/+kfolwCC6 2HzvK9Ah+ZFJLaike57ZbD3tzzUeSKz04EiETe39R5YwL3zUVhSrm8uQduAvKRCXLUdp 6OsuW+ixHuDTPLvgQVFzsqByc9MxYpRSln2lLdknVm5FD3TrKfrxNfJhE1+R84TXtHtx seNn1Yc5NHcR3STRxiLX1WOshYZ62tGjPnIVRv0qQ3kGsuUNMG74TaXd9mVdaJRuuwFt a7wZV2OZh9o8cnUqZ7Y9wBjcQGHShQ/0td8zx6h8DZFUVwjjB8a4CPixEFLUX8pE3PFW JwYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id az9-20020a056a02004900b0055b731aa9adsi5565058pgb.562.2023.07.02.22.41.11; Sun, 02 Jul 2023 22:41:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230033AbjGCFeq (ORCPT + 99 others); Mon, 3 Jul 2023 01:34:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbjGCFee (ORCPT ); Mon, 3 Jul 2023 01:34:34 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E44881B7 for ; Sun, 2 Jul 2023 22:34:33 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4QvZP44WYcz4wxn; Mon, 3 Jul 2023 15:34:32 +1000 (AEST) From: Michael Ellerman To: Nicholas Piggin , Christophe Leroy Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org In-Reply-To: <7e469c8f01860a69c1ada3ca6a5e2aa65f0f74b2.1685955220.git.christophe.leroy@csgroup.eu> References: <7e469c8f01860a69c1ada3ca6a5e2aa65f0f74b2.1685955220.git.christophe.leroy@csgroup.eu> Subject: Re: [PATCH] powerpc/signal32: Force inlining of __unsafe_save_user_regs() and save_tm_user_regs_unsafe() Message-Id: <168836201884.50010.14478880824891760898.b4-ty@ellerman.id.au> Date: Mon, 03 Jul 2023 15:26:58 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 05 Jun 2023 10:58:35 +0200, Christophe Leroy wrote: > Looking at generated code for handle_signal32() shows calls to a > function called __unsafe_save_user_regs.constprop.0 while user access > is open. > > And that __unsafe_save_user_regs.constprop.0 function has two nops at > the begining, allowing it to be traced, which is unexpected during > user access open window. > > [...] Applied to powerpc/next. [1/1] powerpc/signal32: Force inlining of __unsafe_save_user_regs() and save_tm_user_regs_unsafe() https://git.kernel.org/powerpc/c/a03b1a0b19398a47489fdcef02ec19c2ba05a15d cheers