Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
        Sagi Grimberg <sagi@grimberg.me>,
        Hannes Reinecke <hare@suse.de>,
        James Smart <jsmart2021@gmail.com>
Subject: Re: [PATCH blktests v2 0/3] More fixes for FC enabling
Thread-Topic: [PATCH blktests v2 0/3] More fixes for FC enabling
Thread-Index: AQHZrXE75p0D0BqGR0iZH+llokuVXg==
Date:   Mon, 3 Jul 2023 05:43:01 +0000
Message-ID: <aji2laz4lypl4lspduoeef4uviuoysl5rweu25zmzplj3psg7f@ryxrnjorfsr2>
References: <20230628151623.11340-1-dwagner@suse.de>
In-Reply-To: <20230628151623.11340-1-dwagner@suse.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?i8VoTBMC0pDr1VOHhQFUlXj49lViSGEuJY5uaR5Y4h8g8vhOzMzLg+wnZdhb?=
 =?us-ascii?Q?KYF6G4IEk/k3BXg7RKjvmL0b/boeBCh5xH73fjxrcCC/rPzch01zlOpTVERH?=
 =?us-ascii?Q?JUPFElaqu3FpQK1H5TqZApMF1en+dqlKRT9Xioi0LOX/MjAlPOzcAfa/1R0y?=
 =?us-ascii?Q?9Ft1p31EcSL77PIw6mDI/tjzMR0ks5GARm5qnKCzHQBUgdOR8mMO+PHXetVG?=
 =?us-ascii?Q?/PyXgMqSmiKf2zFfAtN6DxscOnry6+YH+G8LZav46xoEPu1tXNB1wPjUJWJv?=
 =?us-ascii?Q?PzK8nP8+W8QrwjVs9J/Da+XAth5d05hMt82216N9+SKcQTxjCq7LyTLthTaw?=
 =?us-ascii?Q?8VryM+wLNhBDuVTuOOK2xgZIM9xJ+VB4Tv9BwKCP/tnBA8P1RHO/JJLHrPyL?=
 =?us-ascii?Q?7f3WsE5j13lzM1D5ZA76erOClFacIrykjU61+iUYDlKvko3kCTwW71SHYUGf?=
 =?us-ascii?Q?RcNGI09hKvojVjPZTmpwlru4lRDZ7ON+gMbJ2R9MH/7c40x+LJwg9Ffz2hzK?=
 =?us-ascii?Q?6tk8akiCHvmA2AVixPI+et5Z9SkKoRd2Wuzi7sDdK4EweuIdDD9/W0CsH663?=
 =?us-ascii?Q?4DK6vfp6RhCGUbdWKX1a51wYI1ti8gjeZhlF0Kp+l/NroGG1uc2x1XkPBkvU?=
 =?us-ascii?Q?bbwGFsXFT10jtcyK7hdTp+5MuddaRpJbOBHPJhnGytCnVaiAK8jXhxLToFZz?=
 =?us-ascii?Q?KrqwFRZY2IbtPnsSqT9iCloPF9IUBfiA3c7BqKRtbNQkWsVT4oDLft+4wyEZ?=
 =?us-ascii?Q?tXdZdyI/c8RQGCPFzZI2Zj/W0nfYxoQryGhkq5/JT14/9z+iMtTfmWs132pO?=
 =?us-ascii?Q?2D5nNC3NBDt+qpz2DdvVI6ZJg5jsBzPPwN5LpG84ZGAhFXWTO2bcTO1ZTgbg?=
 =?us-ascii?Q?VH2CzyMek9g3GqXYd0aoyiOWDajoJeyoGKpF/39uGBAnzibyQAwvyVUZOolv?=
 =?us-ascii?Q?fDUg3L5XQFKN6tSQskKDW6Taji+/9NXXpcvt1BulJaHYulqQgbCSSgeanru3?=
 =?us-ascii?Q?o2rMfBnmb+CmSkWo2Da4sdhorUrjKaW/Bkv+rEYR3Aw0tUHWymUHWIp8C6hj?=
 =?us-ascii?Q?hrCCam5NeGSxI+tTO7mdplTf/6MloW3EMJkEmLN4tmU6la/N+mZL+8CZRrCY?=
 =?us-ascii?Q?trDJJPsRiJnnHAiwNWjrleS8g/0/iPEPYoQZz4AkdbD5DwLSgodg3wBO9vdb?=
 =?us-ascii?Q?KQJ53H1QfQpa1C5+u0f/q4uAxZmpXh29SrBR/XauBIRjB/N5JQGriF5YtA0j?=
 =?us-ascii?Q?n9c49WpMxWVd9pT8dNN77IF3ZhpO1p69prFfTH9Lgyq9TC4UGxOgroXERFXI?=
 =?us-ascii?Q?rS3A9HYYyhIG2q8TbbsnqUszgMoumJYaAO1qQ0lPC76ueBEXS5nN4h2HfsYr?=
 =?us-ascii?Q?rP6+4Uy2bCWsllGhikUtl8wP01eb9b6E9YvDT1VmPMiphLNt9TUCqqWNXJ8K?=
 =?us-ascii?Q?JXp3MPnz3zdplZsYv4s1UcfMpv4cobwuoK9nrPfEzNkc/0vkgVlzs6imEB7l?=
 =?us-ascii?Q?Z87UBOTz1AX5Nit8X7XFepsNkgTC2W7DYNLG7IfIh4OzXlVbt8IXpV7SN9zd?=
 =?us-ascii?Q?DUGMaB1Y7N1gUa0D1PLGizvpMIJeyCs7B/76OWbvmQNALlZXptlCXGzRaTqL?=
 =?us-ascii?Q?3ByVWmmRgNlrzBQyZKdi5HQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0D23FB7B6588844E89260FD0B9421607@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?Iw+NfWvacdY5aEttyoAJ4lDdv7Uf8M1S4l2Lo/Z9JS3+x06rjyV2/zO49mon?=
 =?us-ascii?Q?HXOnVHHEbwx/pdIco0mEVIdB8CNWmkk6DCEoh+DHioTsbdMYNZSqdO9Rizy+?=
 =?us-ascii?Q?twFrJq0ryX8zHLo+8LYXZt8K5nZh0dH6wcfkRYa9hh11qu73GraSZPX1V9Cp?=
 =?us-ascii?Q?QqIjg+4NmAo1EcaQXeiVVIRPzocVU7vwkFKLXeAv13CkrbbMV6ZoSkeVIsJE?=
 =?us-ascii?Q?eNnA/f9tZytKoTQMjKUB5PGdBSyxe0PtKpDElrR2vdKt4C6V4SJITtUTKYyn?=
 =?us-ascii?Q?5F+eZ4DDzDVmI1S2niMMk9qXHn4chTVqaEWbh8xuWaddHyH3NbkA99h8kIGC?=
 =?us-ascii?Q?OLYWUA/KjPXGI5qwK1RrGcNRSPwRJ12O8BQVjgsZWnN+P4VYB9n4N7zcNIt6?=
 =?us-ascii?Q?DA8XNvZttCehAWEIqw14D9pTXRj9+8KlvjmE9ccdQzfzQgl0FnYHIfPr3jWL?=
 =?us-ascii?Q?L23xwnROFKuCFy+X9mki+szf9m049OcySfP8X42NMUKf8lxr8To/wEeiPMtU?=
 =?us-ascii?Q?5MDWqghCytIWQGg5BYbEg5wr/j5+jnfMFTb8Zk+Ju84CkscrtBSJwxZ65wLB?=
 =?us-ascii?Q?+COjVJebLC3wLAg1viHdyrGC0cXbPvWDAblG6uQD8quGRZKQnuI4nv+F3TvF?=
 =?us-ascii?Q?AJjNSGbwjKYasfs9vnYt4vDvE3Kh1GXPTLSTpi27yPNhCw2OyOQRZ5MFcyuv?=
 =?us-ascii?Q?vyyeD7GMlv/8y20K0RRvWu59CiIjq0YCSvixMc45cpOs1tznGQlexCPopi5M?=
 =?us-ascii?Q?k39WEy8yiNHMivy25zO3xHZbVkaoiw+8ZFQ+o0WlPxlMjYhCdiEEwCSKx/Ye?=
 =?us-ascii?Q?8sXG/Zc446+C/C3wnG/mgIHmhBXFnPsxJch3pWYOcTVIJDuVU9BUBZULtlxZ?=
 =?us-ascii?Q?2RV2OsqQ2wVcoG0bz/8WQVZIRSCgvWWF94enqp1524eTLasnjnJCnMre/Pql?=
 =?us-ascii?Q?GaerbF/zs0r0JSFpPHD2x3OCDK5+yv7AErbbyyMLRBg=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b77ada1-4d4c-4449-61da-08db7b885da3
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2023 05:43:01.9768
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KeYTK4F3EshZhmC2YvNLq3Tkss+/G2jruQB6HBTpwdQ4kv8Ma+kwPkgLz4QR9wnMDb4YfuK6FySL54SoL236bZ/fZulVl9LwQevMyKg0KiA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR04MB6508
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Jun 28, 2023 / 17:16, Daniel Wagner wrote:
> I (think) address all the feedback I got from Sagi and Shinichiro except =
one.
> The _have_nvme_cli_context() (previously _nvme_cli_support_context()) fun=
ction
> is still there. I didn't find any other good way to achieve this and I fo=
und in
> blktests another function doing the same: _have_fio_zbd_zonemode().

I found that the latest blktests fix for the hostnqn/hostid issue created
conflict with the 2nd patch in this series. Sorry about that. (Actually, I =
guess
this series could be enough for the issue...)

Daniel, I can fix the conflict and repost the series to the list. Or you ca=
n fix
the conflict by yourself. Please let me know your preference.

Other than that, I think the three patches are good enough to apply.