Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Riwen Lu <luriwen@hotmail.com>
To:     jikos@kernel.org, benjamin.tissoires@redhat.com,
        dmitry.torokhov@gmail.com, linux@weissschuh.net,
        hdegoede@redhat.com, rrangel@chromium.org,
        u.kleine-koenig@pengutronix.de
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Riwen Lu <luriwen@kylinos.cn>
Subject: [PATCH v1] HID: i2c-hid: use print_hex_dump_debug to print report descriptor
Date:   Mon,  3 Jul 2023 14:01:00 +0800
Message-ID: <TYCP286MB260706B19C5E30EE2774784EB129A@TYCP286MB2607.JPNP286.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: TYCP286MB2607:EE_|TYCP286MB3500:EE_
X-MS-Office365-Filtering-Correlation-Id: 7c186320-a883-4999-eae5-08db7b8ae662
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: wCnaTCq/aGWwY32hIKIkVR4twvXcakOg4mWqT9nVq+JcFn8HJVZ08CmMSTdul7ppvac2cz5p5snubSjdL/P6ggiU9CDrt0uuhZ4nPRbvlat0mW+Ya7RTahL3Z+byPjfhkJ6yE8EMjgEwDBifxDWXeNgzrBi+CJZR8iknY12FpsPrOalH60gbCAOomPRZUF5Z23QauvHqtk3i4jYklO4fkLJc0OvC1PpyJkmdkK1eFv+ZQ08fdoq0eVlLwmfj74YWZU97p3w2Jde/qr09nuyiGZ7BcQW1Gt5q9UGE9nhxtGGheVny1oEcTgLPV4WqxV9l6/u6MRea/v8wql46fUbgw5h79kD7QFuLDG4aUZl44JofdOqcWsO+L2yKgnEeGxaDYbugo4hwGxzVG7/TQa4m+t/UuByOVSDGOtDsuKDaBgzdB5YV7nsKoLvtYbVVX0m83hrsX11C02AukQC6LnqimmTaNWFnyZw6jnQwgynMLrOHdD9l9grztz8DD+nwyEhg1SYY5150LDUUPcD0dnew+lTzK5CjS5x/AajNlGXGqFttcP4Yk+0Si4PQwfPZBCfj
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pfO8D5Ylc+Ob+jvq8QKLk4ueJvCQ+X+aPhsoOtYQW3JgFcQSl0dSIY3pRcM/?=
 =?us-ascii?Q?uiD2nlCA3KPZucIDLMsi3iYsWNYrOCQT0BLFL9SqS4eTsdAzBcrj8qxNE+Ha?=
 =?us-ascii?Q?d2tERId0D4gPgZa1AwUO3dXZkiZD9QNmB+9AyrKa5TH9tz0ABpsJk6o1r3y3?=
 =?us-ascii?Q?veRAinsEtaSmCZYX7e18M+rVxFS0rNSqcZrxjAbQZkMzeS9bWMCepNge9fdw?=
 =?us-ascii?Q?6383ipOGbNdS305kRewCuqfs95ktA0NOB0K97tKd23nm29BGcgGg0ZsqCuIv?=
 =?us-ascii?Q?ZZYsSAHTDgWuUoV29V8xSEA/m+tsKpsVvfpGB1KXoqrxEY2idlPmOMV0hUuf?=
 =?us-ascii?Q?FUycqbsKKNPth3cTLVQVnLc8hvwReA9phm/ikD0UMxDvIN8Ot7XbK6O3GppZ?=
 =?us-ascii?Q?xzqjCS0hbgOfpXFshj79/MLE/E/glcorSwGeQTlED0MIPLI54CPaDPleNnkB?=
 =?us-ascii?Q?icmsyWk3cCXRoQkI8PxUK6pgNkGFEIjwvs5z8BlFEiw+nMXNWyGMetrZnoc0?=
 =?us-ascii?Q?9EwQTivRKN26uGM1YF1QDzKgC2kT/E8QBZqhOZ+IBJMQV/iMad87baiQLqwt?=
 =?us-ascii?Q?hqFHcSp7cFKePe6mI/MDRjJravbsWGGVfEIFTUbwia18nBR1dOEsnWx6EUNG?=
 =?us-ascii?Q?DcELEfV/h6NAc1sVnSJcJ7/NIFfVRsUdS0aIT6khQWT20WIaxeRTtAdUgD6P?=
 =?us-ascii?Q?GsObG/rkT+GwY7sNdmC6qzCzxrHmRooCMVJwB3UDPQsjbmqb6bWGx52i98zL?=
 =?us-ascii?Q?44lff/cl/FT3aaPfCW//6hJqyA3rR4pdlpg5UDwHjU3R+iQBd+pP5IrBQ9fi?=
 =?us-ascii?Q?zNpWnyMqZ3povLd3hacTyDC2eaIxzKb4XGvDoolkFH4U9zsXxCZ4Xv7L/aT6?=
 =?us-ascii?Q?JO+VGjY8dkT3yxVOqo9WiqoYulloetniO9mQJgR51gHe5FuWv28eAkKnBjvv?=
 =?us-ascii?Q?NMoNKWji6XzV54JrdT1jrtepDRRaaYfC1OBB9ZJ2+SIunQP0ZNrRRSZXKnuP?=
 =?us-ascii?Q?yC5UjkoMTiPF7WF19OxP/jJIbV0ZC2NURdCHoLuniXpQWU6sGVMZX2pfze7H?=
 =?us-ascii?Q?lQsAlLrW0X0sY4lPFrRZFOIl8yaKr0R1j2XXhJGAUTN7z3LVLvGw+3UCMB5v?=
 =?us-ascii?Q?R+XfHE3CUF4sgJ851eFQvRkz/zij8QxtGB1/vpbH/j1EQZHuUNuWMEC3STG/?=
 =?us-ascii?Q?cDmtdQiEnZY1O8AvKNKBWPSifVAcUi4QFrl28A=3D=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c186320-a883-4999-eae5-08db7b8ae662
X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB2607.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 06:01:10.7751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB3500
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Riwen Lu <luriwen@kylinos.cn>

The format '%*ph' print up to 64 bytes long as a hex string with ' '
sepatator. Usually the size of report descriptor is larger than 64
bytes, so consider using print_hex_dump_debug to print out all of it for
better debugging.

Signed-off-by: Riwen Lu <luriwen@kylinos.cn>
---
 drivers/hid/i2c-hid/i2c-hid-core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index efbba0465eef..8e97fc01c852 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -772,7 +772,9 @@ static int i2c_hid_parse(struct hid_device *hid)
 		}
 	}
 
-	i2c_hid_dbg(ihid, "Report Descriptor: %*ph\n", rsize, rdesc);
+	i2c_hid_dbg(ihid, "Report Descriptor\n");
+	print_hex_dump_debug("  ", DUMP_PREFIX_OFFSET, 16, 1,
+			rdesc, rsize, false);
 
 	ret = hid_parse_report(hid, rdesc, rsize);
 	if (!use_override)
-- 
2.25.1