Date: Mon, 22 Oct 2007 11:21:10 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>, Al Viro <viro@ftp.linux.org.uk>,
       torvalds@linux-foundation.org, viro@zeniv.linux.org.uk,
       linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/2] irq_flags_t: intro and core annotations
Message-Id: <20071022112110.105b8e11.akpm@linux-foundation.org>
In-Reply-To: <20071022152912.GA841@linux-mips.org>
References: <20071020235546.GB1825@martell.zuzino.mipt.ru>
	<20071021005418.GU8181@ftp.linux.org.uk>
	<20071021093042.GA2144@martell.zuzino.mipt.ru>
	<20071022152912.GA841@linux-mips.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1109
Lines: 26

On Mon, 22 Oct 2007 16:29:12 +0100 Ralf Baechle <ralf@linux-mips.org> wrote:

> On Sun, Oct 21, 2007 at 01:30:42PM +0400, Alexey Dobriyan wrote:
> 
> > 			irq_flags_t
> > 	
> > New type for use with spin_lock_irqsave() and friends.
> 
> Talking about it, why did we ever require this to be a long anyway?  I could
> get away with a single bit for MIPS; the rest of this variable is pure
> bloat.  An abstract datatype could help finally fix this.
> 

Yes, it's always been ugly that we use unsigned long for this rather than
abstracting it properly.

However I'd prefer that we have some really good reason for introducing
irq_flags_t now.  Simply so that I don't needlessly spend the next two
years wrestling with literally thousands of convert-to-irq_flags_t patches
and having to type "please use irq_flags_t here" in hundreds of patch
reviews. (snivel, wimper)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/