Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Jingqi" <jingqi.liu@intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 0/5] iommu/vt-d: debugfs: Enhancements to IOMMU debugfs
Thread-Topic: [PATCH 0/5] iommu/vt-d: debugfs: Enhancements to IOMMU debugfs
Thread-Index: AQHZp3g/2UxT1hPuDU+fmpvlazmt86+nq2FQ
Date:   Mon, 3 Jul 2023 07:15:04 +0000
Message-ID: <BN9PR11MB5276885D6A142BC94D80C2618C29A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230625150442.42197-1-Jingqi.liu@intel.com>
In-Reply-To: <20230625150442.42197-1-Jingqi.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zOvKg6eSBwNXCefDcsPq3MVhF2KJfaTghlMNBaCznD9IuuhwTZCCkNK+m+Kl?=
 =?us-ascii?Q?YKFfzYbIP1YaluPFlpbG7hDIG1JbwBh46SrNLHR07lIKXplomQoDQZZGHPA4?=
 =?us-ascii?Q?avEZ7IdcPlc7+ppSBwzeKLbK0BEOpjFv1vs114W7OfuK2+vWbwrEDWY1YItc?=
 =?us-ascii?Q?VrlQVtHryf+h1IQYERxQyaJYVAHYq/TLrEVKwtHXewwNi7tnbE9YnZ7ZIWT7?=
 =?us-ascii?Q?bnT76qJCyYrDpQW0dZo8yTNXJtrwqgLnfEPNZrO2meWESTpyBvyx9DlfCr+k?=
 =?us-ascii?Q?JQqjKoGWT+kA2NJacNpUwlohD5EsZW/1qJHPnpG8u/iXntiWkl7tsmMTV/at?=
 =?us-ascii?Q?oeH94K+41ry7I+s/F20At4iimd+cLkJLAopC0JIzH1uXTS1aIVYsuA9AoL2E?=
 =?us-ascii?Q?5ZDhVuKSmxcT0hplrOBZvjKPgYQGDeadmSKR9mtXJveQ3/LMRkxWbgg0/li4?=
 =?us-ascii?Q?GtDHdHlwXPd6X2Oa59GyMqNrjUxnTt2MuszMy/Iek77gJvRNOZKrj9s5k4lJ?=
 =?us-ascii?Q?76O/P3fhYTgv2aHbjH1h8hnZdSqH4FqcZ+i8dDolSgi0XRn5SOJ2CUIDc0tA?=
 =?us-ascii?Q?mPEU4oTBfWvWS3xrL9e0tmlKA6eL5YqW08lNKBFwQNWr2LaCEq6mvv/B88fY?=
 =?us-ascii?Q?I4K8JlVzA498aToHLd5vPWFAuad/GVKJ3Ectx6H1uoiFGLJpwoSyxa7ZLhwQ?=
 =?us-ascii?Q?2x2vZqqStxvHTt0fWbCcxg0QOoOEICfHgC8XEk/NCkhxXV0JnZ7mxl91Wij9?=
 =?us-ascii?Q?aT3ox4t8pWG98u1kjU5pchd9eWqxDidINXu554BRKeUDTrDdkqoizaaeDEHl?=
 =?us-ascii?Q?FkOuz8mHACRhRyp+VIW9QWwBGdxXze1wL3D164FAz92/UOh/dcC+giBi+Fzr?=
 =?us-ascii?Q?BuQ2pEJKsosMdHbCzaL38EsNBxfoKGl3ZNjqmURYIKim1gobpLzjc8kssRfP?=
 =?us-ascii?Q?96YNpk1l2dWVqHKH0bfhrkyH2xknibf5R886leXotSIX8xLcAQwW7y+gJYHX?=
 =?us-ascii?Q?zFa5zrszmyTqhmT5MYukTTGetg4Lcmd8uO/N2gfK2nPHdaJm4KtDOpJ9Ed2G?=
 =?us-ascii?Q?usO+g16G0DZTZbUDIKzlRarqD0msAxfu9d8bFtI659km48m2n4s3GNd3b8ML?=
 =?us-ascii?Q?flpF8sX5zl27Y2S18CLsAZsrg1AGwAVZVy8PpVPE/22RpinjkRjMU9/GXzcK?=
 =?us-ascii?Q?bWwz9X7xH8xGjyt7uz+9vKBhu70V+sRtIzASbJEu+Ogp1CQtfirhGYu4mE63?=
 =?us-ascii?Q?TvhiNENcJFaKxeyQCbgMWlKd4W6AtQrro4m7QIL7WInxEN7B5aFOVKKbFaiF?=
 =?us-ascii?Q?Brz+7a7ReIZuHjkfCVKKJVhz7mZsa9ee+CROzcwZmiiJDMwkIIsVNqz9HVWO?=
 =?us-ascii?Q?xdq2eeG0WQ0PRC1L1A1GIG5Vy4Xs1NpIZ9DT8Bk1cEIc0IVYz0DZDD44oI5A?=
 =?us-ascii?Q?OmM9Yq2iqnKDFd+vl3tpKaqh18XN+OmBGz6M3ODwqIUrv7K1sxyoDv7wwzKf?=
 =?us-ascii?Q?PDpUJcbbofkrDhoHpp6vab9DbceSay3wCexfkv/LEe/wxKqDN7DOzVuXMxZC?=
 =?us-ascii?Q?9q1Ft8aonGp8CC467T9guE60KiokfTnYFP40/tAz?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3099e00-b67c-44df-5f5a-08db7b953968
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2023 07:15:04.6323
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: evqFxxRZxhsn4qIAOpmxjYz+hDY5DpAQ7cj5GcayalpaYxgasaDUw61ohkYYTcmiNqYhr9PecF+fZXgMsoHS1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5873
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Liu, Jingqi <jingqi.liu@intel.com>
> Sent: Sunday, June 25, 2023 11:05 PM
>=20
> The original debugfs only dumps all IOMMU page tables without pasid
> supported. It traverses all devices on the pci bus, then dumps all page
> tables based on device domains. This traversal is from software
> perspective.
>=20
> This series dumps page tables by traversing root tables, context tables,
> pasid directories and pasid tables from hardware perspective. By
> specifying source identifier and PASID, it supports dumping specified
> page table or all page tables in legacy mode or scalable mode.
>=20
> For a device that only supports legacy mode, specify the source
> identifier, and search the root table and context table to dump its
> page table. It does not support to specify PASID.
>=20
> For a device that supports scalable mode, specify a
> {source identifier, PASID} pair and search the root table, context table
> and pasid table to dump its page table.  If the pasid is not specified,
> it is set to RID_PASID.
>=20
> Switch to dump all page tables by specifying "auto".
>=20
> Examples are as follows:
> 1) Dump the page table of device "00:1f.0" that only supports legacy
> mode.
>=20
> $ sudo echo 00:1f.0 >
> /sys/kernel/debug/iommu/intel/domain_translation_struct
> $ sudo cat /sys/kernel/debug/iommu/intel/domain_translation_struct
> Device 0000:00:1f.0 @0x105407000
> IOVA_PFN                PML5E                   PML4E
> 0x0000000000000 |       0x0000000000000000      0x0000000105408003
> 0x0000000000001 |       0x0000000000000000      0x0000000105408003
> 0x0000000000002 |       0x0000000000000000      0x0000000105408003
> 0x0000000000003 |       0x0000000000000000      0x0000000105408003
>=20
> PDPE                    PDE                     PTE
> 0x0000000105409003      0x000000010540a003      0x0000000000000003
> 0x0000000105409003      0x000000010540a003      0x0000000000001003
> 0x0000000105409003      0x000000010540a003      0x0000000000002003
> 0x0000000105409003      0x000000010540a003      0x0000000000003003
>=20
> [...]
>=20
> 2) Dump the page table of device "00:0a.0" with pasid "2".
>=20
> $ sudo echo 00:0a.0,2 >
> /sys/kernel/debug/iommu/intel/domain_translation_struct
> $ sudo cat /sys/kernel/debug/iommu/intel/domain_translation_struct

What about creating a directory layout per {dev, pasid} so the user can
easily figure out and dump?

e.g.

/sys/kernel/debug/iommu/intel/00:0a.0/0/domain_translation_struct
/sys/kernel/debug/iommu/intel/00:0a.0/2/domain_translation_struct

> Device 0000:00:0a.0 with pasid 2 @0x1083d7000
> IOVA_PFN                PML5E                   PML4E
> 0x0000000000000 |       0x0000000000000000      0x0000000106aaa003
> 0x0000000000001 |       0x0000000000000000      0x0000000106aaa003
> 0x0000000000002 |       0x0000000000000000      0x0000000106aaa003
> 0x0000000000003 |       0x0000000000000000      0x0000000106aaa003
>=20
> PDPE                    PDE                     PTE
> 0x000000010a819003      0x000000010a7aa003      0x0000000129800003
> 0x000000010a819003      0x000000010a7aa003      0x0000000129801003
> 0x000000010a819003      0x000000010a7aa003      0x0000000129802003
> 0x000000010a819003      0x000000010a7aa003      0x0000000129803003
>=20
> [...]
>=20
> 3) Dump all page tables:
> $ sudo echo "auto" >
> /sys/kernel/debug/iommu/intel/domain_translation_struct
> $ sudo cat /sys/kernel/debug/iommu/intel/domain_translation_struct
> [...]
>=20
> Device 0000:00:02.0 @0x103072000
> IOVA_PFN                PML5E                   PML4E
> 0x000000008d800 |       0x0000000000000000      0x0000000103073003
> 0x000000008d801 |       0x0000000000000000      0x0000000103073003
>=20
> PDPE                    PDE                     PTE
> 0x0000000103074003      0x0000000103075003      0x000000008d800003
> 0x0000000103074003      0x0000000103075003      0x000000008d801003
>=20
> [...]
>=20
> Device 0000:00:0a.0 with pasid 2 @0x10a0b6000
> IOVA_PFN                PML5E                   PML4E
> 0x0000000000000 |       0x0000000000000000      0x00000001072d2003
> 0x0000000000001 |       0x0000000000000000      0x00000001072d2003
>=20
> PDPE                    PDE                     PTE
> 0x0000000107d6e003      0x00000001161d4003      0x00000001bdc00003
> 0x0000000107d6e003      0x00000001161d4003      0x00000001bdc01003
>=20
> [...]
>=20
> Thanks,
> Jingqi
>=20
> Jingqi Liu (5):
>   iommu/vt-d: debugfs: Define domain_translation_struct file ops
>   iommu/vt-d: debugfs: Support specifying source identifier and PASID
>   iommu/vt-d: debugfs: Dump the corresponding page table of a pasid
>   iommu/vt-d: debugfs: Support dumping a specified page table
>   iommu/vt-d: debugfs: Dump entry pointing to huge page
>=20
>  drivers/iommu/intel/debugfs.c | 361 ++++++++++++++++++++++++++++++----
>  1 file changed, 326 insertions(+), 35 deletions(-)
>=20
> --
> 2.21.3