Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Jul 2023 15:06:37 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Limonciello, Mario" <Mario.Limonciello@amd.com>
Cc:     "rafael@kernel.org" <rafael@kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Karny, Wyes" <Wyes.Karny@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>
Subject: Re: [PATCH] cpufreq: amd-pstate: Add sysfs file for base frequency
Message-ID: <ZKJzfbbMFRQO7xov@amd.com>
References: <20230629135454.177421-1-mario.limonciello@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230629135454.177421-1-mario.limonciello@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VRaIl0wtc2n5sI8VQBTvMdI1bFPdAVmddg3jtmDhG6ioZU036VsjM5m5OGO+?=
 =?us-ascii?Q?0xwOth8W/dYW8rtDKV1yDNyUcKBspCHsY62gF47vos4gwapBgUhQfeCvxPXZ?=
 =?us-ascii?Q?5CTXYzaAlFDoHgrBsqoEvP1UVoqfVOvCtAhU/dK0GhBMJ0FxOxXmUKzkJNAK?=
 =?us-ascii?Q?6n1Zn0I0ajLLtCFO5n/E+eGckhlfdI7bFpPuT1nISgD30qpWWtiZ00MRPclx?=
 =?us-ascii?Q?ukdx1oVuikTk6neVfsKVZxoxBMaYPHpQz8NA5VzJEOETHA2J2DUpUuCWcN10?=
 =?us-ascii?Q?bET/EjLQqSOBWD8+JoIWjIYzbQOhvsidrh/9+CqhAxFkXOn5F1NFAg9dqpdI?=
 =?us-ascii?Q?62avbs8+wRLB4l4+8LLp8oeCe6Ky1kY6vpasom1SbahG0jmYeZmmQNPmGyZv?=
 =?us-ascii?Q?MPjdGnkMkLrCRkMXmOoX6PpMuelr8uVXcW50nxr5ctJDBQR46+CLawAvAwqY?=
 =?us-ascii?Q?hzyf1u6b2eyLuP06lg0rYGe69wC3gihE3jWcgCYtSOpDF2dDw5xaqGzL0Qi7?=
 =?us-ascii?Q?iLjlYZYkLo719NeV56lV9GQTNdVORyc1jRwjk8pHtBBr0FrcSXOQj/t5hH7n?=
 =?us-ascii?Q?ko6+HgijnDhzL9lDEFi981J7F1QiwetGJxac0izXchW5Sdp5LZxFqWkTHwzD?=
 =?us-ascii?Q?ApLvWmaQHcVteF1VXTsCwObNclBPZpoDdmdUkFWma9/B8WgCQ+grbzE8csG2?=
 =?us-ascii?Q?NnIRDkbtYqfKaKyuP58ADTXmFFfl5sTG95DuZDD//qpN7LdnEF1Ov1RxfkIx?=
 =?us-ascii?Q?l7dHvDJfx6Tcax50rASf0m5ysbbzMwtF0Jq50Z8R9W8nuhNkWylLagtAJGSa?=
 =?us-ascii?Q?7tN5vKwaT4VbWIlrx5D+0npjZ12of1TaezcITRpyBaMP7uchmc74e/Y1jN42?=
 =?us-ascii?Q?9eT8FDjiPhk9XyNYEuz9MguPPfVNJ97i/W4dYe9HeSe9XHY04s+T7deSra7x?=
 =?us-ascii?Q?vg6wPqF9fFAtK0lUfmAWvXH3Afw8hi88UsjxWezBfdq5bVxh60+ZFPu23x+S?=
 =?us-ascii?Q?ErJIqJh8p6FJqDP2BjNg+hqmgY2yAYnyCMolTAdS1lEyIihcVHl+Kaw/u24/?=
 =?us-ascii?Q?BrbzugoXS2VJaqLydLfCwz/lcYpCNwMm00xrHQGfq6HwV5sYWT7SUQcimYlQ?=
 =?us-ascii?Q?7FqgwBh5A1XHlyg/2kSDIKTHi5oGyPofxUl8mYmx7TBYf4B6Bc83Ipy7dEAA?=
 =?us-ascii?Q?secjZxXPsSYxZVOJMi2onUHQbCcvHnbT6Z1GgWle+r4I9iUDSZ6xqpGYBVgN?=
 =?us-ascii?Q?OknYzDHxN+ckLPbn8wn8C6gCCxewkQw8+ahmXDHZHLglJLf7pjuESsFU87Zy?=
 =?us-ascii?Q?FhIID+D3QPIqxT4aHx240GgAlrYuDAklpUKHHsL5T4Qic9ooJ8RzKosczmYh?=
 =?us-ascii?Q?Fb+4EYsSVKjU/3iY5gpa1rIucYE5Iu1DnRn64khQxt7tfQDxS3dfaewsTKRA?=
 =?us-ascii?Q?tZSptUYPjPdIMo4ViDDYMaHVPEJnxxYoc7Btsu6Z5TZVE31OeM8/TWsI819s?=
 =?us-ascii?Q?NthO7ECaO1a8h/wXXDITRJRfXjAlSRGz+YP+MCCqjuIbQCdtqQpFtrj4xPHs?=
 =?us-ascii?Q?HypmsZutjpFPSL3jT9IEvbKHq/li9IFEZ3d9Lzbp?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 791a028f-9ccd-44f0-898e-08db7b941817
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 07:06:59.5093
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Cq+q6YRt+mqVcq9R5HmyD5XEyWjIur8h86iaOC+NTjCRsrQzWJh4RagU7NL9aZ/pC52v+i6y+ceKZ51bUp1Vdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5671
X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 29, 2023 at 09:54:54PM +0800, Limonciello, Mario wrote:
> Some applications may want to query the base frequency to tell when
> a processor is operating in boost.
> 
> Tested-by: Wyes Karny <wyes.karny@amd.com>
> Reviewed-by: Wyes Karny <wyes.karny@amd.com>
> Co-developed-by: Perry Yuan <perry.yuan@amd.com>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  Documentation/admin-guide/pm/amd-pstate.rst |  4 ++++
>  drivers/cpufreq/amd-pstate.c                | 15 +++++++++++++++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index 1cf40f69278cd..e68267857e859 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -281,6 +281,10 @@ integer values defined between 0 to 255 when EPP feature is enabled by platform
>  firmware, if EPP feature is disabled, driver will ignore the written value
>  This attribute is read-write.
>  
> +``base_frequency``
> +	Shows the base frequency of the CPU. Frequencies above this will be in the
> +  ``boost`` range. This attribute is read-only.
> +
>  Other performance and frequency values can be read back from
>  ``/sys/devices/system/cpu/cpuX/acpi_cppc/``, see :ref:`cppc_sysfs`.
>  
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 81fba0dcbee99..0fec66b3f7241 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1037,6 +1037,19 @@ static ssize_t store_status(struct kobject *a, struct kobj_attribute *b,
>  	return ret < 0 ? ret : count;
>  }
>  
> +static ssize_t show_base_frequency(struct cpufreq_policy *policy, char *buf)
> +{
> +	struct amd_cpudata *cpudata = policy->driver_data;
> +	u32 nominal_freq;
> +
> +	nominal_freq = amd_get_nominal_freq(cpudata);
> +	if (nominal_freq < 0)
> +		return nominal_freq;
> +
> +	return sysfs_emit(buf, "%d\n", nominal_freq);
> +}

User can get it from nominal_freq at drivers/acpi/cppc_acpi.c:

show_cppc_data(cppc_get_perf_caps, cppc_perf_caps, nominal_freq);

Thanks,
Ray

> +
> +cpufreq_freq_attr_ro(base_frequency);
>  cpufreq_freq_attr_ro(amd_pstate_max_freq);
>  cpufreq_freq_attr_ro(amd_pstate_lowest_nonlinear_freq);
>  
> @@ -1049,6 +1062,7 @@ static struct freq_attr *amd_pstate_attr[] = {
>  	&amd_pstate_max_freq,
>  	&amd_pstate_lowest_nonlinear_freq,
>  	&amd_pstate_highest_perf,
> +	&base_frequency,
>  	NULL,
>  };
>  
> @@ -1058,6 +1072,7 @@ static struct freq_attr *amd_pstate_epp_attr[] = {
>  	&amd_pstate_highest_perf,
>  	&energy_performance_preference,
>  	&energy_performance_available_preferences,
> +	&base_frequency,
>  	NULL,
>  };
>  
> -- 
> 2.34.1
>