Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Mon, 3 Jul 2023 09:38:48 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Frank Oltmanns <frank@oltmanns.dev>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Andre Przywara <andre.przywara@arm.com>,
        Roman Beranek <me@crly.cz>, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 6/8] clk: sunxi-ng: mux: Support finding closest rate
Message-ID: <b7gnap57aajkbhbbcbgallvqjdc7nzppjjwnancgmm5ibmhdaq@cftau72qyjdu>
References: <20230702-pll-mipi_set_rate_parent-v3-0-46dcb8aa9cbc@oltmanns.dev>
 <20230702-pll-mipi_set_rate_parent-v3-6-46dcb8aa9cbc@oltmanns.dev>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7wsqxsxlujfkioer"
Content-Disposition: inline
In-Reply-To: <20230702-pll-mipi_set_rate_parent-v3-6-46dcb8aa9cbc@oltmanns.dev>
Precedence: bulk


--7wsqxsxlujfkioer
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jul 02, 2023 at 07:55:25PM +0200, Frank Oltmanns wrote:
> When finding the best rate for a mux clock, consider rates that are
> higher than the requested rate by introducing a new clk_ops structure
> that uses the existing __clk_mux_determine_rate_closest function.
> Furthermore introduce an initialization macro that uses this new
> structure.
>=20
> Signed-off-by: Frank Oltmanns <frank@oltmanns.dev>
> ---
>  drivers/clk/sunxi-ng/ccu_mux.c | 13 +++++++++++++
>  drivers/clk/sunxi-ng/ccu_mux.h | 17 +++++++++++++++++
>  2 files changed, 30 insertions(+)
>=20
> diff --git a/drivers/clk/sunxi-ng/ccu_mux.c b/drivers/clk/sunxi-ng/ccu_mu=
x.c
> index 8594d6a4addd..49a592bdeacf 100644
> --- a/drivers/clk/sunxi-ng/ccu_mux.c
> +++ b/drivers/clk/sunxi-ng/ccu_mux.c
> @@ -264,6 +264,19 @@ static unsigned long ccu_mux_recalc_rate(struct clk_=
hw *hw,
>  					   parent_rate);
>  }
> =20
> +const struct clk_ops ccu_mux_closest_ops =3D {
> +	.disable	=3D ccu_mux_disable,
> +	.enable		=3D ccu_mux_enable,
> +	.is_enabled	=3D ccu_mux_is_enabled,
> +
> +	.get_parent	=3D ccu_mux_get_parent,
> +	.set_parent	=3D ccu_mux_set_parent,
> +
> +	.determine_rate	=3D __clk_mux_determine_rate_closest,
> +	.recalc_rate	=3D ccu_mux_recalc_rate,
> +};
> +EXPORT_SYMBOL_NS_GPL(ccu_mux_closest_ops, SUNXI_CCU);
> +

This is also a bit inconsistent with the other clocks: most (all?) of
them will simply handle this through a flag, but this one requires a new
set of clk_ops as well?

I think we should create our own wrapper here around
__clk_mux_determine_rate and either call
__clk_mux_determine_rate_closest or __clk_mux_determine_rate depending
on the state of the flags, or call __clk_mux_determine_rate_flags with
the proper flags set for our clock.

The former is probably slightly simpler.

>  const struct clk_ops ccu_mux_ops =3D {
>  	.disable	=3D ccu_mux_disable,
>  	.enable		=3D ccu_mux_enable,
> diff --git a/drivers/clk/sunxi-ng/ccu_mux.h b/drivers/clk/sunxi-ng/ccu_mu=
x.h
> index 2c1811a445b0..c4ee14e43719 100644
> --- a/drivers/clk/sunxi-ng/ccu_mux.h
> +++ b/drivers/clk/sunxi-ng/ccu_mux.h
> @@ -46,6 +46,22 @@ struct ccu_mux {
>  	struct ccu_common	common;
>  };
> =20
> +#define SUNXI_CCU_MUX_TABLE_WITH_GATE_CLOSEST(_struct, _name, _parents, =
_table,	\
> +				     _reg, _shift, _width, _gate,	\
> +				     _flags)				\
> +	struct ccu_mux _struct =3D {					\
> +		.enable	=3D _gate,					\
> +		.mux	=3D _SUNXI_CCU_MUX_TABLE(_shift, _width, _table),	\
> +		.common	=3D {						\
> +			.reg		=3D _reg,				\
> +			.hw.init	=3D CLK_HW_INIT_PARENTS(_name,	\
> +							      _parents, \
> +							      &ccu_mux_closest_ops, \
> +							      _flags),	\
> +			.features	=3D CCU_FEATURE_CLOSEST_RATE,	\
> +		}							\
> +	}
> +

I'm fine with that one, but like we discussed on the NM (I think?) patch
already, this creates some clocks and macros that will use the feature
as a flag, and some will encode it into their name.

Given that we need it here too, I'm really inclined to prefer what you
did there, and thus create a new macro for pll-video0 instead of
modifying the existing one.

Maxime

--7wsqxsxlujfkioer
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZKJ7CAAKCRDj7w1vZxhR
xX23AP9Gl3oPNcojRTw1oRa+afqZNM7B+cSe67xYnUYlA4vjVgD9GkW8rquZxUuO
0FrevYyTHNypFJAxk4AUScA3gapkoQQ=
=hog7
-----END PGP SIGNATURE-----

--7wsqxsxlujfkioer--