Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <abcfb68b-b631-8a7b-e7cb-daefc58f3dde@axis.com>
Date:   Mon, 3 Jul 2023 09:53:01 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2 1/2] led: led-class: Read max-brightness from
 devicetree
To:     Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Astrid Rost <astrid.rost@axis.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh@kernel.org>, Pavel Machek <pavel@ucw.cz>,
        Lee Jones <lee@kernel.org>
CC:     <kernel@axis.com>, <linux-leds@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230630092248.4146169-1-astrid.rost@axis.com>
 <20230630092248.4146169-2-astrid.rost@axis.com>
 <3e8e7834-fe0e-7e92-5472-cb9fd223980e@gmail.com>
Content-Language: en-US
From:   Astrid Rost <astridr@axis.com>
In-Reply-To: <3e8e7834-fe0e-7e92-5472-cb9fd223980e@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WG9DclVZUk9TdHplTysxUDNRREd5K3o3MEVYY2wwSjRadm0wZkVmYkExRGxQ?=
 =?utf-8?B?T2NRV0JDSm5SZGZPaUVEU2Vxd1plakFTRW85dGh4T2JqN2VnVDQwQk9mdXEz?=
 =?utf-8?B?UjBHNWkrQ2lSRjVLWklyZ0pnZ2RqdUhhR0kvdXZ3USthbExlaVo4SDZTMlBx?=
 =?utf-8?B?UjJoT3BUSEt6Z3ZhOW95R1pETWJMdjB4cUEvNUN2S0ljcXpQUXhEa2U5b0M0?=
 =?utf-8?B?bjZmejBzbVo2SDREVVF1ODR5eXZVNzdDdnFLS1U5R0VvUEltWnV5SnQxazF0?=
 =?utf-8?B?RXBycktvUURSRG9BVmkyQzhxb2luYWpZcXgxbGNVbk9VS04wTVBEN1lhMjQ1?=
 =?utf-8?B?Nm9XMmZoK0xRN3h1RmlubTNlUVAxbVh3U2taMEttN0VMMEZhU0VRcDFtRzRh?=
 =?utf-8?B?UTBFQXFVTHMvNG9MMzZiN0pvMTQyMmVLUHVxU2ZTQzRxTUU2V3VLSXE3L1gr?=
 =?utf-8?B?TlZ2REtPVENqS0VSR0RIQjNaaGlOT0NNYW13cFVIR1gyR3dZSXo1MXN2WDN0?=
 =?utf-8?B?QjdPMWVTK1p0UkVxbU9Wb2o4TjVUSVlHbmlvVWh4bDI2eHZ4blFXZmMvSEYw?=
 =?utf-8?B?eWlvNUIxbDF3YWV0MWVXRG8yNzQ5VS9TRTRXQjBYZnNsM0h3MEEyNHNNRHJH?=
 =?utf-8?B?M04vWjRhcGZmaVFDc29lcGNPaGpYaWFlMjRUY1FDbnhqZGV5eE5WenJDRkRo?=
 =?utf-8?B?OHhBVU14TmgwQ25LOEpJb2NtdHdCQzZMQ3gwSGt6M2ZjTCs2QkgwLzRaTjlM?=
 =?utf-8?B?enBEcm1Cb24zVkNZcVU2cndxclM1dCtER3BKTEtYL2hSVlNzdkR5eFRrc3V2?=
 =?utf-8?B?YjVqek9HaFJhMS8wYTh2U1hJaFNVZ0VsTGlyUjBlbzJJaEhid3FydDdsbjUz?=
 =?utf-8?B?OVErM0srdmVTZTFiTWdkOW0yZWxyaUR0ZzVCY0ovMHVpQWdHRHhkODhNLy9y?=
 =?utf-8?B?cGt3TndweStweVVObDFwYlpKWFp4cmlpVGJpMUc0S2tpeWFDSk1wdFk4aHBv?=
 =?utf-8?B?YjNTc1pyaU9VRXRGV1ZzbW1zcmdiaXVQUFJ4N0ZqaktuN3hpRE85aW1vRE4v?=
 =?utf-8?B?UkVyUHJkNi9VWVJVWDBPNmRGWnNjSGxQTTg4ckY2eXJIem1zYklRTG02Lzd5?=
 =?utf-8?B?dlhDNGlMVUxZaS9iWUVRTjNqc1dqQXZJZm9sQVVyQ01CYVZwT1NMeEM1Q09B?=
 =?utf-8?B?VERmSW1ZM2hJRVVWdE1BdS9SdVpLRUlzRE5nODNiaVd2aWZqYjlwckZGbEdp?=
 =?utf-8?B?SUtYeGN5dHhvQjY2R281MTBmSTlGbkVGdnp5MmhNQ3UrdjFGUzBCdDlMcktC?=
 =?utf-8?B?enlBR2kxRldRRG5udEl2OUNrZE4wZ1FBcjAvTUxtT084RWNPWFhnc1czaERK?=
 =?utf-8?B?TXUvNm4xenFjL09FUUZHQW04cVZLeUtDaUJ3RXFjTGp0djNzVUNvQWl6OEQ2?=
 =?utf-8?B?WXl6UUhCM1lCUFZSR1daZmt1dlVoUFViejNzZFVYaEk4aXVMTjdXT2lsS2dY?=
 =?utf-8?B?cWJaVUt6OHplZ3VkZFNYM2dJbzFqbW9xbzVEWFlyWm1mTzRBM2tNbFcwUUw5?=
 =?utf-8?B?SUpMVnR1aEtZdEVvSDIrZ1I5cHNvczRBclhSRVNmRnFHelE0RmdxMVBMQzkr?=
 =?utf-8?B?RWg1bzlUK01xTWc3NkRuNnJHL3c5T0hXeWVyeFBwNXdqOEdtTGV0QlRiU0ND?=
 =?utf-8?B?NEVKRzZySkZyQkR4S3RWYkc3V0F2dHhmbFBmZkg1UEsvS0J2SmdzVGdwdmM5?=
 =?utf-8?B?RXptR2J6azZXa1lDK1Y5dDYwQm5PZE1XUU9HcUozaVNVRFFxSEhpMlpCcDVm?=
 =?utf-8?B?SENPcmh5VGVMRzFzdngyOGpyanBoWStZTHZNNFlSb1VwZ3FpUm0ydlAzTlhT?=
 =?utf-8?B?akV2SGx1VHRMWnczQlRJa3RhcjJaNDNtWHpDWXdJeGJHdjBJd3o2L0oxNmk0?=
 =?utf-8?B?elRXekZGbzhFd3ZENjU3dEszZ1oySFYyOGd3LzlLeVMwVW5HS3VtN3lpdSt0?=
 =?utf-8?B?RHBFVUhadHVBTGdjR20vd1VEN3lSZkhaSG9VUStWRlhYRWpSeUJjb0k2OXNn?=
 =?utf-8?B?LzZQNEp5SWtyaU1uSHdOQWNaVkU3RUpUemRLem1TVThHYVB3RmxZTTNvOVd4?=
 =?utf-8?Q?lQTw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f709370-bce7-469d-39ea-08db7b9a87c1
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB9467.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 07:53:03.7590
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M/HSkg+gvFAVgmZpcqjlRisA6VYCNZT8buxaqkYwJChNZZTxYIoc4fmejLVz8RHlsms3D8p3ILiXquysHsdluA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR02MB9794
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Jacek,

I am having problems with the PWM controller LP5024.

https://www.ti.com/product/LP5024

There is no such a calculation in the data-sheet like:
max_brightness = max_current / constant.

I also assume it is depending on the type of LEDs and circuit, which are 
connected.

It supports two current modes: 25,5 mA and and 35 mA, both is to high 
for the LEDs I have.

For max_brightness seems to be everything inside the kernel, but reading 
the value from devicetree. I first thought I could add it in the lp50xx
driver, but Andy and Rob thought that I better put it into the general 
parts. And of course drivers having led-max-microamp should better use it.

Please, let me know if you have a better suggestion.

Astrid


On 7/1/23 13:09, Jacek Anaszewski wrote:
> Hi Astrid,
> 
> On 6/30/23 11:22, Astrid Rost wrote:
>> Add max-brightness in order to reduce the current on the connected LEDs.
>> Normally, the maximum brightness is determined by the hardware, and this
>> property is not required. This property is used to set a software limit.
>> It could happen that an LED is made so bright that it gets damaged or
>> causes damage due to restrictions in a specific system, such as mounting
>> conditions. Note that led-max-microamp should be preferably used, if it
>> is supported by the controller.
>>
>> Signed-off-by: Astrid Rost <astrid.rost@axis.com>
>> ---
>>   drivers/leds/led-class.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
>> index 9255bc11f99d..ce652abf9336 100644
>> --- a/drivers/leds/led-class.c
>> +++ b/drivers/leds/led-class.c
>> @@ -457,6 +457,10 @@ int led_classdev_register_ext(struct device *parent,
>>               if (fwnode_property_present(init_data->fwnode,
>>                               "retain-state-shutdown"))
>>                   led_cdev->flags |= LED_RETAIN_AT_SHUTDOWN;
>> +
>> +            fwnode_property_read_u32(init_data->fwnode,
>> +                "max-brightness",
>> +                &led_cdev->max_brightness);
>>           }
>>       } else {
>>           proposed_name = led_cdev->name;
> 
> We have led-max-microamp for that and every LED class driver is supposed
> to calculate its max brightness level basing on it.
>