Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Mon, 3 Jul 2023 09:50:05 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Frank Oltmanns <frank@oltmanns.dev>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Andre Przywara <andre.przywara@arm.com>,
        Roman Beranek <me@crly.cz>, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 8/8] clk: sunxi-ng: a64: select closest rate for
 pll-video0
Message-ID: <lfcpuv5euy5w6e7jzn6fm2qusjj52w2hhn5sosqvoz54zc56py@5wh2eea3rrs3>
References: <20230702-pll-mipi_set_rate_parent-v3-0-46dcb8aa9cbc@oltmanns.dev>
 <20230702-pll-mipi_set_rate_parent-v3-8-46dcb8aa9cbc@oltmanns.dev>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="scpwnkcrk67jfkfn"
Content-Disposition: inline
In-Reply-To: <20230702-pll-mipi_set_rate_parent-v3-8-46dcb8aa9cbc@oltmanns.dev>
Precedence: bulk


--scpwnkcrk67jfkfn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Jul 02, 2023 at 07:55:27PM +0200, Frank Oltmanns wrote:
> @@ -541,7 +542,7 @@ static const char * const tcon1_parents[] = { "pll-video0", "pll-video1" };
>  static const u8 tcon1_table[] = { 0, 2, };
>  static struct ccu_div tcon1_clk = {
>  	.enable		= BIT(31),
> -	.div		= _SUNXI_CCU_DIV(0, 4),
> +	.div		= _SUNXI_CCU_DIV_FLAGS(0, 4, CLK_DIVIDER_ROUND_CLOSEST),
>  	.mux		= _SUNXI_CCU_MUX_TABLE(24, 2, tcon1_table),
>  	.common		= {
>  		.reg		= 0x11c,
> @@ -549,6 +550,7 @@ static struct ccu_div tcon1_clk = {
>  						      tcon1_parents,
>  						      &ccu_div_ops,
>  						      CLK_SET_RATE_PARENT),
> +		.features	= CCU_FEATURE_CLOSEST_RATE,
>  	},
>  };

I'm not super comfortable with having to set it twice for dividers (or
composite clocks). Could we set CLK_DIVIDER_ROUND_CLOSEST automatically
if CCU_FEATURE_CLOSEST_RATE is set?

I'm guessing we would need it for muxes as well?

Maxime

--scpwnkcrk67jfkfn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZKJ9rQAKCRDj7w1vZxhR
xfKdAQDoedHfL48OImEDGH6Me5/cxerV8zCFt0MPDatzDChGWAEAs70t/UrLzho6
FXnXOCNE5lVTqlIl/hE5si3bdNAfXwU=
=lwbj
-----END PGP SIGNATURE-----

--scpwnkcrk67jfkfn--