Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0d2dcb62-8475-8b2a-7ba9-bdabab3d0aa4@gmail.com>
Date:   Mon, 3 Jul 2023 11:32:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2 1/2] led: led-class: Read max-brightness from
 devicetree
To:     Astrid Rost <astridr@axis.com>, Astrid Rost <astrid.rost@axis.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh@kernel.org>, Pavel Machek <pavel@ucw.cz>,
        Lee Jones <lee@kernel.org>
Cc:     kernel@axis.com, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230630092248.4146169-1-astrid.rost@axis.com>
 <20230630092248.4146169-2-astrid.rost@axis.com>
 <3e8e7834-fe0e-7e92-5472-cb9fd223980e@gmail.com>
 <abcfb68b-b631-8a7b-e7cb-daefc58f3dde@axis.com>
Content-Language: en-US
From:   Jacek Anaszewski <jacek.anaszewski@gmail.com>
In-Reply-To: <abcfb68b-b631-8a7b-e7cb-daefc58f3dde@axis.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Astrid,

On 7/3/23 09:53, Astrid Rost wrote:
> Hello Jacek,
> 
> I am having problems with the PWM controller LP5024.
> 
> https://www.ti.com/product/LP5024
> 
> There is no such a calculation in the data-sheet like:
> max_brightness = max_current / constant.
> 
> I also assume it is depending on the type of LEDs and circuit, which are 
> connected.
> 
> It supports two current modes: 25,5 mA and and 35 mA, both is to high 
> for the LEDs I have.
> 
> For max_brightness seems to be everything inside the kernel, but reading 
> the value from devicetree. I first thought I could add it in the lp50xx
> driver, but Andy and Rob thought that I better put it into the general 
> parts. And of course drivers having led-max-microamp should better use it.
> 
> Please, let me know if you have a better suggestion.

OK, since this LED controller is PWM-driven then there is no current per
brightness level granulation. Bindings of leds-pwm driver also use
max-brightness DT property. So, yeah, let's make it a common property,
but state clearly that it is mainly for drivers like PWM ones, where it
is not possible to map brightness level to the amount of current.

-- 
Best regards,
Jacek Anaszewski