Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     richard@nod.at, anton.ivanov@cambridgegreys.com,
        johannes@sipsolutions.net, sfr@canb.auug.org.au,
        linux-um@lists.infradead.org, linux-kernel@vger.kernel.org,
        machel@vivo.com
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] drivers: use free_netdev before return
Date:   Mon,  3 Jul 2023 17:41:35 +0800
Message-Id: <20230703094135.6443-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hV5maB3VKegc8cGjFIxZh+CxDH8f+x1xITCunNNQnlgOoEbhEPqRgiIcTD1I?=
 =?us-ascii?Q?63p0YKW0I89tivi2fnsm+F5/VVEZHLwpZj0rABs1VsX9cu0AQM8Ke5Jr5Wj1?=
 =?us-ascii?Q?m5M8a1MV+zJAe5gVI7u1IgS3H0OA9kiupqSGYRAldeOk20SEAKSDe8hdvWk8?=
 =?us-ascii?Q?nBzhR7Q7XG7Q04K4WuYx+ngRe3YWisKCwWU+kBP36IF6c9eLb9TQcEZ1lx/S?=
 =?us-ascii?Q?JeQpp+h5lZr+Sphl5zDK61jLMtSdzL7zEPoYxsyKSRmMZajraSMar1/Gma4Q?=
 =?us-ascii?Q?8y3O+cApyMg+iJ5LURLnSQLlZrJtHDAVywHSkQuE9my7iqGSuhLMRVNSVRPz?=
 =?us-ascii?Q?yhRz6y0hpPES65u1LDFKRK5w0QaBMfDJxyijuUWCIWazgnqLz+o6cIi3SYm4?=
 =?us-ascii?Q?HV137Txa8Rp+/8TW2hVWLVNh2E0Ta5hE5lQxt06IfZuqtJpg11MlRrAvmsS7?=
 =?us-ascii?Q?W79nNACQBIYZBq72GdcYrROlkN0QiWLA+LopyA3VSY4kEg3m/jAVqLof9yrw?=
 =?us-ascii?Q?KWavZkstdFO2liosJOvTag1VLB36C7eMTHL5tl0ZK9b3hXhVGB3dZQxNMKNx?=
 =?us-ascii?Q?w/Yb7YZViKT8Pjoe/VRsYLVi4bgMz2tZyA8b4MveeuKPgxNbdHwJ0EPVSmsD?=
 =?us-ascii?Q?6mrysUXWx9wpahz1yNJoJdnNIFFbfYJY0EUO9YMOLkAAFKoNUbWQOazvJtuQ?=
 =?us-ascii?Q?3yQ8YxZ1tgaEAeNWCfuVnkHa9dSqPCxCodHWMy6EJdA+yaJ7tdONx4FqtGaw?=
 =?us-ascii?Q?iz0luM90Ddd4UYCjPzakcaMecA+z+Jn6fLh40HLYS/FrZrLURiA/S8Z1RBez?=
 =?us-ascii?Q?kcTy7+rjpyH/pr67cGwRGl66RKryGcKb3UVtWb4jNJ1OEXQRXRhKqclnemNg?=
 =?us-ascii?Q?OcfTs3vgqcK5Z2vQgS++d0vmP1bYNXIiQSEFeNoa/QvSpYVckdxPFa2bzRnI?=
 =?us-ascii?Q?YuWQH216RdITa7oiVTpBtj63h61jwaQrPYd/AbnstAcDKla3l1EUaK+5NEAG?=
 =?us-ascii?Q?3tUlgfwT5ONDh6RM5XL0DVExKH4pt00qLjtIilO9XHOoE3AAnx4KivCmZDVE?=
 =?us-ascii?Q?Gk4XnJqxJtzd/GQQ+Rc/yDbnw4MVZfngT6OMHY65jBEdRQ9Fg1Pq1oCMeFz9?=
 =?us-ascii?Q?78bGOmj/gKMMxzea/Jg4PYh7EOyi3JQS4zwkmieYglyoGN2BRYNfKHSV3t4c?=
 =?us-ascii?Q?TlvB4A2mZ3SRHkYA4qK0WKTIyr1RSgUhu3aQZ2gj4rQbEFVDNECfTxkrTRVI?=
 =?us-ascii?Q?tUdWgLZ/KzrF3aQKQy/cMVTC5Yh9WX/qynI0715pRZUaX8T4kRR9Ija/d8H0?=
 =?us-ascii?Q?FOI9yYl3uxdK9MUsPmvn97GuyC4DvWvlNua/HLhc46FswRzLvbfwbdUp3zzE?=
 =?us-ascii?Q?Hoo5fpZYt5UVzFXcGLPtDcpooaLc6mZ95hnPEZ4799EhHqQsAZ1MWLPsJI7j?=
 =?us-ascii?Q?Wsv46pue0qtoQfhJCtXGe3FONsOxjobeeYhvrfuxRbdXA8wHjZ71vhCM8J7M?=
 =?us-ascii?Q?3PSQAWfwkzf7FcKrTehxyiy21GWzHQ9LlweB/yr7jCNLTDvort7DqvDRIFPE?=
 =?us-ascii?Q?tuT6rTDihKB8C/XQuAENV7La/lag/EhJgBGdhIfY?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8830768c-43f4-4a4e-cd9d-08db7ba9b7a7
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 09:41:46.6017
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DP/J2QA53wTVntGRbU35ySHFh76WrKT68paWjG6vz1rpxO9ruXefPYQO0sYsd76Bl4anOjEj4g8I/OdCJoTv+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5480
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

We fixed a bug where the variable dev
was not freed before return.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 arch/um/drivers/vector_kern.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
index 131b7cb29..af7f6fd4c 100644
--- a/arch/um/drivers/vector_kern.c
+++ b/arch/um/drivers/vector_kern.c
@@ -1655,6 +1655,7 @@ static void vector_eth_configure(
 	return;
 
 out_undo_user_init:
+	free_netdev(dev);
 	return;
 out_free_netdev:
 	free_netdev(dev);
-- 
2.39.0