Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0f4f5a4d-379b-c00c-6bf2-58c08fcc4551@linaro.org>
Date:   Mon, 3 Jul 2023 11:56:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 1/2] arm64: dts: qcom: minor whitespace cleanup around '='
Content-Language: en-US
To:     Johan Hovold <johan@kernel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230702185051.43867-1-krzysztof.kozlowski@linaro.org>
 <e09af830-d114-7ee6-0cab-e6812bc10fd4@linaro.org>
 <ZKKXGE95Sv-eLQa8@hovoldconsulting.com>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <ZKKXGE95Sv-eLQa8@hovoldconsulting.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3.07.2023 11:38, Johan Hovold wrote:
> On Mon, Jul 03, 2023 at 11:30:24AM +0200, Konrad Dybcio wrote:
>> On 2.07.2023 20:50, Krzysztof Kozlowski wrote:
>>> The DTS code coding style expects exactly one space before and after '='
>>> sign.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
> 
> [...]
>  
>>> diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi
>>> index 895cafc11480..c4209e2d4b4e 100644
>>> --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi
>>> @@ -155,7 +155,7 @@ CPU7: cpu@3 {
>>>  
>>>  		idle-states {
>>>  			CPU_SLEEP_0: cpu-sleep-0 {
>>> -				compatible ="qcom,idle-state-spc", "arm,idle-state";
>>> +				compatible = "qcom,idle-state-spc", "arm,idle-state";
>> Will conflict with:
>>
>> https://lore.kernel.org/linux-arm-msm/20230627-topic-more_bindings-v1-2-6b4b6cd081e5@linaro.org/
>>
>> there are also a couple of entries with property =\n\t{n}[a-z]
>>
>> Otherwise lgtm
>  
> Konrad, please remember to trim irrelevant context from your replies
> (e.g. so that we don't have to skim through thousands of lines to find
> a single comment).
My actual reply begins at line 77, which is considerably less than
thousands and is concluded by my signoff, which signifies the end
of the message.

Konrad
> 
> Johan