Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Jul 2023 11:47:53 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Andrew Jones <ajones@ventanamicro.com>
CC:     Amma Lee <lixiaoyun@binary-semi.com>, <paul.walmsley@sifive.com>,
        <palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
        <xiezx@binary-semi.com>, <linux-riscv@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: optimize ELF relocation function in riscv
Message-ID: <20230703-pretender-sculptor-c76e6d7428f5@wendy>
References: <1688355132-62933-1-git-send-email-lixiaoyun@binary-semi.com>
 <20230703-8fe42edab5ff83cea01db4f9@orel>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="BlJnNwQEuty8t1OC"
Content-Disposition: inline
In-Reply-To: <20230703-8fe42edab5ff83cea01db4f9@orel>
Precedence: bulk

--BlJnNwQEuty8t1OC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 03, 2023 at 12:35:15PM +0200, Andrew Jones wrote:
> On Mon, Jul 03, 2023 at 11:32:12AM +0800, Amma Lee wrote:
> > The patch can optimize the running times of insmod command by modify ELF
> > relocation function.
> > In the 5.10 and latest kernel, when install the riscv ELF drivers which
> > contains multiple symbol table items to be relocated, kernel takes a lot
> > of time to execute the relocation. For example, we install a 3+MB driver
> > need 180+s.
> > We focus on the riscv architecture handle R_RISCV_HI20 and R_RISCV_LO20
> > type items relocation function in the arch\riscv\kernel\module.c and
> > find that there are two-loops in the function. If we modify the begin
> > number in the second for-loops iteration, we could save significant time
> > for installation. We install the same 3+MB driver could just need 2s.
> >=20
> > Signed-off-by: Amma Lee <lixiaoyun@binary-semi.com>
> > ---
> >  arch/riscv/kernel/module.c | 67 ++++++++++++++++++++++++++++++++++++++=
+++++---
> >  1 file changed, 64 insertions(+), 3 deletions(-)
> >
>=20
> I guess this is a v3 of [1]? But there's no change log here to know
> what's different.
>=20
> [1] 1683881513-18730-1-git-send-email-lixiaoyun@binary-semi.com

It's also still got the checkpatch issues (and possibly others) that
were pointed out previously.

Cheers,
Conor.

Also, when applying the patch:
warning: arch/riscv/kernel/module.c has type 100644, expected 100755

--BlJnNwQEuty8t1OC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZKKnWQAKCRB4tDGHoIJi
0rzGAP4yGsFWAkWYAe/FI+YHgNsq3eWaO1BQaNBLdLesfizvMAD+Pq0/kv1xh2cr
KSbR74+nIN1TFVixuSIxcxQnJu9FGAU=
=pumt
-----END PGP SIGNATURE-----

--BlJnNwQEuty8t1OC--